astrodenoise crashes darktable: Is it just me?

Terry · March 21, 2023, 7:38am

I have now had astrodenoise cause crashes on two windows laptops and a linux desktop. This is a regular problem for me. I presume the module is very resource intensive and my systems are just too sluggish. I really like the noise reduction this module gives when working with very noisy images.

When darktable crashes I lose many steps of my editing so I usually now open a new image in DT to force a xmp file update. I then return to the image and try astrodenoise. Sometimes it crashes and sometimes it doesn’t. I just wonder if anyone else can replicate this problem or if astrodenoise works fine for everyone else but me. Drawing masks or adjusting the details threshold slider often results in a crash of DT in this module.

Also, is there a lau script to force an update of the xmp file as you work.

Thanks for taking the time to read this and testing the module on your computer.

Pascal_Obry · March 21, 2023, 12:32pm

Which dt version?

Pascal_Obry · March 21, 2023, 12:36pm

I’m asking because there was multiple reports about this and it is fixed in master:

github.com/darktable-org/darktable

Crash in astrophoto denoise

opened 01:09AM - 18 Oct 22 UTC

closed 10:18AM - 09 Feb 23 UTC

paolodepetrillo

I am getting a random segfault in the astrophoto denoise module - if I drag the …exposure slider around it will crash within a few seconds. The segfault occurs here: https://github.com/darktable-org/darktable/blob/22078abbb8dfe7cfb305ad6b788d17c1660b345a/src/common/nlmeans_core.c#L710 It looks like the problem is in this line: `__m128 pixel = _mm_load_ps(in+4*col+offset);` _mm_load_ps requires that its operand is aligned to 16 bytes, but in+4*col+offset is not guaranteed to be aligned that way. As a quick test I changed all instances of _mm_load_ps in the file to _mm_loadu_ps which does not have the alignment requirement, and that fixes the crash. **Platform** * darktable version : 4.1.0+577~gafb0ac5c0 * Linux - Distro : Arch Linux * Memory : 16GB * Graphics card : GTX 1080 * Graphics driver : * OpenCL installed : yes * OpenCL activated : no * Xorg : 21.1.4 * Desktop : kde * GTK+ : 3.24.34 * gcc : 12.2.0 * cflags : * CMAKE_BUILD_TYPE : RelWithDebInfo

Terry · March 21, 2023, 12:50pm

I am using 4.2 on linux and windows laptop has latest weekly build but no graphics card. Hopefully is fixed. Maybe other users would like to test drapwing masks orusing detail threshold slider. Thanks for feedback as it is very good at noise reduction.

Bernhard_Vogler · March 21, 2023, 11:26pm

I am on 4.3.0+1304~g7cdbd0bcb7 on windows 11, applying astro denoise works, no crash

Terry · March 21, 2023, 11:42pm

@Bernhard_Vogler Could you try drawing a mask and or use the details threshold slider? I am certainly willing to accept it is my computers. I have eight students tomorrow night and I am going to get them to try the module and see what happens. The module is very good for denoising the worst images.

Bernhard_Vogler · March 22, 2023, 12:37am

I did not see any negative effects using drawn masks, or details threshold, or both; still stable; no crash. I just applied it to two different random pictures. No crash.

g-man · March 22, 2023, 12:57am

@Terry If you open the link Pascal shared, you will see that the fix was merged 05FEB and it is part of the 4.4 release. Therefore you have two options. Wait until ~July for 4.4 release or switch to use the master branch.

Terry · March 22, 2023, 1:21am

@g-man my latest crash occurred using 4.3.0+1304. However that laptop doesn’t have a graphics card so it was probably a resource issue. I am glad that the issue has been addressed and will be in V4.4. Thanks for taking the time to respond and I look forward to the new release. I am not confident at building the master branch in Linux as I am a Linux newbie.