Call for testing: My Luminance HDR fork with a lot of speedups and reduced memory usage

Ingo,

It must be some problem in gmail dropping the attachment. I can see the log file attached in my version of the email on my desktop and my android tablet in the gmail app. Here is the screen print.


I will attach the log file again here.

regards

David

I have put a copy of the log file on drive, in case the email system drops it again. Here is the link.

https://drive.google.com/file/d/0Bx8EoRB4WtGcSFcwWlBfUlFUVF9sMUtkaFVUekMxWXdzbjhr/view?usp=drivesdk

Are you sure using the current master branch?
In your screenshot, there is an error in line 46, which in current code is a comment

@David_Wilson follow this simple guide, and if compilation fails, attach the whole log, from the moment you typed “wget”, to the last line. Attach the log directly to this forum, or upload using https://filebin.net/ I won’t be following any Google Drive links which require me to “request access”, there’s no need to complicate things.

@gaaned92 your build Luminance-HDR_master_v.2.5.1-194-g68aa044b_WinVista_64.exe runs fine in wine.

Since you were replying on email, the forum is stripping quoted material. Notice the quote level of your pasted-in text. Instead of a quote, surround the data with lines containing three backticks:

```

Pasted data

```

1 Like

I have followed Morgan_Hardwood’s directions.

Here is the clonsole log:

Here is the Cmake output log: https://filebin.net/lbmtppi3r0ezxnak/CMakeOutput.log

regards

David

@David_Wilson thank you, but that is not the log I requested.


Morgan_Hardwood

I truly do not understand what other log you want and would like to help.

in your last message you wrote

Perhaps when you wrote “follow this simple guide” you intended to link to some instructions ? I found your instruction for building HDRMerge elsewhere in the forum and followed those.

So I have the console output from the moment I typed “wget”, to the last line quoted in the email.

And the file.bin has the cmake output log.

I confirm that there was no direct link to the ‘simple guide’, which was at least confusing.

I would like to know, whether you still get errors during build when building from latest lhdr code. And if you get errors (your latest log didn’t show errors or I missed them), please show the error messages.

For information:

This one is is already merged.

This one will be merged soon

What has been causing the confusion is that I replied using gmail and quoting the console output which the forum stripped out as well as the attachments. So the lesson is reply only through the forum.

Here is the clonsole log in plain text.

dnw@Capulet:/test/lhdr$ wget https://raw.githubusercontent.com/pixlsus/Scripts/master/build-lhdr
--2018-03-31 13:47:24--  https://raw.githubusercontent.com/pixlsus/Scripts/master/build-lhdr
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 151.101.80.133
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|151.101.80.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 4245 (4.1K) [text/plain]
Saving to: 'build-lhdr’

build-lhdr                 100%[=====================================>]   4.15K  10.9KB/s    in 0.4s     
2018-03-31 13:47:45 (10.9 KB/s) - 'build-lhdr’ saved [4245/4245]

dnw@Capulet:/test/lhdr$ chmod +x build-lhdr
dnw@Capulet:/test/lhdr$ ./build-lhdr

Program name: lhdr
Build type: release
Build without updating: false

Cloning into '/home/dnw/programs/code-lhdr'...
remote: Counting objects: 26174, done.
remote: Compressing objects: 100% (123/123), done.
remote: Total 26174 (delta 64), reused 67 (delta 26), pack-reused 26025
Receiving objects: 100% (26174/26174), 28.68 MiB | 1.36 MiB/s, done.
Resolving deltas: 100% (20861/20861), done.
-- The C compiler identification is GNU 7.2.0
-- The CXX compiler identification is GNU 7.2.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- C++11 activated for GCC 7

-- GCC >= 4.3
-- Found OpenMP_C: -fopenmp (found version "4.5")  
-- Found OpenMP_CXX: -fopenmp (found version "4.5")  
-- Performing Test HAS_BRANCH_PREDICTION
-- Performing Test HAS_BRANCH_PREDICTION - Success
-- Found Git: /usr/bin/git (found version "2.14.1")  
-- Found LIBRAW: /usr/lib/x86_64-linux-gnu/libraw_r.so   
-- Found LibRAW (LIBRAW_INCLUDE_DIR = /usr/include)
-- Found LibRAW (LIBRAW_LIBRARIES = /usr/lib/x86_64-linux-gnu/libraw_r.so)
-- Found demosaicing pack GPL2
-- Found demosaicing pack GPL3
-- Found FFTW3F (FFTWF_INCLUDE_DIR = /usr/include)
-- Found FFTW3F (FFTWF_LIBRARIES = /usr/lib/x86_64-linux-gnu/libfftw3f.so;/usr/lib/x86_64-linux-gnu/libff
tw3f_threads.so)
-- Found LCMS2: /usr/lib/x86_64-linux-gnu/liblcms2.so   
-- Found LCMS2 (LCMS2_LIBRARIES = /usr/lib/x86_64-linux-gnu/liblcms2.so)
-- Found LCMS2 (LCMS2_INCLUDE_DIR = /usr/include)
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE   
-- Boost version: 1.62.0
-- Found the following Boost libraries:
--   program_options
--   thread
--   chrono
--   system
--   date_time
--   atomic
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")  
-- Checking for module 'exiv2'
--   Found exiv2, version 0.25
-- Found Exiv2: /usr/lib/x86_64-linux-gnu/libexiv2.so (Required is at least version "0.21")  
-- Found TIFF: /usr/lib/x86_64-linux-gnu/libtiff.so (found version "4.0.8")  
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")  
-- Found PNG: /usr/lib/x86_64-linux-gnu/libpng.so (found version "1.6.34")  
-- Found OpenEXR: /usr/lib/x86_64-linux-gnu/libHalf.so;/usr/lib/x86_64-linux-gnu/libIex.so;/usr/lib/x86_6
4-linux-gnu/libIlmImf.so;/usr/lib/x86_64-linux-gnu/libIlmThread.so;/usr/lib/x86_64-linux-gnu/libImath.so
 
-- OpenEXR found
-- Found GNU Scientific Library (GSL_LIBRARY = /usr/lib/x86_64-linux-gnu/libgsl.so)
-- Found GNU Scientific Library: (GSL_CBLAS_LIBRARY = /usr/lib/x86_64-linux-gnu/libgslcblas.so)
-- Found GNU Scientific Library: (GSL_INCLUDE_DIR = /usr/include)
-- Found JPEG: /usr/lib/x86_64-linux-gnu/libjpeg.so   
-- Found CFITSIO: /usr/lib/x86_64-linux-gnu/libcfitsio.so   
-- Could NOT find Qt5WebEngineWidgets (missing: Qt5WebEngineWidgets_DIR)
CMake Error at /usr/lib/x86_64-linux-gnu/cmake/Qt5Core/Qt5CoreMacros.cmake:331 (message):
 Can not use "WebEngineWidgets" module which has not yet been found.
Call Stack (most recent call first):
 src/UI/CMakeLists.txt:53 (qt5_use_modules)


-- Configuring incomplete, errors occurred!
See also "/home/dnw/programs/code-lhdr/build/CMakeFiles/CMakeOutput.log".
dnw@Capulet:/test/lhdr$

Ok, thanks for the log. I 'll have a closer look tomorrow. Seems solvable

Apologies @David_Wilson, I didn’t paste the link. Here it is:

Thank you for the log.

The CMake script assumes that if you have QtWebEngineCore, then you also have QtWebEngineWidgets. In my distro, Sabayon, /usr/include/qt5/QtWebEngineWidgets is installed by dev-qt/qtwebengine. Maybe in your distro these are two separate packages, and you’re missing the widgets package?

Do you have /usr/include/qt5/QtWebKitWidgets ?

@heckflosse how about this:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2b46cc88..9cb2c17a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -40,18 +40,25 @@ find_package(Qt5Core             REQUIRED)
 find_package(Qt5Concurrent       REQUIRED)
 find_package(Qt5Widgets          REQUIRED)
 find_package(Qt5Gui              REQUIRED)
+
 # QtWebEngine is preferred web engine because QtWebKit is deprecated since Qt 5.5:
 # https://wiki.qt.io/New-Features-in-Qt-5.5#Deprecated_Functionality. Unfortunately,
 # some Qt distributions still provide QtWebKit instead of QtWebEngine. So first we
 # try to find QtWebEngine and if not found, we fall back to QtWebKit.
-find_package(Qt5WebEngineCore    QUIET)
+find_package(Qt5WebEngineCore)
 if(Qt5WebEngineCore_FOUND)
-    find_package(Qt5WebEngineWidgets REQUIRED)
+    find_package(Qt5WebEngineWidgets)
+endif()
+
+if(Qt5WebEngineWidgets_FOUND)
+    message(STATUS "Using QtWebEngine")
 else()
     find_package(Qt5WebKit           REQUIRED)
     find_package(Qt5WebKitWidgets    REQUIRED)
     add_definitions(-DUSE_DEPRECATED_QTWEBKIT)
+    message(STATUS "Using QtWebKit")
 endif()
+
 find_package(Qt5Xml              REQUIRED)
 find_package(Qt5Sql              REQUIRED)
 find_package(Qt5Svg              REQUIRED)

If Qt5WebEngineCore is found but Qt5WebEngineWidgets is missing, as in @David_Wilson’s case, it will fall back to QtWebKit.