darktable 2.5 & 2.6 denoise-profile and pixelpipe

Software darktable
1

Hi folks,

I fully appreciate the new abilities of denoise profiles.

Just I have some issues…

I have a complex preset of 3x3 set of denoise profile, where I use different strength acc. to parametric mask based on L-channel utilizing wavelet-color; brightness and normal

Those are depending on the sequence in the pixelpipe and this seems not to work anymore, means I find the modules in a different consecutive sequence than previously set and successfully used.

Effect: all my HighISO pics don’t look that good anymore (partially blotchy and lost the great contrast I achieved with my preset).

Currently I have no other solution than open one by one, disable all my denoise and apply a new preset. Especially the disabling without loosing all mods is a pain to me, as I am not a coder and need to do it manually :-/

Any ideas possible?

Cheers
Axel

2

Could you please share your style so that I try to reproduce?
Please also report the bug on redmine

3

That sounds bad.
is the order different in -d perf -d dev output, too? (do post the output from 2.4 and 2.6rc)

4

Dear Roman,

when I typed this, my last event was with 2.5-git, quite up to date. Now since yesterday evening it is 2.6.0rc1+38~g61c602baa.
Guess what… the pixlepipe looks o.k.
pixelpipe cacheline 0 used 0 by 18446744073709551615
pixelpipe cacheline 1 used 0 by 18446744073709551615
pixelpipe cacheline 2 used 0 by 18446744073709551615
pixelpipe cacheline 3 used 0 by 18446744073709551615
pixelpipe cacheline 4 used 0 by 18446744073709551615
cache hit rate so far: 0,015
285,181548 [dev_pixelpipe] took 0,000 secs (0,000 CPU) initing base buffer [preview]
285,182027 [dev_pixelpipe] took 0,000 secs (0,002 CPU) processed Raw-Schwarz-/Weißpunkt' on CPU, blended on CPU [preview] 285,182401 [dev_pixelpipe] took 0,000 secs (0,003 CPU) processed Weißabgleich’ on CPU, blended on CPU [preview]
285,182746 [dev_pixelpipe] took 0,000 secs (0,002 CPU) processed Spitzlicht-Rekonstruktion' on CPU, blended on CPU [preview] 285,184291 [dev_pixelpipe] took 0,002 secs (0,005 CPU) processed Tote Pixel’ on CPU, blended on CPU [preview]
285,253442 [dev_pixelpipe] took 0,069 secs (0,578 CPU) processed Entrastern' on CPU, blended on CPU [preview] 285,373954 [dev_pixelpipe] took 0,120 secs (1,146 CPU) processed Entrauschen (Profil)’ on CPU, blended on CPU [preview]
285,487191 [dev_pixelpipe] took 0,113 secs (1,060 CPU) processed Entrauschen (Profil) 1' on CPU, blended on CPU [preview] 285,560110 [dev_pixelpipe] took 0,073 secs (0,759 CPU) processed Entrauschen (Profil) 2’ on CPU, blended on CPU [preview]
285,636038 [dev_pixelpipe] took 0,076 secs (0,761 CPU) processed Entrauschen (Profil) 3' on CPU, blended on CPU [preview] 285,702932 [dev_pixelpipe] took 0,067 secs (0,710 CPU) processed Entrauschen (Profil) 4’ on CPU, blended on CPU [preview]
285,770468 [dev_pixelpipe] took 0,068 secs (0,715 CPU) processed Entrauschen (Profil) 5' on CPU, blended on CPU [preview] 285,771950 [dev_pixelpipe] took 0,001 secs (0,016 CPU) processed Basiskurve’ on CPU, blended on CPU [preview]
285,773960 [dev_pixelpipe] took 0,002 secs (0,023 CPU) processed Eingabefarbprofil' on CPU, blended on CPU [preview] 285,815558 [dev_pixelpipe] took 0,042 secs (0,428 CPU) processed Entrauschen (nicht-lokales Mittel)’ on CPU, blended on CPU [preview]
285,839526 [dev_pixelpipe] took 0,024 secs (0,226 CPU) processed Monochrom' on CPU, blended on CPU [preview] 285,842706 [dev_pixelpipe] took 0,003 secs (0,034 CPU) processed Werte’ on CPU, collected histogram on CPU, blended on CPU [preview]
285,846889 [dev_pixelpipe] took 0,004 secs (0,041 CPU) processed schärfen' on CPU, blended on CPU [preview] 285,852129 [dev_pixelpipe] took 0,005 secs (0,041 CPU) processed Ausgabefarbprofil’ on CPU, blended on CPU [preview]
285,853547 [dev_pixelpipe] took 0,001 secs (0,010 CPU) processed `Gamma’ on CPU, blended on CPU [preview]
285,868588 [dev_process_preview] pixel pipeline processing took 0,714 secs (6,610 CPU)

Unfortunatly I cannot do the same output easily (would need some fiddling, I guess), as dt complains, the libary is too new

What remains, is the different power of the denoising, so the result is more blotchy than before (so I would need to tune the strength at least)

5

Dear rawfinder,

here is my style. I use it with my Nikon D750 when I feel is necessary, typically, when I exceed ISO1600

Axel_D750_Denoise_EXTREME-2.dtstyle (3.4 KB)

Difficult for me how to describe a bug though as I cannot provide the evidence since cannot switch between 2.4 and 2.6 with reasonable efforts and also currently with real 2.6 rc1 (see below) the pixelpipe is in order again (here I also cannot provide the evidence, just I know, what I saw :slight_smile:

6

Thanks AxelG.
I compared what I get on 2.4.4 and git master: the order is the same
I do not know what may have caused the issue you had :-/

7

Dear Rawfinder.
Thanks for your efforts.
As I replied to Roman, Since 2.6.0rc1 I also do not have that mis-order issue anymore. On 2.5 (I’d say between Sept and Dec) I had the issue that the modules did not all have the names (denoise profile 2 etc) and misordered, when I went to pixelpipe and found that the wavelet/color was not the first one applied rather in the middle.

What I still have is in 2.6 somehow the denoise profile is stronger than before so I have to reduce the strength. However, this can be fixed easily with a new preset which I can just run again, it will keep the modules as is, just change the levels.

So at the moment I can live with that…

Thank you both for the quick stepping in and trying to help

Good night from cold DE :slight_smile:

8

Dear AxelG
The results I had with 2.4.4 and git master were identical. Maybe the force issue has been fixed.
There was an email on mailing list possibly linked to this: [darktable-dev] double denoise profiles
After this email, a change was reverted.
Have a good day :slight_smile:

9

Dear Rawfinder,

thanks for all the efforts.

I also have the feeling, that blotchy issue isn’t that obvious anymore. The link you sent is about another camera, but it fits to my experiance and also the date of change makes sense, that I feel now, things running better.

Now I am on rc7+7 and things are really nice, mainly (sometimes some strange experiences :slight_smile: )
Cheers
Axel