“Manage all masks and shapes for the current image.”
I think it only manages drawn masks and shapes.
1 Like
Fixed, though this sort of thing is better raised as an issue or pull request in the github repository since there’s always the possibility I’ll miss pixls posts.
4 Likes
I tried to push a change to github today. Although I can sign-in to github from the web browser, git push … is failing with:
colinadams@fedora dtdocs]$ git push --set-upstream origin colinadams/workflow-defaults
Username for ‘https://github.com’: colin-adams
Password for ‘https://colin-adams@github.com’:
remote: Support for password authentication was removed on August 13, 2021.
remote: Please see https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls for information on currently recommended modes of authentication.
fatal: Authentication failed for ‘https://github.com/darktable-org/dtdocs.git/’
Do I need special authentication measures of some sort?
Did you read the link you posted? You need to create an access token to push to your repo from terminal.
I did. It wouldn’t let me create an access token for dtdocs. Only for my own repository.
You create the work. You push the commit to a branch in your repo. Then you go to the dtdocs and do a PR to request the merge of your branch into master.
OK. I tried that.
When pushing, I was still prompted for a password. I tried creating a classic access token, with no scopes. I copied the token to the clipboard. I then tried shit-insert to paste it into the shell (I didn’t see anything appear - I’m guessing that’s because it’s a password field). I get:
[colinadams@fedora dtdocs]$ git push --set-upstream origin workflow/exposure
Username for ‘https://github.com’: colin-adams
Password for ‘https://colin-adams@github.com’:
remote: Permission to colin-adams/dtdocs.git denied to colin-adams.
fatal: unable to access ‘GitHub - colin-adams/dtdocs: darktable user manual’: The requested URL returned error: 403
Doing it again selecting all the scopes works. Rediculous effort.
As documentation often is 
Ridiculous or not. The bar is anyhow raised quite high by demanding that non-developer users of dt shall learn git for contributing observations of typos etc in dt documentation.
What about e.g. running a dedicated thread here in this darktable forum where non-gitters (and possibly others also?) could be invited to contribute observations and thoughts regarding the dt documentation?
If you log into github and fork the dtdocs repo, you can edit the files in the browser and github provides a GUI to make a commit. It then provides another button to make a pull request.
Its not that hard, its just new. Colin has done it once now, and he can do it again if he pleases. I have faith that the rest of you can as well.
Colin was doing the changes via terminal, so it is more involved with the tokens. For text edits, the web interface is very straightforward.
When you’re already aquainted with it, It may be hard to realize how alien e.g. terms like ‘fork’ and ‘commit’ may sound to people who have not previously been participating in this kind of activity …
So the solution to that is for me or one of the few other people who’ve taken the time to learn it and contribute to the docs (that we didn’t have enough time to finish in time for the release) is to spend more of our limited time transfering typo edits between a forum thread and the docs?
And I’m a professional developer - I use git every day (just no forking). Anyway, I’m going to document the process needed in dtdocs contributing section.
1 Like
Perhaps if it’s brief. I’m reluctant to make dtdocs into a “how to use git” manual.
I’ll forget it then. I don’t think it can be brief.
If you can find some useful resources explaining the process I’m happy to add a link. Unfortunately, there’s no getting away from the fact that some level of git/github knowledge will be required and, at least for simple typos, it might be easier (for the maintainers) to transfer things from issues manually than to help people learn git.
GitHub has some basic tutorial already. There are a ton of online resources with a google search too.
https://docs.github.com/en/get-started/quickstart/hello-world