Local Lab build


(Gabriele ) #521

Hi I tried locallab long time ago… this morning I compiled the newlocallab branch but I can’t view the locallab tool :flushed: It seems as the normal branch…
In “about version” there is named newlocallab branch…

Am I wrong somewhere ??


(Sebastien Guyader) #522

@dafrasaga the local lab tool is now in its own tab.


(Gabriele ) #523

Hi Sebastien,
you mean as in

this image
the hand icon?


(Sebastien Guyader) #524

Exactly


(Gabriele ) #525

mmhh, I haven’t it. I’ll investigate


(Sebastien Guyader) #526

Did you use git to get the code? If so, did you invoke git pull to get the updated code, in case you used a repo that you had already cloned some time ago?


(Gabriele ) #527

Hi,
I pull from git and checkout newlocallab

as you see I have newlocallab branch and no locallab tool
Hints??


(Sebastien Guyader) #528

I don’t know why, but you’re actually not on the newlocallab branch, the commit number shown on your screenshot (9e64bca) is from the dev branch.
The latest commit made in the newlocallab branch is bda6ad9 from 10 October.


#529

I should do:

git checkout newlocallab
git pull origin newlocallab

If local branch newlocallab doesn’t exist then:

git checkout -b newlocallab origin/newlocallab
git pull origin newlocallab

then as @Claes suggests

$ git branch
  32b-tiff-output-cli
  abstract-listeners
  ahd_speedup
  autowblocal
  better-source-tree
  blackwhiteauto
  ca-correction-before-distortion
  cat02wb
  catmull-rom-spline
  channel-mixer-more-precision
  dcraw928-update
  dehaze
  demosaic_source_folder
  dev
  dng_halffloat_load_speedup
  eahd_speedup
  enhanced-shadows-highlights
  fix-thumbbrowser-deadlock
  float_dng_range_0_1
  fullraw
  gimp-hdr-files
  histmatching-if-needed
  histmatching-simpler-curve
  iconcleanup3
  iconcleanup4
  issue4580
  issue4834_branch
  lensfun-mutex
  move_contrast_threshold_adjuster
  navcursor
* newlocallab
  nikon_decode
  nrpref
  powericons
  prefscroll
  rawcacorrection_iterate
  rawhistogram_fixes
  scrolled-toolbar
  scrolled-toolbar-fix
  soft-light
  testoutputprofile
  thumbtooltip
  waveletnew

#530

Hi Gabriele,

if you cd to where you have the RT source code
(the same as where you execute the command git pull)
and write

git branch

What answer do you get?
(In my case, the answer is * dev)

Cordiali saluti,
Claes da Lund in Svezia


(Gabriele ) #531

Hi All,
I do not know what I did; now it works :wink:
How do I make invisible the spot ?


(Desmis) #532

To note that I had a similar problem, like @dafrasaga, when I wanted to update after the merge made by @Morgan_Hardwood, with a difference, branch was not “newlocallab” but the one of Pandagrapher, and nothing have been updated. I thought I had made a mistake, and create a new clone where everything works properly… curious :slight_smile:

Actually you cannot hide the spot, Pandagrapher has this objective in his roadmap (see my comment 6 days above)

jacques


(AlLegro) #533

Hi,

Here is the photo: DSC_0941.NEF (22.9 MB)

However, I uninstalled all RawTherapees versions, deleted everything from \Users(…)\AppData\Local\RawTherapee* and then reinstalled build 1005 and then - over it - 1247. Then I deleted all *.pp3 files from folder with my *.nef raw files. And now it works as it should.

I suppose that this may be the result of using different versions of the program. And all of them wrote something into the pp3 files.

Regards,


(Desmis) #534

@AlLegro
Effectively, for this to work with the “GUI” version, the old “pp3” and “mip” files must be erased

jacques


(dngimage) #535

@jdc and @gaaned92,

RawTherapee_newlocallab_5.4-1314-g21292f6db_WinVista_64.zip

from:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

is running fine here.

I wish I could outline and select just the bird with a lasso selection tool or something similar instead of using a circle:


(Desmis) #536

@dngimage

It is not currently on the agenda (lasso and so on…)
Indeed this requires besides an evolution of the GUI which is not currently planned, another algorithm of treatment which is not in my current planning.

Our current efforts are in the direction of running the current algorithms - which are in line with those used by Capture NXD or DxO - with a GUI worthy of the name.

Of course we do not exclude lasso-type algorithms (as Photoshop or Gimp…) , but that will be for after :slight_smile:
jacques


(dngimage) #537

@jdc
Merci pour les GUI changements et les projets futurs.
C’est super! :slight_smile:


#538

Would it be possible to have an inverse spot, that let’s you work on everything but the selected area?
I understand that you could do that by using on spot on the whole image and then use an exclude spot, but that is two spots


(dngimage) #539

@McCap

Some Local Lab tabs have an inverse check box, or combo box: Color & Light, Sharpening, Blur & Noise.

It would be nice to have an inverse check box in the Exposure tab as well.

The spots/circles can be challenging to work with. Especially when selecting a specific area.

But we’ll have to wait. There is other work being done.


(Sebastien Guyader) #540

I think today is Jacques’ (@jdc) birthday…
Joyeux anniversaire Jacques !