Local Lab build


(Desmis) #541

@sguyader
Merci Sébastien… mais je ne rajeunis pas :slight_smile:

@McCap @dngimage
I will add “inverse” for exposure, when GUI will be finished…I only contribute to this job made by Pandagrapher !
This “addition” adds with others improvments (Local contrast, contrast threshold…)

Jacques


(dngimage) #542

@jdc

Joyeux anniversaire, Jacques!


(Desmis) #543

@dngimage
merci


#544

Grattis på födelsedagen!

/Claes en Lund, La Suède


(Ingo Weyrich) #545

Still not too late: Happy birthday dear Jacques, happpy birthday dear Jacques, happe birthday to you. Also in the name of Petra :slight_smile:


(Desmis) #546

@heckflosse

Ingo, hank you very much, thank you to Petra

@Claes
tack

:slight_smile:
jacques


(Morgan Hardwood) #547

@jdc and very warm birthday wishes from us :slight_smile:


(Flössie) #548

@jdc Though it’s no longer warm and a day too late: Bon anniversaire! :cake: :tada:


(Desmis) #549

@Morgan_Hardwood
@floessie

Thank you very much :slight_smile:


(dngimage) #550

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.4-1378-g19d71e46d_WinVista_64.zip

from:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

is running fine here.


(dngimage) #551

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.4-1405-gaef2ad47e_WinVista_64.zip

from:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

is running fine here.


(Desmis) #552

I commit a new improvment for locallab with 2 majors enhancements:
a) improve shape detection, especially for : A)burrs when color differences (hue, chroma, luma) are very low, or B) where artifacts appears for example with solid areas with hue (or luma, or chroma) variations

b) improve excludind spot

For the first “improve shape detection”, since one year, I tested 3 solutions

  1. detect structure using “Sobel Canny”, this algorithm is very good, but I don’t be abble to finelized the process… where is the good “line”?
    If it is obvious when you see the image, it is not so obvious with the code. After many, many trials, I dropped this algorithm (the code is already present)

  2. detect structure using “Contrast threshold” (as used in sharpening and in combined demosaicing)
    I implemanted (experimental) this algo - associated with others - in Color Light curves.
    In some cases, it brings someting, but a border appears in some cases, which can be embarrassing, but in most cases, this algorith is not discriminating enough

  3. improves the current algorithm that takes into account actually delta luminance, delta hue, and delta chroma, or a combinaison of this 3 parameters.
    With a new algorithm, with others combinations, I think I have arrived at a significant improvement.
    Certainly nothing is perfect, but I think the update is appreciable.

For the second point “improve excludind spot”:

  1. I found two bugs in my algorithm… of course they are solved
  2. I took advantage of point 3) above to also improve the algorithm

What are the changes ?

  1. in Color and Light
  • some curves types have been improved (for A) and B) above), with 3 experimental choices, once the trials are over, it should only be one, or replace “super”
    ** Combined hue chroma
    ** Super + contrast threshold
    ** Combined hue chroma + contrast threshold
    Note that “super” for curves takes into account A)
    Note also that sliders take into account B) if checkbox for Lightness - Contrast - chroma “super” is activated
    You cannot disabled all this settings.
  1. for others modules : Exposure, vibrance, blur and noise (including symmetric), tone-mapping retinex, contrast by detail levels, A) and B) are improved but whithout “Contrast threshold”
    Module as “sharpening” and “denoise” and “inverse” are not concerned.

I have create in options (manual) a variable “Detectshape”, it is by default “true”. If “true” all modules in 2) above are activated; if “false” RT have the same behavior as previously
When the trial period is over, I will remove this option

To simplify and avoid an extra slider, I used “scope” for each module, it has advantages (simplicity) and disadvantages (not always optimal)
It’s up to the user to find the right value, usually lower for A)…

The variable “Detectshape” is also took into account by “exludind spot”


(dngimage) #553

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.4-1419-gc4d124135_WinVista_64.zip

from:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

is running fine here.


(Desmis) #554

I just made an update that simplifies the code and in some cases significantly reduces the artifacts.
If they happen - in some extreme cases - consider using “Reduce artifacts - improve algoritm” acting on the 2 sliders “Threshold chroma” and “Iterations”

jacques


(dngimage) #555

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.4-1427-gfa3e0a74f_WinVista_64.zip

from:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

is running fine here.


(dngimage) #556

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.4-1429-g9cc65909e_WinVista_64.zip

from:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

is running fine here.


#557

RawTherapee_newlocallab_5.4-1429-g9cc65909e_WinVista_64.zip has strange artifacts when you use the ‘weighted standard’ tone curve in combination and the ‘clip out of gamut colours’ box is checked.
The moon has turned black! Hopefully I have attached the raw files and pp3. Probably nothing to do with locallab, but I found it in this version.
Foss Way Moon 6.RW2 (14.6 MB)
Foss Way Moon 6.RW2.pp3 (13.3 KB)


(Ingo Weyrich) #558

The bug was also in dev build. I fixed it there. Will soon be fixed in locallab as well, I guess.


#559

OK thanks! Good for simulating lunar eclipses anyway.


(dngimage) #560

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.4-1462-g333ac9953_WinVista_64.zip

from:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

is running fine here.

@heckflosse,
Thanks for fixing the bug.