Local Lab build


(Desmis) #601

I just commit a change
I have found why, the mask does not work…a simple forgetfulness on my part !

Now mask works (I hope)
If blend is at 0, the system works, it take into account the mask to improve shape detection, without other change on the image

if blend < 0 (substract) or blend > 0 (add), you mixed the “mask” (the difference) with the original, but before workind on it with locallab.

Of course transition works.

I hope no error, and no problem with memory (of course this functionnality use a lot of memory!!)

jacques


(dngimage) #602

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.5-550-g1173ea191_WinVista_64_190125.zip

From:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

Is running fine here.


#603

Works very well indeed. Easy to use and with a bit of tweaking can modify complex shapes easily. I find the ‘Show modifications without mask’ very useful, in combination with the ‘scope’ setting, so you can see what areas it will act on.


(Desmis) #604

@spidermonkey
Thank you for testing

jacques


(Heinrich Holtmannspoetter) #605

@jdc
locallab woks fine, many thanks to all for developing this very nice tool!

By using the local-tab the hand symbolt changes to local symbol (crosshair with arrows) and everything works fine. After hitting ‘h’ or clicking on that symbol it changes to hand symbol and the local indicators are gone. I found no way to get them back other than changing the tab and reactivating the local tab. Is there an other way to get controls back, or schould there be an other way?

If the actual version proves to be stable perhaps a ‘preliminary endpoint’ in the development could be defined to get it merged into dev? I would greatly appreciate to see it merged in dev.

Regards
Heinrich


(dngimage) #606

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.5-578-g63f6c26f7_WinVista_64_190126.zip

From:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

Is running fine here.


(Alberto) #607

Ver 578 works very well, i have to test it more but it’s far better than a month ago. :smiley:


(Hansgeorg) #608

Looks really good! I started using the locallab branch just 10 days ago - it allows far better corrections when for example a red poppy or a red car insist on being orange


(dngimage) #609

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.5-580-g8ce0ba320_WinVista_64_190127.zip

From:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

Is running fine here.


(dngimage) #610

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.5-582-g1e274d90c_WinVista_64_190127.zip

From:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

Is running fine here.


(Desmis) #611

I push a commit with numerous changes

  1. for Color and Light, same approach than for Exposure, but big (very big work)…I hope no error
  2. all other modules “with color” has been improved by taking account of deltaE
  3. where possible, I changed the code to minimize the number of procedures
  4. I delete all old code - about 3500 lines of code

jacques


(Desmis) #612

I finished “conversion” all process with taking account of deltaE

Now all modules are concerned

The 3 fonctions are

  • denoise
  • sharp
  • local contrast

jacques


(Heinrich Holtmannspoetter) #613

RawTherapee_newlocallab_5.5-588-ged65bdc5d_WinVista_64_190129.zip works fine on Win10. Great job!


(dngimage) #614

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.5-588-ged65bdc5d_WinVista_64_190129.zip

From:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

Is running fine here.


(Desmis) #615

@hholt @dngimage @gaaned92

Thank you for testing.

I just update Rawpedia documentation in french
https://rawpedia.rawtherapee.com/Local_Lab_controls/fr


(dngimage) #616

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.5-592-g999845c1b_WinVista_64_190130.zip

From:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

Is running fine here.

Merci! :slight_smile:


(Desmis) #617

I have forgotten 2 modules who have not been converted

  • inverse colorlight
  • inverse sharp

With this new commit

  1. this 2 “inverse” are using now deltaE
  2. I fixed the bug for “avoid color shift” (general)
  3. I clean code

jacques


(dngimage) #618

@gaaned92 and @jdc,

RawTherapee_newlocallab_5.5-593-g4321d6a38_WinVista_64_190130.zip

From:

https://keybase.pub/gaaned92/RTW64NightlyBuilds/

Is running fine here.


#619

All works very well. This is a very useful too which greatly adds to RawTherapee’s capabilities. For the majority of cases I find it much quicker than drawing masks in other programs. Are there plans to merge it with the main version?


(Desmis) #620

@spidermonkey

Thank you very much.
Effectivly in most cases, RT_spot is much quicker than drawing mask…
In some cases, foliages… this technique is clearly more efficient.

I put a lot of time to find the 2 key algorithms

  • general case with deltaE
  • structure detection with “Sobel Canny + guide filter” : we can certainly improve this the second part

Thank you
Jacques