Nope. Just -s and_s at most. Windows hates special characters!
Yeah, Area WB is definitely wonky. When I open a raw file and go straight to the selection, the pencil is already enabled and it works as expected. Any other time, including revisiting the file via a PFI, the box is either invisible or not interactable, or one corner node is visible at the top-left corner of the preview image.
I have found a bug in the way the corners of the Area WB rectangles were saved in the .pfi files, which explains why upon re-opening a file the rectangles were not visible or behaving in a strange way.
I still have to do more extensive tests of the rest, but maybe you can already provide me feedback wether this specific problem is fixed or not for you?
Meanwhile, I have added two more tools to the PhF arsenal:
- a random noise generator, that can create a perceptually flat random distribution of pixels even when working on linear RGB data. It is found in the “Color” group
- an implementation of the “guided filter” derived from RawTherapee. which allows to efficiently do edge-preserving preudo-gaussian blurs. It is found in the “Details” section.
2 Likes
It isn’t fixed yet. There are many cases where it doesn’t work as expected. E.g., if I use samplers, it doesn’t work.
Could you describe the problem better? I have tried to reproduce issues with AreaWB + samplers, but in my case everything seemed to behave as expected…
Thanks!
I have just committed an improved version of the local contrast tool.
This new version uses the guided filter as the blur operator to extract and enhance the high-frequency details.
The new version has three controls:
- amount: adjusts the strength of the local contrast enhancement/suppression. A value of “0” gives the blurred image, “100” gives the original image, values <100 give an image softer than the original, and finally values >100 enhance the local contrast
- radius: the radius of the underlying guided blur
- threshold: the threshold of the guided blur to distinguish between strong edges and fine texture. The lower the value, the finer are the textures that are preserved
The suggested workflow is the following:
- set amount to “0”, and adjust the radius and threshold until you see smooth textures but at the same time the strong edges (for which you do not want visible halos) are not blurred
- set the amount to “150”
- adjust to your taste around this value
Used with moderation, I find that this tool can give a significant “pop” to some pictures without creating “fake” results. I have for example used it to enhance the fur of the jumping spider in my most recent picture.
Suggestions are welcome as usual!
1 Like
It is difficult to describe because the behaviour is inconsistent. If I turn on a sampler before I attempt Area WB, the Area rectangle control doesn’t appear. Except, now it does in the latest commit…
This last trial, the rectangle sometimes disappears and isn’t just invisible. I cannot access the rectangle or select the ROI for Area WB. Try doing the following:
1. Add another layer such as “tone mapping”.
2. Have the “raw developer” and “tone mapping” modules float.
3. Try different combinations of toggling the “tone mapping” layer, selecting either layer and toggling their respective edit pencils.
I know that there might be a state where the rectangle should be gone but right now the behaviour for #1-3 is unpredictable. Feels like the rectangle control randomly goes away and becomes inaccessible, leaving me scratching my head and giving up. Seems to me it is somehow getting better. At least, I was able to use Area WB for one of the recent PlayRaws.
I tried to use the Area white balance today. I never did set any Sample Points. The Area rectangle just didn’t want to appear. So I gave up and closed PhotoFlow. I haven’t updated recently, if that matters.
I often want to pixel peep more than 100%, something that I noticed that PF didn’t have right off the bat, but didn’t request it because it was a minor quibble. I don’t need interpolation, just bigger pixels. 
PS Zooming is particularly useful when I am using the defringe tool. I have trouble seeing and adjusting it without a huge zoom, often having to turn to RT (which is not a bad thing 
) or exporting the image for examination in G’MIC.
PPS 
Looks like something is wrong with the defringe tool. I exported 2 images, one without and the other with defringe. When I take the difference between the two, I get this. PFI: 20180603_140157.pfi (17.7 KB). Raw from [Play Raw] Peaceful mountain view.
PhotoFlow: left without defringe; right with it differenced and equalized (boosted).
RawTherapee: left without defringe; right with it differenced and equalized (no boost).
Looks like the defringing is only occurring in the brightest regions and not even the edges.
PhotoFlow: left without defringe; right with it differenced and equalized (boosted).
@afre @Elle I have just committed some improvements. Hopefully now the area WB will be more usable, as the rectangle with the target area should be visible whenever the RAW developer layer is selected.
I’d be very much interested to know if you find the new behaviour more intuitive than the previous…
I have also added the possibility to zoom in the image beyond 1:1, actually up to 800%. Pixel peepers will be happy!!!
I still need to look into the defringe tool problems, it’s the next item on the list.
Area WB seems to work now.
The edit mode still needs some work. When I am using Area WB and try to toggle the edit pencil, it turns off briefly and then goes back on. The off and on makes PF go into processing twice, when nothing should be happening. The processing also happens when toggling the edit pencil in modules that don’t need the edit mode. (Ideally, the expected behaviour would be for the rectangle to be active only when the WB tab of the module is active.)
Lastly, it would be great to have a percent zoom status.
PS In the meantime, I have been using RT’s (dev) Raw > Chromatic Aberration and Detail > Defringe tools, which are both quite agreeable, if you wish to see what is going on there.
Hi,
It’s been a while since I’ve used PF, so I’m probably not doing it right, but when I crop this image, it leaves a layer beneath the crop. Look at bottom and right sides.
What am I doing wrong?
IMG_4245.pfi (31.2 KB)
IMG_4245.DNG (17.8 MB)
These files are licensed under a Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International License .
I made this observation a while ago. Basically, PF doesn’t have any conception of layer positioning. When you crop the upper layer, what happens is the dimensions shrink. The layer is drawn from the top-left, so it would start there and would essentially shift toward that point.
Now, if you move the crop outside and on top of the Group Layer, this crop should be affecting everything underneath and thus give you the desired effect.
2 Likes
That’s it, thanks!
Another thing that @afre may know about: the noise reduction layer has no effect, even when I drag the luma slider to 100.
I tried moving the NR layer outside the group, but nothing changes.
@afre was faster than me to reply… indeed, moving the crop layer outside of a group is the right solution. However, let me give you some background about what’s going on behind the curtain…
The crop tool is implemented in a way that completely disables the blending step. In other words, the crop output always replaces the contents of the underlying layers. Otherwise, the software would try to blend two images with a different size, with the result you have observed.
When the crop layer is inside a group, the blend mode of the group overrides the one of the crop layer, and performs a normal blend of two images with a different size…
If the crop layer in inside the group, and you set the group blend mode to “passthrough”, you should get the same result as if the crop layer was outside of the group.
That is not entirely true. The layers have an option to adjust their position relative to the input image. The translation is however not (yet) interactive, and must be set “by numbers” in two fields that can be accessed by expanding the “more” button below the opacity slider:
This is hidden by default to avoid filling the UI, as it is not used very frequently…
Thanks for the explanation, it’s always good to have the big picture.
As for the lack of effect on noise reduction…
I will have a look at it as soon as possible. I must admit I am not using noise reduction very often…
1 Like
Oh, I didn’t notice that. A long while ago, I asked about this among other things and you didn’t answer on this particular item.
PS Last time I checked, there weren’t any releases for the OCIO branch. Was wondering when that would come. I would like to give it a try. Thanks.
I gave linear + log a brief go. Some things I noticed:
– When slope is high and linear range is low, there is a kink in the toe of the curve.
– When compression is low, the kink becomes crazier and not limited to the toe, or the curve bends backward.
– Overall, the default setting gives the best appearance out of all of the methods and their respective defaults.
Hello!
Is it possible to manually select camera and lens in Raw Developer layer?
Clicking on Unknown Camera and Unknown Lens doesn’t open a dialog to pick a pair camera/lens like RT and DT.
Checking or unchecking the boxes below doesn’t help.
The thing is, even if my camera doesn’t show in the lensfun list, I usually get good results by choosing a similar model (in my case, Canon Powershot A640)
