Some PhF Layout suggestions

@Carmelo_DrRaw

This last UI looks nice!
IMHO, It looks better than the official UI.

To confirm my feeling it should be tested on various platforms (e.g. Windows 10) since, from your screenshots, it looks like it is currently tested mostly on the Mac OS, right now :slight_smile:

I downloaded the latest. Several issues.
1 The side panel takes up about a 1/3 of the screen.
2 Tool tips font colour is barely legible.
3 Large gap underneath mask, pin and info.
4 Missing filename!
5 Floating samplers doesn’t have a close button.
6 Closing samplers window places samplers after Info tab.

See window bar, title and icon for size comparison.

Edit: vs floating window width and layout.

image

  1. the width of the left panel should be adjustable. Is that the minimum size you can get? Did you try to reduce the width? The value of the width is stored in the configuration and loaded the next time the program is started.
  2. I will check where this is defined in the GTK2 configuration
  3. that’s where the opacity and layer blend mode controls go for layers that support it. The RAW developer does not support blend modes, that’s why the space is empty. I have so far not found a better way to handle this
  4. I know, my idea is to put the file name in the window title when only one file is opened and there are no tabs
  5. I will add a close button
  6. I might just put them after the info tab by default…

Hi, author! Thanks for new GUI, sliders looks and works very good.
Now - what is needed for photographs.

  1. Gradient have not intuitive interface. For photo purposes we need masks with controlled length, width, direction.
  2. Very needed selective colors! We need (in Linux) to work with human defined colors (not RGB but all rainbow colors) and need for example to minimize yellow in all maroon spots.

1 Unfortunately, it is minimum width already, at least on my machine! I can decrease the width now. The rightmost icons are trimmed slightly.

image

PS
What are the default black levels? I see 128,128,129,129…

image

@afre meanwhile I have modified the code so that the left panel can be squeezed smaller than its natural size, if needed.

The default black levels are those reported by the RAW decoding library. They should not be modified unless one knows exactly what he is doing, and has good reasons to suspect that the default values are wrong…

Thanks for checking!

Before, I could resize it only half the time. Now, it is much better. Unfortunately, everything scrunches up. I suggest that we have a scroll bar for the entire panel. Right now, it is only for the layer list. Lastly, the samplers tab is in its own little world. :roll_eyes:

1 Like

How to correct geometry here?

– Looks like samplers still doesn’t have a close button.
– Button order (and labels?) inconsistent. E.g.,

Save image as… → Cancel Save

Export image → OK Cancel

Open image → Cancel Open

Settings → OK Cancel

Exit dialogue → Yes No

1 Like

You are right. I have opted for having the “Cancel” button always first, as this is the default layout for the GTK file dialogs. I have also added a “Close” button for the samplers dialog.

Do you think it would be more logical to have a Cancel/Save button pair also for the export and settings dialogs?

Cancel Confirm would be my goto set.

You could also elaborate on Confirm by replacing it with Export, etc. I recommend:
Export: Cancel Export
Settings: Cancel Confirm (or Cancel Save)
Exit: Cancel Confirm (or Cancel Yes)

1 Like

I think that slider have too wide range of adjustment. In a most cases ist’s enough to move slider ± 1 - 5 units, but all sliders have range 0 - 50 (for example).

And about “mask” layers – mask must be on transparent layer, I have to see what I cover by this mask.

Do you have an example? Range depends on the image and what the user wants. Re-framing your question, maybe what you want is finer or coarser increments. Does that sound about right?

By that, do you mean an overlay? If so, I agree that that would help. Personally, I don’t use masks in pf because they aren’t intuitive and crash if I do it wrong or step on a bug.

@Chawoosh are you aware of the “show mask” button?
Here is an example:

@afre are the crashes linked to some specific tool, or random? I use masks all the time, and I do not observe crashes from my side…

I can’t see this button. Here is sample: loaded raw file, selected mask layer with “gradient”.

In order to associate an opacity mask to a tool you have to proceed in the following way:

  • add an adjustment layer, for example a “curves” adjustment
  • double-click on the white rectangle to the right of the layer name - this will get you into the layer mask editing mode
  • add some initial layer to your mask, for example a gradient, and toggle the “show mask” checkbox to see the mask painted on top of the image
  • add some additional layer to further refine the mask, for example a “threshold” or a “path mask” tool
  • change the blend mode of the topmost mask layer to whatever you need to achieve the desired combination of masks - you can multiply the masks, intersect them or combine them
  • click on the “back” button to exit the layer mask editing mode

Hope this is clear…

OK, thanks. It’s a great technique :smile:.
Another question: GIMP says to me that exported floating point tif has 3 layers, why? And what it means? Layer 0 is imported OK, but 1 and 2:

image

afre, about sliders range. For example - in a basic adjustments slider “saturation” has range ± 99, and normal using – not more than 5, I think

This is an old issue, that I have not managed yet to fix… it is related to how the EXIF data is embedded into TIFF files by PhF.

Why RawTherapee writes normal floating point tiff?