Some PhF Layout suggestions

Ah, ok, got it wrong. My bad.

PhF from git has (in Arch linux) option for compiler “threat warning as errors” from some optimistic developer. So we are without last version.

@Chawoosh are you referring to the AUR package? I just checked and couldn’t see any custom compile option in the PKGBUILD…

May be in the “cofigure” file. I don’t have time to search, pardon me.
Effect is somewhere in a middle:

Blockquote Scanning dependencies of target rawspeed
[ 4%] Building CXX object src/external/rawspeed/CMakeFiles/rawspeed.dir/src/librawspeed/common/ChecksumFile.cpp.o
[ 5%] Building CXX object src/external/rawspeed/CMakeFiles/rawspeed.dir/src/librawspeed/common/Common.cpp.o
[ 5%] Building CXX object src/external/rawspeed/CMakeFiles/rawspeed.dir/src/librawspeed/common/Cpuid.cpp.o
[ 5%] Building CXX object src/external/rawspeed/CMakeFiles/rawspeed.dir/src/librawspeed/common/DngOpcodes.cpp.o
In file included from /home/chawoosh/.cache/aurman/photoflow/src/photoflow/src/external/rawspeed/src/librawspeed/common/DngOpcodes.cpp:25:
/home/chawoosh/.cache/aurman/photoflow/src/photoflow/src/external/rawspeed/src/librawspeed/common/Mutex.h:80:38: error: ‘const’ attribute on function returning ‘void’ [-Werror=attributes]
void attribute((const)) Lock() const ACQUIRE() {
^~~~~
/home/chawoosh/.cache/aurman/photoflow/src/photoflow/src/external/rawspeed/src/librawspeed/common/Mutex.h:85:40: error: ‘const’ attribute on function returning ‘void’ [-Werror=attributes]
void attribute((const)) Unlock() const RELEASE() {
^~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [src/external/rawspeed/CMakeFiles/rawspeed.dir/build.make:102: src/external/rawspeed/CMakeFiles/rawspeed.dir/src/librawspeed/common/DngOpcodes.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:572: src/external/rawspeed/CMakeFiles/rawspeed.dir/all] Error 2

Blockquote

I think it has to do with thumbnails from the raw; if you just copy ALL the metadata over it includes the thumbnails as layers.

Filmulator was at one point writing 4-layer TIFFs, but then I just decided to not write metadata because I didn’t want to spend the time to properly deal with metadata.

(As a result of the copy-everything implementation, it also just writes the camera jpeg thumbnail to the output jpegs, which means that the thumbs aren’t reflective of what Filmulator outputs)

1 Like

The fact is that I am already removing the thumbnails from the EXIF data which I load from the raw files, or at least this is what I expect this piece of code to do. But something is clearly still not done properly. I know that DT has quite some code to cleanup the EXIF data prior to saving the TIFF files. I have to look into that…

1 Like

PhF still can’t be assembled - somewhere in target rawspeed cc find flag to threat warning as errors. Previous target (lensfun) compiled with warnings and linked. In my system conf files there isn’t any CFlags.
O! Just now I see this:

In file included from /home/chawoosh/.cache/aurman/photoflow/src/photoflow/src/external/rawspeed/src/librawspeed/common/DngOpcodes.cpp:25:
/home/chawoosh/.cache/aurman/photoflow/src/photoflow/src/external/rawspeed/src/librawspeed/common/Mutex.h:80:38: error: ‘const’ attribute on function returning ‘void’ [-Werror=attributes]
void attribute((const)) Lock() const ACQUIRE() {
^~~~~
/home/chawoosh/.cache/aurman/photoflow/src/photoflow/src/external/rawspeed/src/librawspeed/common/Mutex.h:85:40: error: ‘const’ attribute on function returning ‘void’ [-Werror=attributes]
void attribute((const)) Unlock() const RELEASE() {
^~~~~
cc1plus: all warnings being treated as errors

I find option -Werror in many make files and in “compile_commands.json” - great number, in any directive.

I have hopefully fixed all warnings, the code should compile with -Werror now…

Thanx, all’s compiled and works.

One think about usability: in geometry and rotate are needed horizontal and vertical (removable and movable) levels.

This is actually already possible: when you add a scale/rotate layer, you can click twice on the preview to create a guide line. The image will then be rotated in such a way that the line will end up being horizontal or vertical, depending which one is closer to the initial angle.

I am experimenting with the layout of the tools dialogs, trying to save some vertical space.
I have introduced a tab widget, and moved the blend mode, opacity slider and input source selector into a separate tab. Here is how it would look like:

37

01

What do you think?

Saving vertical space
– Could you remove the title bar?
– Could you place a Close at the right hand side of the icon or tab row?

1 Like

You have to write wiki, program have many hidden features. I think so.

1 Like

It’s good idea.

You are absolutely right, and I have recently started to write something… but it takes quite a lot of time :frowning:

I have no idea how to remove the title bar from a GTK dialog, but it can be used to show the tool type (see below)

Like this?

12

It needs to be vertically thinner to match the rest of the row.

Blockquote
This is actually already possible:
Blockquote

Guided line added by double click - it is not about my request :slight_smile: I told about stable orienteer for horizontal or vertical direction.

Would these help?
https://developer.gimp.org/api/2.0/gtk/GtkWindow.html#gtk-window-set-decorated
https://developer.gimp.org/api/2.0/gtk/GtkWindow.html#gtk-window-set-deletable