This seems very strange and unintuitive to me. What if I want to redo the crop or something? It seems weird to me that a simple double-click will not work, but I must bring focus to another module.
I thought I would try to add a keyboard shortcut for the crop commit. But it does not seem to work. It is there - I have created a shortcut of lower case ‘c’ to commit in darktable preferences>>shortcuts>>processing modules>>crop
I also tried ‘shift c’ just in case there was some issue with just ‘c’.
Is there a way to do this so it is not so awkward as having to bring focus to another module for the crop commit?
More accurately, taking focus away from the crop module commits it. Selecting another module is one way to do this. You can also collapse the crop module (which takes focus away without giving it to another module) or you can Ctrl+click on the module’s on/off button (which also removes focus but without collapsing).
I have set up a keyboard shortcut (C) to toggle focus on the crop module, which means I rarely even have to expand it. Just press the shortcut once to bring up the on-screen crop guides and again to remove them and commit the crop. I do the same thing on the rotate/perspective module (R) if I need to fix the horizon. I then have a matching pair of shortcuts to show the modules (Shift+C for crop and Shift+R for rotate/perspective).
The problem with double-click is that it left the module in a sort of in-between state where it had lost focus but wasn’t collapsed. In that case the only way to bring the guides back again was to collapse the module and expand it again (or Ctrl+click on the on/off button).