Windows 64 build with integration of lensfun

noteasy2beme · September 21, 2017, 1:40am

You might want to delete the cache.

gaaned92 · September 21, 2017, 5:40am

In options file verify that

[Lensfun]
DBDirectory=

In order lensfun use the DB default location

agriggio · September 21, 2017, 6:53am

Just delete the options file (in %APPDATA%\RawTherapee or something like that)

Jacal · September 21, 2017, 9:11am

Thank you @noteasy2beme, @gaaned92, @agriggio, I usually delete the options file and cache for new versions, didn’t this time. It works now as expected.

nonophuran · July 16, 2020, 2:54pm

Reviving this thread, now, July 2020, as I’ve recently made my first build on a win10 x64 laptop.

I’ve followed rawpedia instructions until the “Run CMake and Make” section.
But I can’t seem to find anything related to lensfun database; when I run RT-5.8 (dev branch), I can’t select any lens - and the share directory is empty.

~/RT/RawTherapee/build/release
$ ll
total 22624
drwxr-xr-x 1 catya None        0 16 juil. 16:34 .
drwxr-xr-x 1 catya None        0 10 mai   00:22 ..
-rw-r--r-- 1 catya None      733 10 mai   00:01 AboutThisBuild.txt
-rw-r--r-- 1 catya None     1236  9 mai   23:56 AUTHORS.txt
-rw-r--r-- 1 catya None   159083  9 mai   23:56 camconst.json
drwxr-xr-x 1 catya None        0 10 mai   00:22 dcpprofiles
drwxr-xr-x 1 catya None        0 10 mai   00:22 fonts
drwxr-xr-x 1 catya None        0 10 mai   00:22 iccprofiles
drwxr-xr-x 1 catya None        0 10 mai   00:22 images
drwxr-xr-x 1 catya None        0 10 mai   00:22 languages
-rw-r--r-- 1 catya None    33326  9 mai   23:56 LICENSE.txt
drwxr-xr-x 1 catya None        0 10 mai   00:22 licenses
-rw-r--r-- 1 catya None     2086  9 mai   23:56 options
drwxr-xr-x 1 catya None        0 10 mai   00:22 profiles
-rwxr-xr-x 1 catya None 15083188 10 mai   00:22 rawtherapee.exe
-rwxr-xr-x 1 catya None  7597536 10 mai   00:22 rawtherapee-cli.exe
-rw-r--r-- 1 catya None     4666  9 mai   23:56 RELEASE_NOTES.txt
drwxr-xr-x 1 catya None        0 10 mai   00:22 share
drwxr-xr-x 1 catya None        0 10 mai   00:22 sounds
drwxr-xr-x 1 catya None        0 10 mai   00:22 themes
-rw-r--r-- 1 catya None    11332 10 mai   00:01 WindowsInnoSetup.iss

is this the right thread to ask about that?
what have I done wrong?

Thanks for your help.

HIRAM · July 16, 2020, 5:11pm

@nonophuran Can you post your cmake command?

Thanatomanic · July 16, 2020, 5:58pm

If you run lensfun-update-data from your console you see where the lensfun directory is located. For me this is at C:/msys64/mingw64/var/lib/lensfun-updates/version_1
You need to make sure that the DBDirectory setting in your C:\Users\###\AppData\Local\RawTherapee5-dev\options file points to this folder.

nonophuran · July 16, 2020, 9:20pm

@HIRAM, here it is.

cmake -G "MSYS Makefiles" -DLENSFUNDBDIR=share/lensfun -DCMAKE_BUILD_TYPE="release" -DPROC_TARGET_NUMBER="2" -DCACHE_NAME_SUFFIX="5-dev" ..

It was executed from within the newly created build subdirectory, as stated in the current revision of rawpedia.

@Thanatomanic,
the DBDirectory attribute does not even exist in my options file.

Have I missed part of the process?
note that I basically stopped right after RT was built and made executable through MSys (again, just as in RawPedia)
Also note that I’ve cloned this “locally”, under the /home directory created by MSys

Thanks !

gaaned92 · July 16, 2020, 10:15pm

@Thanatomanic
I think @nonophuran question is due to lack of clarity of the redaction of the steps following make install .

There are two ways to run the built application:

run the exe from a MNGW64 shell (like in LINUX). In this case, all dependencies can be fetched in MSYS2/MINGW64.
To get access to the lensfun DB, the CMAKE tag DLENSFUNDBDIR should point to C:/msys64/mingw64/var/lib/lensfun-updates/version_1 or otherwise, you have to modify the DBDirectory parameter accordingly.
Copy ALL dependencies as described in rawpedia/windows including the Lensfun DB in the correct locations. In this case you can run as a native windows app (double-click, from a BAT…)

Can you clarify and verify that in Rawpedia? Perhaps reordering some paragraphs also.

@nonophuran

Add this at the end of the options file:
[Lensfun]
DBDirectory= C:/msys64/mingw64/var/lib/lensfun-updates/version_1

nonophuran · July 17, 2020, 9:05am

Hi

I’ve added the link to the database. On my computer, it only contains xml files + 1 txt file.

grep -i lensfun options
[Lensfun]
DBDirectory=C:/msys64/mingw64/var/lib/lensfun-updates/version_1

Then I’ve run ./rawtherapee.exe as usual through msys2/mingw64 shell.

And I don’t think I’m successful, yet. Automatically selected is checked but corresponding fields remain blank:

==> is this way supposed to be functionally equivalent to the mingw64 route, or does it offer more integration with the host system?

Thanatomanic · July 17, 2020, 11:44am

What happens if you select “Manually selected”? Is the list populated?

Are you positive the options file you edited belongs to the instance of RawTherapee you’re running through the shell? This is easy to verify because the “Date modified” of the options file should be set to when you have last run RT.

nonophuran · July 17, 2020, 1:04pm

This is what happens.

The list is not populated.

then no, I’m not positive:

catya@C5 MINGW64 ~/RT/RawTherapee/build/release
$ date +%FT%T && stat options
2020-07-17T15:03:22
  File: options
  Size: 2161            Blocks: 4          IO Block: 65536  regular file
Device: aaa16119h/2862702873d   Inode: 18577348462926744  Links: 1
Access: (0644/-rw-r--r--)  Uid: (197609/   catya)   Gid: (197121/    None)
Access: 2020-07-17 10:41:20.692713900 +0200
Modify: 2020-07-17 10:41:20.692713900 +0200
Change: 2020-07-17 10:41:20.700713400 +0200
 Birth: 2020-05-09 23:56:37.199940100 +0200

catya@C5 MINGW64 ~/RT/RawTherapee/build/release
$ date +%FT%T && ./rawtherapee.exe
2020-07-17T15:03:38

(rawtherapee.exe:13656): Gtk-WARNING **: 15:03:40.951: Could not load a pixbuf from /org/gtk/libgtk/theme/Adwaita/assets/check-symbolic.svg.
This may indicate that pixbuf loaders or the mime database could not be found.

catya@C5 MINGW64 ~/RT/RawTherapee/build/release
$ date +%FT%T && stat options
2020-07-17T15:03:50
  File: options
  Size: 2161            Blocks: 4          IO Block: 65536  regular file
Device: aaa16119h/2862702873d   Inode: 18577348462926744  Links: 1
Access: (0644/-rw-r--r--)  Uid: (197609/   catya)   Gid: (197121/    None)
Access: 2020-07-17 10:41:20.692713900 +0200
Modify: 2020-07-17 10:41:20.692713900 +0200
Change: 2020-07-17 10:41:20.700713400 +0200
 Birth: 2020-05-09 23:56:37.199940100 +0200

Thanatomanic · July 17, 2020, 1:29pm

@nonophuran Please see this comment.

Edit: the file you’re editing in the RawTherapee build folder is only the default file. Not the actual currently in-use options file.

nonophuran · July 17, 2020, 1:35pm

OK, thanks for pointing this comment out. I had overlooked it as I thought this would pertain to an RT build that’s launched directly in win10 instead of MSYS (due to the db file path being outside of msys scope [if that’s even the case])
Now it works perfectly.

Thanks!

Thanatomanic · July 17, 2020, 2:52pm

Good to see that it works now!

And just to clarify regarding the scope of the dev build. To make sure things don’t interfere with your local (release) install, you add this to your cmake instructions:

But things will always be stored in AppData. The MSYS environment is only for building applications, but your software runs natively in Windows and therefore has access to all files.

gaaned92 · July 20, 2020, 7:04pm

Its equivalent. If you have Mingw64/bin in your windows PATH, you can run double clicking, with a DOS shell or whatever Windows permits.
But beware that if you update MSYS2 (pacman -Syuu), some dependencies can become incompatible.
If you dont bundle dependencies, you will also not be able to run the app from a PC where MSYS2 is not installed.