Anomaly (possibly issue) in color balance rgb

apostel338 · October 12, 2023, 4:54pm

[DT Master 4.1.0] color balance rgb perceptual briliance grading highlight slider creates artifacts

opened 07:11PM - 08 Sep 22 UTC

closed 12:34AM - 15 Jan 24 UTC

priority: high feature: redesign difficulty: hard bug: pending no-issue-activity release notes: pending

**Describe the bug/issue** If the highlights of the photo are close to the li…mit of dynamic range, the highlight slider of the perceptual briliance grading in the color balance rgb module produces artifacts when a certain threshold is exceeded. This only happens in the default _darktable USC (2022)_ color space. In JzAzBz (2021) color space the slider behaves as expected. **To Reproduce** 1. increase the exposure of the photo with exposure module until the highlights are at the limit of the dynamic range. 2. in the color balance rgb module, increase the value of perceptual brilliance in highlights using the highlights slider. 3. After a certain value, the artifacts - wide white spots - appear (see screenshot/video below). **Screenshots** ![Artifact](https://user-images.githubusercontent.com/38165484/189203438-3bfec8e8-b120-48c1-b5e0-4d2a1d719115.jpg) **Screencast** Short demo: https://user-images.githubusercontent.com/38165484/189202459-4b598eb2-263c-421e-ba1c-e04402929b3e.mp4 **Platform** _Please fill as much information as possible in the list given below. Please state "unknown" where you do not know the answer and remove any sections that are not applicable _ * darktable version : 4.1.0~git272.5a1a1845-1 * OS : Linux * Linux - Distro : Ubuntu Studio 22.04 * Memory : 31,3 GiB * Graphics card : NVIDIA GeForce GTX 1070/PCIe/SSE2 * Graphics driver : 470.141.03 * OpenCL installed : yes * OpenCL activated : yes * Desktop : KDE-Plasma-Version: 5.24.6 **Additional context** I can't say for sure, but I suspect that this problem may be related to the https://github.com/darktable-org/darktable/pull/12233 since this behavior appeared after that commit.

And regarding the blackness of your highlights, if you don’t use openCL and 4.4.2 stable, it could be this one:

github.com/darktable-org/darktable

Without OpenCL, filmic's hl-reconstruction produces artifacts.

opened 10:25PM - 06 Sep 23 UTC

closed 04:26PM - 10 Sep 23 UTC

apostel338

priority: high reproduce: confirmed bug: pending

### Describe the bug Without OpenCL, filmic's hl-reconstruction seems to produc…e artifacts. ### Steps to reproduce Find a RAW with (some seriously) blown out highlights. Enable HL reconstruct in filmic, play with some values. Moste visible when lower the treshold a bit, raise iterations of hq-rec., and lower the bloom<->reconstruct slider. ### Expected behavior _No response_ ### Logfile | Screenshot | Screencast OpenCL on: ![Screenshot_20230906_235027](https://github.com/darktable-org/darktable/assets/96216629/d11237b8-f137-4de9-a384-73660f3a8c7d) OpenCL off: ![Screenshot_20230906_235116](https://github.com/darktable-org/darktable/assets/96216629/4dd956e0-b8f3-430e-8829-bb474294925f) ### Commit _No response_ ### Where did you install darktable from? OBS ### darktable version 4.5.0~git328.1aca07c6-10447.5 ### What OS are you using? Linux ### What is the version of your OS? Tumbleweed ### Describe your system? Operating System: openSUSE Tumbleweed 20230902 KDE Plasma Version: 5.27.7 KDE Frameworks Version: 5.109.0 Qt Version: 5.15.10 Kernel Version: 6.4.12-1-default (64-bit) Graphics Platform: X11 Processors: 12 × 12th Gen Intel® Core™ i5-12500T Memory: 15.3 GiB of RAM Graphics Processor: Mesa Intel® UHD Graphics 770 ### Are you using OpenCL GPU in darktable? No ### If yes, what is the GPU card and driver? _No response_ ### Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip RAW + XMP: [000.tar.gz](https://github.com/darktable-org/darktable/files/12542895/000.tar.gz)

github.com/darktable-org/darktable

Filmic RGB reconstruction with slider on bloom causes gray highlights when not using OpenCL

opened 05:43PM - 25 Sep 23 UTC

closed 09:26PM - 25 Sep 23 UTC

Tai-Mai

### Describe the bug While writing this issue, I actually fixed it myself by …installing OpenCL. Before I did that, this is what happenend to me when I tried to reconstruct highlights with filmic RGB and moved the bloom $\leftrightarrow$ reconstruct slider to the left. In the first picture, the highlight reconstruction module is enabled by default. ![image](https://github.com/darktable-org/darktable/assets/57625350/9043afc0-8bea-49a8-8108-5bd134d1fcc1) I'm using the default options: ![image](https://github.com/darktable-org/darktable/assets/57625350/22930cf3-ed67-4419-b475-0c9f7e1ac9bf) I tried disabling the highlight reconstruction module, which is enabled by default, and when I do that, the highlights turn pink. ![image](https://github.com/darktable-org/darktable/assets/57625350/76677f5d-229a-4973-a86b-514bd6036e7f) White balance is left at default (camera reference). ### Steps to reproduce 1. Make sure OpenCL is not enabled in settings 2. Open a RAW image (in my case a Nikon .NEF file) 3. Check "enable highlight reconstruction" in the filmic rgb module 4. Set the threshold to where the clipped highlights are masked 5. Move the bloom $\leftrightarrow$ reconstruct slider towards bloom and observe the highlights becoming a darker and darker gray ### Expected behavior Moving the bloom $\leftrightarrow$ reconstruct slider towards bloom should bloom the highlights and not turn them gray ### Logfile | Screenshot | Screencast [d_common_log.txt](https://github.com/darktable-org/darktable/files/12717915/d_common_log.txt) [d_opencl_log.txt](https://github.com/darktable-org/darktable/files/12717959/d_opencl_log.txt) ### Commit _No response_ ### Where did you install darktable from? distro packaging ### darktable version 4.4.2 ### What OS are you using? Linux ### What is the version of your OS? Arch ### Describe your system? * Kernel: 6.5.4-arch2-1 * KDE * X11 * NVIDIA GeForce GTX 970, proprietary drivers * AMD Ryzen 5 2600 * 16 GB RAM ### Are you using OpenCL GPU in darktable? No ### If yes, what is the GPU card and driver? NVIDIA GeForce GTX 970, proprietary drivers ### Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip I'm pretty sure I had the same issue on Wayland. The weird thing is that it used to work for me as expected a couple of days ago before I had OpenCL installed/enabled. System updates might have broken something else?