Any lensfun/darktable expert here?

Processing
,
21

… and try with deleting your lang=“en” entry.

The original lens without extender is like this in the db (mil-canon.xml):

    <lens>
        <maker>Canon</maker>
        <model>Canon RF 100-500mm F4.5-7.1L IS USM</model>
        <mount>Canon RF</mount>

So it contains “Canon” in the model tag. Your db has it only in the second (en) tag, but this one does not have " EXTENDER".

BTW, which OS are you on - do you modify the instance of the db that darktable is really using?

Edit: would be helpful if you also post your custom mil-canon.xml.

22

Names are NOT the issue. I also don’t have a custom canon mil file but a lensfun.xml with added lenses as one should. The issue is somewhere else so please.

23

Thank you for your kind tone. Over and out.

24

BTW, I got it working on my side, all automatic, not manually selected :wink:
And it is a name issue.

I took the lens data without extender, of course, since you did not submit your file.

image
image780×498 24.6 KB

1 Like
25

even with

    <lens>
        <maker>Canon</maker>
        <model>Canon RF 100-500mm F4.5-7.1 L IS USM + EXTENDER RF1.4x</model>
        <mount>Canon RF</mount>
        <cropfactor>1.0</cropfactor>
        <calibration>
            <distortion model="ptlens" focal="420.0" a="0.003" b="-0.008" c="0.011" />
            <distortion model="ptlens" focal="508.0" a="0.002" b="-0.008" c="0.008" />
            <distortion model="ptlens" focal="560.0" a="0.003" b="-0.009" c="0.013" />
            <distortion model="ptlens" focal="599.0" a="-0.007" b="0.023" c="-0.020" />
            <distortion model="ptlens" focal="661.0" a="0.008" b="-0.033" c="0.044" />
            <distortion model="ptlens" focal="700.0" a="-0.002" b="0.005" c="0.002" />
            <tca model="poly3" focal="560.0" vr="0.9998182" vb="0.9999927" />
            <tca model="poly3" focal="599.0" vr="0.9997888" vb="0.9999732" />
            <tca model="poly3" focal="661.0" vr="0.9997803" vb="0.9999644" />
        </calibration>        
    </lens>

and put directly into the canon-mil file in the updates directory it does not work for me after running lensfun-update-data. Maybe my darktable database is screwed up I don’t know as I started with this name of course.

Name changes directly show up in the darktable drop down list so updating the lensfun database is working fine

26

I’m on macOS, the database is directly included in the app bundle, and I simply edit the mil-canon.xml. No lens-fun-update-data.
Of course a custom lensfun.xml is better, as the standard files might be overwritten with a lensfun-update-data, should this run somewhere in the background.

Anyway, I simply appended the " + EXTENDER RF1.4x" to the model tag of the “Canon RF 100-500mm F4.5-7.1 L IS USM”, saved the file and done.
There’s no “en” version of the tag in mil-canon.xml, so no need to bother with it (but as I said, the code in lensfun would use the “en” entry if present and not the generic one, so you should delete it).
BTW, I modified the version_1 file, not the version_2 - not sure if this plays a role.

With this, the lens is already automatically recognized, but shown in a bit weird way in the lens correction module as “Canon, Canon RF 100 …”.
So I deleted the maker tag for that lens in the database, and now it shows up as expected “Canon RF 100…” automatically.

1 Like
27

grafik
grafik460×135 9.96 KB

even this does not work for me here on Arch Linux. It is frustrating :smiley:

28

Is arch Linux still using 0.3.95 of lensfun? :skull:

29

Fortunately not Arch Linux - lensfun 1:0.3.4-6 (x86_64)