backup destination to internal media

Fair enough. I have had to clean up enough messes by clients that I tend to not give them the option to be vulnerable. But, as I said, it’s your project.

I’ve now had a chance to test the latest build. Still not working accessing backup directory (from a Mac) via Samba

pi@raspberrypi : ~/BACKUP  ls -l
total 4
drwxr-xr-x 5 root root 4096 Dec 31 1969 201907311036-5034 

That pesky lack of date (I assume you see the same incorrect date on your tests, but it does not lock you out of the directory?)

This time, I was able to add a touch command to the internal-backup.sh script after the rsync command and it worked:

# Perform backup using rsync
rsync -av "$STORAGE_MOUNT_POINT" / "$BACKUP_PATH"
sudo touch  "$STORAGE_MOUNT_POINT" /"$BACKUP_PATH"

thus:

pi@raspberrypi : ~ $ ls -l BACKUP/
total 4
drwxr-xr-x 5 root root 4096 Aug 12 11:44 201907311036-5034

and now the Samba share works for me. I can’t see any downside to touching that directory, so I request that you add that line to the build. (yes, I know I have to learn how to submit these using Git, working on it)