Blender AgX in darktable (proof of concept)

I’m afraid there is a requirement for libjxl, which is only part of Ubuntu 24.04 (‘noble’), but I use 22.04 (‘jammy’) for my builds, since the beginning (see Blender AgX in darktable (proof of concept) - #38 by victoryforce).

2 Likes

Alas, the branch blender-agx-poc is no more.
From now on, please use the branch agx to create new builds. And cross your fingers for A port of Blender's AgX to darktable by kofa73 · Pull Request #19026 · darktable-org/darktable · GitHub :smiley:

A new build from that branch (no functionality change, hopefully):

  • I’ve changed some tooltips and GUI labels. There is one I’d like to highlight:
    • on the primaries tab, I’ve added section dividers to separate the ‘preprocessing’ and ‘postprocessing’ sliders;
    • the postprocessing (outsetting, rotations) sliders no longer use the wording ‘attenuation/rotation reversal’, ‘restore purity’ etc., because, unlike in sigmoid, we have detailed controls, and are not simply using the same values as for the preprocessing (‘insetting’ + rotation).
    • disable adjustments is now at the top, and hides all controls (including the selector for base primaries and the preset selector + button).

In the process of cleaning up, I have renamed some configuration variables. You can ignore this, and quickly re-adjust the UI, or migrate them as follows by editing your darktablerc (there is no automated migration possibility that I’m aware of):

old new
plugins/darkroom/agx/show_curve plugins/darkroom/agx/expand_curve_graph
plugins/darkroom/agx/graphheight plugins/darkroom/agx/curve_graph_height
plugins/darkroom/agx/curve_tab_enabled plugins/darkroom/agx/enable_curve_tab

The code has been refreshed from master, up to and including ab60bc56.

[edit: removed link to glitchy build, as the fix will be uploaded in a few minutes – please check the comments below]

I will be posting new builds as I address review comments. Though they should bring no new functional changes (except for bugfixes), I have to ask you to continue testing them (and supporting the process by contributing Windows and Mac builds).

Last minute bug:
While testing the build, I found that with weird params, it is now possible to create a wonky-looking curve. I don’t think it comes up in real usage, but I will check:

14 Likes

How to download with this link?

Sorry, my hosting provider changed the control panel and I didn’t notice that broke the link. It worked for me, as I was obviously logged in.

edit: removed build to broken build, fix is below

But you may want to wait a bit, I might have found the issue with the curve.

No fix yet, so go ahead if you wish. Unless you use extreme values (low relative exposures, high pivot x shift, toe and shoulder length), you should be fine. I’m on it.

1 Like

Sure.

Congratulations and I applaud your decision to bring AgX into the master branch!

I keep my fingers crossed that everything goes well. :crossed_fingers: :wink:

7 Likes

The issue has been fixed. Before/after:

The updated AppImage:
https://tech.kovacs-telekes.org/dt-agx/Darktable-5.3.0+26~g3977cd3a37-x86_64.AppImage

@MStraeten , @Dave22152 , @priort , please update your builds.

Sorry about that bug.

8 Likes

Here’s the Win 11 build:

https://www.dropbox.com/scl/fi/wuxvrvtzcqtdeaj9wu670/darktable-5.3.0-26-g3977cd3a37-win64.exe?rlkey=0534xcpy7c1f4qlff5d46nyea&st=bj8u66h2&dl=0

1 Like

Excellent work by @kofa and excellent contributions by all the testers here. I for one can’t wait to see it in the master build.

4 Likes

I Just built the latest on Windows (msys2) and noticed that there is a significant latency when bringing an image from lighttable to darkroom. It takes 6 seconds with this version while it was taking around 2.5s with the previous one and with the official from master. All version are using GPU and Task Manager is not showing any obvious bottleneck.

Could be just me. I’ll check later to see if someone else has the same issue.

Anyhow, thank you very much for this incredible module!

I haven’t noticed any slow-down. Others? The computations are (should be) the same as before.

Did you built the release and master as well in msys2 ?
Just to be able to remove problems coming from your build chain

Thank you for the clarification, and congratulations for the work on this module. Let’s hope for the best regarding its inclusion in the regular darktable build.

1 Like

For me (on Linux) nothing has changed regarding speed.

1 Like

Did you built the release and master as well in msys2 ?

Yes, I built both master and agx with msys2. Updated and rebuilt master just now and have now the same problem with master. So the good news is that it has nothing to do with agx.

darktable-5.3.0+21 runs just fine, darktable-5.3.0+24 shows a significant slow down between lighttable and darkroom. Could also be because of the latest msys2 updates.

2 Likes

You could rebuild darktable-5.3.0+21 just to test (you can do a git checkout using the commit hash).

In the last four commits I see nothing that could slow down darktable.

@dtrtuser, I have the same latency as you do with the latest Windows (msys2) build. What was around around 2.5 sec or less is now around 6 sec.

I don’t have the issue with the Win11 built of @Dave22152, it takes about 3 seconds.

Yes, I meant the rebuild to test the hypothesis:

@dtrtuser I just tried the @wpferguson weekly insider build and the latency issue is completely gone.