CR3 metadata decoding test of feature branch on Linux

Software RawTherapee
10

@jhmnieuwenhuis , I see a similar error in Linux as you point out in OSX:

The problem is that the output from my experimental fork GitHub - KarlMagnusLarsson/RawTherapee: A powerful cross-platform raw photo processing program branch metadata-exiv2-update does not embed color profile at all. A command like:

exiftool -icc_profile:* <picture-file>

Generates NO output. Nothing. Regardless of output color profile chosen in RT

The issue:
This problem affect the temporary file when pushing to external editor from RT main edit window, that is file sent to external editor after RT raw conversion has no embedded color profile. This also affect any regular output, that is files sent to the normal processing queue. There is no embedded color profile regardless of output color profile chosen in RT.

If I go back to RT main repo GitHub - Beep6581/RawTherapee: A powerful cross-platform raw photo processing program branch metadata-exiv2 and add the patch Exiv2::enableBMFF(true); to rtengine/imagedata.cc to make metadata visible. Then I am back to before my merge of latest dev branch.

xiv2::Image::AutoPtr open_exiv2(const Glib::ustring& fname)
{
#ifdef EXV_ENABLE_BMFF
    Exiv2::enableBMFF(true);
#endif

#ifdef EXV_UNICODE_PATH
    glong ws_size = 0;
    gunichar2* const ws = g_utf8_to_utf16(fname.c_str(), -1, nullptr, &ws_size, nullptr);
    std::wstring wfname;
    wfname.reserve(ws_size);
    for (glong i = 0; i < ws_size; ++i) {
        wfname.push_back(ws[i]);
    }
    g_free(ws);
    auto image = Exiv2::ImageFactory::open(wfname);
#else
    auto image = Exiv2::ImageFactory::open(fname);
#endif
    return image;
}

and if I then build the old branch metadata-exiv2+ small patch, then I get the same thing. No embedded color profile in RT output when pushing to external editor or when creating output using the regular queue.

  1. I think the error is in RT main repo GitHub - Beep6581/RawTherapee: A powerful cross-platform raw photo processing program branch metadata-exiv2, from the beginning. (It looks like it is not a result of my merging the metadata-exiv2 branch into dev to create metadata-exiv2-update).

  2. The current dev branch is fine in GitHub - Beep6581/RawTherapee: A powerful cross-platform raw photo processing program. The output files have embedded color profiles where the RT output color profile is respected, also for CR3 (but then there is no metadata)

The documentation to build the experimental fork metadata-exiv2-update branch is in thread history above and linked here: CR3 metadata decoding test of feature branch on Linux - #7 by KarlMagnusLarsson

What do you think? How to fix the missing color profile in output? I think it is somewhere in metadata-exiv2 branch in #5889. If the fault is found, then I will update my fork.