Yep, film grain would be a wonderful addition to RT. I wouldn’t need 2 editors for most of my workflow…
Someone please do it! Ill buy a beer! 
Thank you, File Browser is working again
I also didn’t want to say you should copy local editing from one of the other applications. It was meant as a suggestion on how to improve things.
RE curve based mask: Is local editing on a seperate path in the whole pipeline or is it in the same pipe after “color” tools? Will the mask also be changed when I adjust global exposure, white balance or HSL Equalizer while already having a mask curve adjusted?
An issue that I had from the first time I played with ART: Orientation of jpegs isn’t correct. Portrait orientation is ignored in both File Browser and Editor.
Another issue is with moving the image on the canvas. The low-res image is shifted making it hard to properly align for the high-res version. It extends the borders.
Short video (also showing JPEG orientation issue):
https://youtu.be/1RoCfJ0NQXE
BTW.: Would you prefer an issue on your REPO instead of keeping them stack up here? As you say it currently is under heavy development and probably you already know about these things…
It’s only one pipeline, there’s no “local editing” concept per se. There are different tools, in different positions in the pipeline, and some of them support masks. They are grouped together in the UI, but that’s it.
Will the mask also be changed when I adjust global exposure, white balance or HSL Equalizer while already having a mask curve adjusted?
those three tools come before any local editing, so yes, they will change the masks. The rule of thumb is global edits first, local edits at the end. Of course that’s not always possible, but then you have to be prepared to tweak the masks.
Thanks for reporting, and don’t assume these are known bugs They might be, but that’s not the norm. On any case, it’s better to report twice than never… and yes, if possible I’d prefer bug reports in the bug tracker, thanks!
Can you send me a sample please? thanks!
@agriggio Can you briefly explain the use cases for Log encoding and Tone equalizer?
Thanks for your work.
The tone equalizer is based on an early version of the one of @anon41087856 (see https://discuss.pixls.us/t/a-tone-equalizer-in-darktable), with some tweaks. Essentially it’s a parametric tone curve, but it operates in scene-referred space (meaning no clipping, unbounded data), and happens much earlier in the pipeline than the usual tone curves. It gives you a way of controlling the tonal balance of the image. I use it very often personally.
Log encoding is a way of mapping from scene-referred to display-referred, using the ACES formula that you can find at GitHub - ampas/aces-dev: AMPAS Academy Color Encoding System Developer Resources (and which has been discussed extensively here as well), plus a re-linearization afterwards. You can view it as a “poor man”'s filmic, covering only the basics, without the magic of the desaturation and tone curves, which in ART you have to do by hand with the curves in the tone curve tool (this is by design). You can view this as an alternative to the dynamic range compression tool if you want (though nothing prevents you from using both). Personally, I like the output of dynamic range compression better most of the time, but there are situations in which log encoding is useful and works pretty well.
For both tools, the “detail” slider tries to preserve the local contrast. If abused, it can introduce halos. If that happens, move the slider to the left until the halos go away (or find the sweet spot between artifacts and detail preservation…)
5 Likes
Thanks for the information. I think I really need to learn and understand that scene-referred / display-referred thing!
Well this was bound to happen I guess. It saddens me a little, although I can not blame you for doing it. I do hope that the RawTherapee team ends up implementing the local adjustment tool sometime. Thanks again for the great work and the effort in making the dream of local adjustments in RT a relity! 
you rock!
Bug report including a JPEG file is here:
https://bitbucket.org/agriggio/art/issues/4/ooc-jpeg-portrait-orientation-ignored
1 Like
ART_master_0.1-30-g7844e4667_W64_SSE4_190913.zip
uploaded at
https://keybase.pub/gaaned92/ART-W64NightlyBuilds
The crop tool is fully satisfying.
There remains the minor bug already detected by @ff2000 that was, I think already present in RT :
if you select theme-based, the whole uncropped image is displayed. I think it should only display the cropped zone.
Same with all themes.
edit: could you suppress the autofill tool or at least deactivate it by default.
1 Like
hmmm…it works for me with gtk 3.18. I’ll try to test with a more recent version, maybe it’s related to that.
IMO no. Load Neutral Profile, zoom in, activate “Transform → Crop” module and there click “Select”. You are left with a hand cursor (move selection) and no way to actually select the crop. I think there really are use cases (as also noted in my previous post) to show the full image, like this.
I think you can do this with a custom default profile, though I have to double check
this is not the intended behaviour, seems like a bug. I’ll investigate.
fyi, now activating the crop tool will zoom out only if you are in “zoom fit” mode. if you are zoomed in, the level is preserved. again, if that’s not the case, it’s another glitch that will eventually go away (if properly reported
I noticed this case but it did not bothered me.
Yes Once you activate the crop tool, you have to activate select.
Then if no crop zone is defined, as it is the case here, one should be able to draw the initial zone. instead it is defined as the boundary of full image.
To draw the crop zone:
after zooming don’t activate the crop tool. directly select . Then you can draw the zone. the tool becomes active.
If you reset, the zone definition is not deleted (no zone defined) but it becomes the full image.
So the initial state of the crop tool should be “no zone defined” and the reset should come back to this state. In this initial state, of course select is ON. This will permit to draw a new zone.
I am sure there always is a zone defined as soon as the crop module is activated. It’s just that currently the Guide Type is only drawn when you are in “Edit crop zone” mode. No idea if it is intentional or a glitch, but I think the Guide should be visible as long as the “Crop” module has input focus.
And IMO every option the GUI offers should be usable without the user feeling “stuck”. If I have to use the tool button “Crop selection” instead of enabling “Crop” module and clicking “Select” I can entirely get rid of the Select button.
Finally I hope Agriggio finds his peace with the crop tool, there for sure are better ways to spend the time on 
this won’t happen. as for the rest, I’ll take a look to see if they are bugs. I’m still not sure I understood exactly what you are describing…
If you select neutral profile, the crop tool is reset and deactivated. Then when you activate the crop tool, the initial zone is defined as the entire image. Same if you reset.
You are then not able to draw a zone, but only modify it after a “select”.
if you select a guide type, it is displayed (when in select mode of course)
and
I fear that for the crop tool you need two actions, whatever they are named and done ( activate and select, activate and collapsed:expanded) to define 4 states:
deactivated: no action of the tool, full image displayed
activated and selected : full image is displayed, you can define, modify the zone, you can change the guides. The zone limits and guides are displayed
activated and deselected: cropped zone only is displayed. no zone limit of course, no guide, no possibility to change the crop.
if you deactivate, the crop definition are kept.
if you change profile or reset, crop definition is suppressed. if you click activate and select (or select which activates the tool) , you have to draw a new zone.
agreed
Worked perfectly for me, thanks for doing this Morgan.
1 Like
The file expired 1 day ago for me. 