My take on RawTherapee

[gaaned92]

Thanks for your answers @agriggio

@agriggio

in the specific case of vibrance, you can use saturation with a chromaticity mask in the colour correction module.

yes I should have thought of that!

lesstools branch

• I opened a ticket for the pink cast with lesstools.
• I see that in local contrast, you keep also unsharp mask. In RT I far preferred the wavelet local contrast, compared to the local contrast.
  It seems localcontrast/unsharp mask is an improved tool which can also modulate the global contrast.
  Why you kept the 2 tools?
  In local adjustment, what tool should I use to get the same effect?
  With Color correction contrast (power…) , I did not succeed.

[agriggio (Alberto)]

@gaaned92

I opened a ticket for the pink cast with lesstools.

thanks, I’ll take a look asap

@gaaned92

Why you kept the 2 tools?

because I’m not done yet you’re right, the simple local contrast will go

@gaaned92

In local adjustment, what tool should I use to get the same effect?

cbdl will get you close; if that’s not enough, you can add a touch of texture boost

[gaaned92]

Sorry, I don’t stop asking questions.

I digitizing very old family photos (Nineteenth century) made by professionnals.
In RT, after BW, I can use color toning/color correction region to give the required tint (different sorts of sepia).
I cannot happen to tint a BW photo in artless

[agriggio (Alberto)]

correct. That’s because I moved B&W towards the end of the pipeline, as requested by @sguyader (see this post). You can desaturate with colour correction and then apply the grading you want.

[gaaned92]

@agriggio

You can desaturate with colour correction

I get a grey photo. ok. I can change contrast and so on.

@agriggio

then apply the grading you want.

Ok vith a new correction

Thanks.

Note: it shows that understanding how the pipeline is organised is important for user.

[gaaned92]

@agriggio

You can desaturate with colour correction

I get a grey photo. ok. I can change contrast and so on.

@agriggio

then apply the grading you want.

Ok vith a new correction
Thanks.

but B&W is not very useful for me in this case. I wonder if I can use CBDL as it is useful to soften the aspect as in original. will try.

note: it shows that understanding pipeline organisation is important for user.

[agriggio (Alberto)]

@gaaned92

but B&W is not very useful for me in this case.

Yes, I see the problem. I’ll think about a better solution.

@gaaned92

note: it shows that understanding pipeline organisation is important for user.

I agree

[agriggio (Alberto)]

@agriggio

I’ll think about a better solution.

How about this?

[gaaned92]

For my use case, it is sufficient. And I am sure I can use all correction tools. thanks.

[ff2000 (Franz Trischberger)]

@ff2000

I had a play with some more files and found out that the win is not as clear Without realizing I tested images with a brighter subject in front of a darker background. This is where agriggios changes shine.
On the other hand it also prefers to sharpen the bright sky which contains no detail but only noise. pulling the threshold up will significantly reduce sharpening in the darker parts, whereas RawTherapee has no problems to mask out the sky and only sharpen actual detail.

Any comment on this would be appreciated.
Especially in backlit situations I have a hard time to sharpen the subject with ART. ART seems to even prefer sharpening blown out areas instead of the subject.

@ff2000

In the end I think it was the power that (I assume) will enlarge the contrast in brighter areas and keep it in for sharpening. If that is the case would it be possible to expose the power value in the UI so that the user can decide where he wants to see more sharpening?

Is this observation correct? Proposed solution doable? Should I report a bug?

[agriggio (Alberto)]

one solution could be to expose a gamma slider for the mask computation. another would be to move sharpening to local edits, but I’d like to think a bit more of the local edits workflow first. finally, the third solution is to be gentle with global sharpening, and then apply cbdl locally with a mask: did you try that?

[srgmro (Serge)]

@Carmelo_DrRaw
You intended to build an Appimage for ART. Do you published it somewhere ?
Thanks very much for your work.
SM

[Carmelo_DrRaw]

@srgmro

You intended to build an Appimage for ART. Do you published it somewhere ?

I’ve started to work on it, but I was getting some crash at startup… then I got side-tracked by other stuff. I will have a look again ASAP

[srgmro (Serge)]

Thanks for the consideration, hoping that you will succeed.
SM

[srgmro (Serge)]

@agriggio
@Morgan_Hardwood
since last update (0.2.12) addition of french language I have a compilation error , and I am unable to get the build-art file :
…
80%] Building CXX object rtgui/CMakeFiles/rth.dir/profilepanel.cc.o
/home/serge/programs/code-art/rtgui/preferences.cc: In member function ‘Gtk::Widget* Preferences::getGeneralPanel()’:
/home/serge/programs/code-art/rtgui/preferences.cc:658:139: error: use of deleted function ‘bool Glib::operator!=(const Glib::ustring&, int)’
if (/“default” != langs[i] &&/ “README” != langs[i] && “LICENSE” != langs[i] && langs[i].size() > 0 && langs[langs.size()-1] != ‘~’) {
^~~
In file included from /usr/include/glibmm-2.4/glibmm/exception.h:22:0,
from /usr/include/glibmm-2.4/glibmm/error.h:22,
from /usr/include/glibmm-2.4/glibmm/thread.h:47,
from /usr/include/glibmm-2.4/glibmm.h:88,
from /usr/include/gtkmm-3.0/gtkmm.h:87,
from /home/serge/programs/code-art/rtgui/preferences.h:23,
from /home/serge/programs/code-art/rtgui/preferences.cc:20:
/usr/include/glibmm-2.4/glibmm/ustring.h:1645:6: note: declared here
bool operator!=(const ustring& lhs, int rhs) = delete;
^~~~~~~~
[ 80%] Building CXX object rtgui/CMakeFiles/rth.dir/profilestorecombobox.cc.o
rtgui/CMakeFiles/rth.dir/build.make:2150: recipe for target ‘rtgui/CMakeFiles/rth.dir/preferences.cc.o’ failed
make[2]: *** [rtgui/CMakeFiles/rth.dir/preferences.cc.o] Error 1
make[2]: *** Attente des tâches non terminées…
CMakeFiles/Makefile2:218: recipe for target ‘rtgui/CMakeFiles/rth.dir/all’ failed
make[1]: *** [rtgui/CMakeFiles/rth.dir/all] Error 2
Makefile:129: recipe for target ‘all’ failed
make: *** [all] Error 2
…

[Morgan_Hardwood]

@srgmro Format your code to make it more readable

[srgmro (Serge)]

@Morgan_Hardwood
how I do that, I am far from being expert.
Serge Moreau

[agriggio (Alberto)]

@srgmro my bad, I introduced a silly typo in my latest commit. Should be fixed now, sorry!

[srgmro (Serge)]

…
[ 80%] Building CXX object rtgui/CMakeFiles/rth.dir/profilepanel.cc.o
/home/serge/programs/code-art/rtgui/preferences.cc: In member function ‘Gtk::Widget* Preferences::getGeneralPanel()’:
/home/serge/programs/code-art/rtgui/preferences.cc:658:139: error: use of deleted function ‘bool Glib::operator!=(const Glib::ustring&, int)’
if (/“default” != langs[i] &&/ “README” != langs[i] && “LICENSE” != langs[i] && langs[i].size() > 0 && langs[langs.size()-1] != ‘~’) {
^~~
In file included from /usr/include/glibmm-2.4/glibmm/exception.h:22:0,
from /usr/include/glibmm-2.4/glibmm/error.h:22,
from /usr/include/glibmm-2.4/glibmm/thread.h:47,
from /usr/include/glibmm-2.4/glibmm.h:88,
from /usr/include/gtkmm-3.0/gtkmm.h:87,
from /home/serge/programs/code-art/rtgui/preferences.h:23,
from /home/serge/programs/code-art/rtgui/preferences.cc:20:
/usr/include/glibmm-2.4/glibmm/ustring.h:1645:6: note: declared here
bool operator!=(const ustring& lhs, int rhs) = delete;
^~~~~~~~
[ 80%] Building CXX object rtgui/CMakeFiles/rth.dir/profilestorecombobox.cc.o
rtgui/CMakeFiles/rth.dir/build.make:2150: recipe for target ‘rtgui/CMakeFiles/rth.dir/preferences.cc.o’ failed
make[2]: *** [rtgui/CMakeFiles/rth.dir/preferences.cc.o] Error 1
make[2]: *** Attente des tâches non terminées…
CMakeFiles/Makefile2:218: recipe for target ‘rtgui/CMakeFiles/rth.dir/all’ failed
make[1]: *** [rtgui/CMakeFiles/rth.dir/all] Error 2
Makefile:129: recipe for target ‘all’ failed
make: *** [all] Error 2
…

[agriggio (Alberto)]

@srgmro

&& langs[langs.size()-1] != ‘~’) {

this was the problem, now it should be fixed (like this):

&& langs[i][langs.size()-1] != '~') {