+1
Got a few warnings and errors:
- OpenColorIO Error
- (photoflow.exe:3104): VIPS-WARNING **
At the end of the output, PhotoFlow stalls. I either have to close it or wait a long time.
Saving image to file X:\_px\_pr\a.jpg...
OCIOFilmicPar: config=0x16d80300
OCIOFilmicPar: device=sRGB
OCIOFilmicPar: transformName=Filmic Log Encoding Base
OCIOFilmicPar: displayColorSpace=Filmic Log Encoding
OCIOFilmicPar: lookName=Very High Contrast
OCIOFilmicPar: processor=0x16d7ff20
ColorCorrectionPar::build(): 0.5 0 0.5
OCIOFilmicPar: config=0x16d82680
OCIOFilmicPar: device=sRGB
OCIOFilmicPar: transformName=Filmic Log Encoding Base
OCIOFilmicPar: displayColorSpace=Filmic Log Encoding
OCIOFilmicPar: lookName=Very High Contrast
OCIOFilmicPar: processor=0x16d82640
ColorCorrectionPar::build(): 0.5 0 0.5
Image size: 1152,864
Shrink factor: 0.674769
ImageArea::update(): before vips_resize()
ImageArea::update(): after vips_resize(), outimg: 0xa8464b0 outimg2: 0xa846320
OCIOFilmicPar: config=0x16d7c370
OCIOFilmicPar: device=sRGB
OCIOFilmicPar: transformName=Filmic Log Encoding Base
OCIOFilmicPar: displayColorSpace=Filmic Log Encoding
OCIOFilmicPar: lookName=Very High Contrast
OCIOFilmicPar: processor=0x16d7c2c0
ColorCorrectionPar::build(): 0.5 0 0.5
OpenColorIO Error: Error could not read 'X:\photoflow-w64-20190210_2203-git-stable-cc18b4ef5323b01d6710a696831befa82280ed8d\bin\..\share\photoflow\\ocio-configs\filmic-blender-master\config.ocio' OCIO profile.
OCIOFilmicPar: config=0xa895fc0
OCIOFilmicPar: device=sRGB
OCIOFilmicPar: transformName=Filmic Log Encoding Base
OCIOFilmicPar: displayColorSpace=Filmic Log Encoding
OCIOFilmicPar: lookName=Very High Contrast
OCIOFilmicPar: processor=0xa895e10
ColorCorrectionPar::build(): 0.5 0 0.5
Image::do_export_merged(): ext=jpg
output size: 9
width=1920 height=1200
ScalePar::build(): scale=0.347222 kernel=4
SharpenPar::propagate_settings(): usm_radius=0.8
SharpenPar::compute_padding(): method.get_enum_value().first=0
GaussBlurPar::compute_padding(): radius=0.8 level=0 radius2=0.8
GaussBlurPar::build(): radius2=0.8 accuracy=0.01
GaussBlurPar::build(): convsep mask size=5 1
Image::do_export_merged(): profile_type=3 trc=0
Embedded profile found: sRGB-elle-V4.icc
Image::do_export_merged(): Q=100 no_subsample=1
(photoflow.exe:3104): VIPS-WARNING **: 15:23:12.120: ignoring trellis_quant
(photoflow.exe:3104): VIPS-WARNING **: 15:23:12.120: ignoring overshoot_deringing
(photoflow.exe:3104): VIPS-WARNING **: 15:23:12.120: ignoring optimize_scans
(photoflow.exe:3104): VIPS-WARNING **: 15:23:12.136: ignoring quant_table
Jpeg image saved in 43.6272 s
do_export_merged took 46199 ms
Warning: Exif tag Exif.Olympus2.ThumbnailImage not encoded
Warning: Exif tag Exif.OlympusCs.PreviewImageLength not encoded
Warning: Exif tag Exif.OlympusCs.PreviewImageStart not encoded
Warning: Exif tag Exif.OlympusCs.PreviewImageValid not encoded
Warning: Exif tag Exif.Photo.MakerNote not encoded
Warning: Exif tag Exif.OlympusIp.0x0635 not encoded
Warning: Exif tag Exif.OlympusIp.0x0636 not encoded
Warning: Exif tag Exif.OlympusIp.0x1103 not encoded
Warning: Exif tag Exif.OlympusIp.0x1104 not encoded
RawLoaderPar::~RawLoaderPar(): raw_image=0xb75a010
RawLoaderPar::~RawLoaderPar(): raw_image->get_nref()=3
~OpParBase(): deleting operation 0xb5c8c20 (raw_loader)
~OpParBase(): deleting operation 0x136bc400 (uniform)
~OpParBase(): deleting operation 0x212299b0 (blender)
~OpParBase(): deleting operation 0x10e47b70 (raw_developer_v2)
PS Following up with closing floating windows, Esc doesn’t work when dealing with layers in mask mode. Unsure whether it happens all the time, but when it does, only the first floating window in mask mode cannot be closed. Subsequent ones can. Also, when I toggle show mask a few times, it either doesn’t work or it crashes PF. (I have reported this one before.) Unsure whether a floating window needs to be open for that to happen. I don’t know what triggers the two issues, but they happen often.
PPS Actually, masking doesn’t work for me. It only works after PF crashes and later asks me to recover. Then white rectangle turns into a marked (gradient) rectangle.
“Doesn’t work” means that the mask is not applied? Which kind of mask are you trying to create?
Yes, I mean that it isn’t being applied and that there is a lot of crashing going on (from toggling the show mask, layer check boxes or clicking the back button). Sorry that I haven’t share the output before the 6 crashes I experienced today… It isn’t a new problem; I rarely use masking though. Oh, the white rectangle means there is no mask, right? This rectangle only has a gradient fill appearance when PF crashes and I opt to recover.
@afre
I have found and fixed a crash that occurred when deleting a layer, specifically when a tool dialog of one of the mask layer associated to the deleted one was opened.
There are probably other sources of crashes, but that was a clear one…
I have also added a “close” button to the tool dialogs, and fixed the propagation of keyboard events that prevented the Esc button to work properly in the case of the curves dialog. If other dialogs show a similar problem please let me know, I will fix them as well.
I still don’t know why the “x” button does not properly close the tool dialogs on Win, and also why it is not showing when using Wayland, but I’m investigating.
1 Like
One less bug is still an improvement. 
I haven’t downloaded the latest commit yet. I am being more careful about staying within my monthly bandwidth limits.
In the prior commit, this is what the windows look like. Top is PF’s main window. You have minimize, maximize and close. Middle is the module parameters window. Notice that the x is really and permanently faded; means that it is disabled. Mouse over doesn’t light it up either. The next one is an active open window. Active buttons are bright. If you could make the parameters window behave the same way as the open window, that would be great.
PS I downloaded the latest commit. It took a much longer to decompress; might be the way it was packaged or due to Defender (my recent thread Reasons the app isn't running well on Windows). The startup time is much quicker now. 
I like the close button. Unfortunately, it is out of sight, in the bottom right corner.
PPS Might be too soon to try [tools/OCIO transform] initial implementation]. When I create the layer, the preview gets distorted with all sorts of things, depending on what I select; e.g., tiles, dots, etc. Clicking on one of the boxes in the GUI crashes the app. Each time I try again, the distortion is very different in appearance.
I am still fighting with that… no idea why Windows behaves differently from Linux/macOS in this respect.
You need to load a specific ocio.config file for this to work. There is no “default” configuration for the tool… anyway, it is still WIP 
Two new improvements are available in the latest PhF version:
Color correction load/save function
The “color correction” tool, which implements the ASC-CDL controls, now has two buttons for loading and saving standard CDL files. It is therefore now possible to inter-change color grading presets between applications that support ASC-CDL.
Notice that the CDL file format does not specify the colorspace and encoding expected by the adjustments, and it is therefore the responsibility f the use to prepare the data in the correct colorspace (via a colorspace conversion layer prior to the color correction) and tick the “log encoding” checkbox if needed.
The range of the sliders has also been modified/improved. The sliders now directly reflect the value being applied in the CDL, except for the offset where a x10 scaling is introduced to allow a finer tuning. This makes the tool more standard.
Notice that the change in the sliders only affects the values exposed by the UI, not those used internally in the calculations. Therefore all previous edits will still look the same.
Here is how the new dialog looks like:
Dynamic range compressor
I have introduced a new version of the dynamic range compressor tool, which uses the guided filter instead of bilateral blur for the local contrast adjustment. The guided filter should be faster and more accurate around edges.
Again, old edits will not be affected and will still use the previous version of the tool. However, for new edits only the new version is available.
Enjoy!!!
The (x10) could be ambiguous. Does it mean val=slider*10 or val*10=slider?
Some news about recent developments:
-
an improved shadows/highlights tool is available. It is meant to replace both the old shadows/highlights as well as the dynamic range compressor. More info can be found here and here (the blog post is still work in progress).
-
the RAW black levels can now be adjusted separately, and the controls have been moved to a separate “advanced” tab in the RAW processor GUI. The other controls have been also re-shuffled:
- “input” tab: WB, exposure and demosaicing
- “corrections” tab: hot pixels filter and lens corrections
- “output” tab: colorspace conversions and DCP profile selection
- “advanced” tab: black and white level corrections
-
the tone mapping tool has now an additional slider to control the saturation of the shadows, similar to the already existing highlights saturation control
-
The title of the main application window now shows the branch, commit hash and build date
2 Likes
Thanks! This is a big update for me. All long hoped for. 
Dear all,
the new UI layout has landed in the stable branch, and is available in the latest packages.
The UI still works optimally only for GTK2, I am still working on the GTK3 version.
The main goal is to provide a maximum of space for the image preview, and also to provide better looking UI controls (like sliders).
A new feature has also been added to the shadows/highlights tool: a local contrast control, that, as the name suggests, allows to boost the local contrast while avoiding over-brightened highlights. The concept behind was partly introduced here, but I will write some better description in my blog very soon.
Here is how the new UI and the latest shadows/highlights interface look like (notice the new “local contrast” slider):
Comments/suggestions are welcome as usual!
2 Likes
Hello,
On your screenshot it looks quite nice!
The preview image is looking better than ever! It has come a long way and appears acceptable now. I await your blog post.
I’m no PhotoFlow expert but it feels nicer than before. As a rare user of PhotoFlow I have a few suggestions. In no particular order but numbered anyway. Please take the suggestions with a pinch of salt.
- The top left buttons do not respond to the width of the panel. Including getting cut off as there is no minimum width. Some sort of reflow or scaling would feel better and a min width that prevent the buttons from being cut would be great.
- The first and second row of buttons are different types but follow the same visual logic. The first row is what typically goes in a File menu.
- The export to raster button has both a position and icon that is hard to find whilst being one of the most important buttons. Perhaps move it to the position of the “exit” button?
- The camera info lacks padding around the text but has excessive line-height placing the whitespace (greyspace in this case) in such a way that the information is visually scattered. The center alignment could perhaps also be reconsidered in favour of left aligned?
- The “new layer” button becomes aligned with the mask, sticky, info icons. Some sort of vertical border splitting the tools off perhaps. Or a different vertical alignment.
- I’ve always felt that PhotoFlow and in particular the new layer dialog would benefit from a dmenu type hud. Using type ahead to filter the list of possible layers hit enter to create.
- Enable spacebar (gimp) for panning and double click for toggle 1:1 <> zoom to fit
Thanks!
1 Like
I agree with everything you have said. I either mentioned it before or have experiened the same qualms.
1-3. The appearance, design and placement of these icons need some consideration. I avert my eyes until I need to use them. 
4. Moreover, I am beginning to think that it may be a good idea to make it into a tab after histogram and samplers since it is static information. Would save vertical space.
5. More padding would help. Nothing else, besides the camera info, is that tight. Consistency is important. Mask, sticky and info should be on the right side.
6. My frequently asked request. Needs a search function!
7. Yes, better panning and zooming, and edge examination is important to me.
You are absolutely right, and that was part of the “glitches” of the new UI layout that I still had to work on. Fixed in current git.
I am indeed planning to implement a proper File menu, which will replace the first row of buttons. So I prefer to keep things like this until the menu will be ready…
See above: it will go into a File menu.
Improved in current git:
Still requires additional work, and more information displayed. To save vertical space, it is now moved into an additional tab, after “histogram” and “samplers”
I’ll keep that in mind. Will look into that once the File menu is ready.
This is already possible:
- Ctrl-double-click to toggle 1:1 <> zoom to fit
- Ctrl-click&drag for panning
I agree, it is done.
It would look like this:
What do you mean by “edge examination”?
Is CTRL necessary?
Ability to pan beyond the edge.
Pan is buggy to me. If I click and release while accelerating in one direction, it scrolls for a distance. If I hold that click and move the mouse across the screen, the preview moves back and forth along the x or y axis but not gradually and ultimately to whatever direction the mouse is guiding it.
@Carmelo_DrRaw looks better already!
I do think the camera info could have even less line-height. Looks like near 2em at the moment. For info such as that 1.2em or even 1em could work. (1em is a relative measure equal to the point size of the type)
The new arrangement of the new layer icon and the rest looks way cleaner!
Unless there’s a reason I’d consider skipping the ctrl for the “viewport” and copy the behaviour from existing software people are likely to have used which one is the best I can’t say. I suggested gimp for oss familiarity.
Opening the raw files provided here Denoising: How variance stabilization transform work - #3 by rawfiner results in crashes.
1 Like