RawTherapee processing challenge

Wayne_Sutton · March 20, 2024, 9:50am

With RawTherapee version 5.10-461-g52088197f

IMG_0080_ws.jpg.out.pp3 (33.5 KB)

stefan.chirila · March 20, 2024, 3:09pm

very well done!

paulmatth · March 21, 2024, 9:56am

Image processed with Cam16 & JzCzHz only, latest pre release.

IMG_0080.jpg.out.pp3 (19.3 KB)

jdc · March 21, 2024, 10:05am

@nosle @paulmatth @Wayne_Sutton

Thank you

@HIRAM
“Overall these CAM tools seem to work at a better dynamic range than other of the CAM16 implementations”
See Rawpedia:
https://rawpedia.rawtherapee.com/Local_Adjustments#An_evaluation_of_the_dynamic-range_capabilities_of_tools_in_the_%E2%80%9Clacam16%E2%80%9D_development_branch

Yes, without using “Log encoding” type functions, we easily arrive at a Dynamic Range of more than 20Ev, which is more than sufficient in 99% of cases (Maximum Cameras about 15Ev).

Jacques

jdc · March 21, 2024, 12:29pm

Hello all

I just added in Cam16, in

“Source Data Adjustments”,
“Smooth lights”,
“Gamma - slope - based” a slider which allows you to simulate a “Tone mapping” (nothing to do with “Log encoding”, it’s near a Sigmoid), just a slider (and some settings) . I called him "Gray balance (Slope). Note the gamma TRC above = 5.95.

On the test image - TIF at 25Ev - with Cam16 Image Adjustments - Saturation = 73, we arrive at DR = 23Ev.

Executables
https://github.com/Beep6581/RawTherapee/releases/tag/pre-dev-github-actions

Jacques

micha · March 21, 2024, 5:20pm

Hello Richard,
I see, everything’s fine. I’m honored if the example can be helpful.

priort · March 21, 2024, 5:55pm

Jacques I’m going to try the latest version to see if I still see this issue but I am having trouble it seems in Windows with the version I am using. I add the spot and confirm that I enable it and then add the tool but none of the sliders or settings work initially. I check the delta E mask for the spot and nothing is masked. After a few attempts to change through basic standard advanced at some point things kick in… I am going to try the latest version and also do this systematically so that I can describe the problem if there is one… I’m just throwing it out there incase anyone else had some finicky interaction with the spot and this tool…

jdc · March 21, 2024, 6:09pm

@priort
Excuse my bad english

I don’t see what it could be? I’ve never had this behavior before? Is it for all tools (Color & Light, Denoise, Cam16, etc.), or for just one ?

Have you tried cleaning the cache? Because there are (maybe) changes not taken into account, given the volume of changes?

Keep me informed. But curious. I’m not saying it’s not possible since you reported the problem.

If you can clarify the problem, since when? what commit? Because I don’t know where to look.
I will look at this tomorrow…

Jacques

priort · March 21, 2024, 6:20pm

Don’t think on it for now… I will look at it tonight and confirm if I can reproduce. And do so systematically…Thx for your feedback

jdc · March 21, 2024, 6:37pm

@priort
One question, I am also on Windows (w11) and with “LA”, the number of handles required for GDI has increased considerably - and there are more (many) than in dev - as soon as we add GUI functionalities, notably expanders.

In my case, with an external screen, it crashed or caused curious malfunctions (sliders which appear or disappear, etc. , crash, etc.). Microsoft intended this to reduce the memory used. This issue was spotted in 2017. It also affects Linux - but to a lesser degree - , because the allocation base configuration is larger by default. At the time, it was Ingo who discovered the problem and the solution. Now everything is fine, even with 8 images open…

For example the value of “GDIProcessHandleQuota” is 20000 by default (w11) and 10000 (w8)…
I change this value to 50000, (maximum must be 65500), and no more problems.

With “regedit”
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Windows\GDIProcessHandleQuota

But maybe that’s not it? And a GUI bug…due to me

In any case thank you for your very active participation

Jacques

priort · March 21, 2024, 7:56pm

Thanks for the tip. I will incorporate that into my evaluations… Thanks for your very extensive and powerful tools

Edit I am on WIndows 11 and it was actually set to 10000… I am trying your setting of 50000… So far tonight no issue with a couple of images so all good…

jdc · March 22, 2024, 9:11am

@priort

Okay, that’s good, that was most likely it. But to see

I think:

a) it should be added to the documentation - where??;
b) why provide an option in Preferences for this. Because it’s always a bit “stressful” to tinker with these system settings. @Lawrence37 I think you talked about it

You can also change, and set to 18000.
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Windows\USERProcessHandleQuota

Jacques

jdc · March 22, 2024, 4:45pm

Hello.

I added a “Scale Yb scene” checkbutton to “Gamma - slope - based”.

This control generally allows a better balance of gray tones, for this “Tone mapping”

Jacques

jdc · March 24, 2024, 6:37am

Hello

I made some changes to the GUI for the “Smooth highlights rolloff” part. You now have access to all the choices, even in “Basic” mode.

In addition, Windows executables work again. Thanks to @Lawrence37
Check that there are no problems with the GUI following the modification proposed by Lawrence37 (only for Windows executables)

Executables Lacam16n

Jacques

jdc · March 25, 2024, 12:37pm

I’m opening the challenge to 2 new images, even if some “rascals ” have already processed them (no big deal at all…on the contrary perhaps ).

2010_MONTR_033.NEF (The blue horse)
Raw File

S7_00463.ARW
Raw file

Note that the latest merge I did with “dev” this morning causes - at least on my machine and under Windows - major malfunctions when working with 2 screens.
I tried to find out why? The latest commits introduce changes to “Preferences”, which apparently - at least for me - lead to some weird (to put it mildly) operation. But I’m not at all a specialist in this sort of thing.

To make it possible to evaluate “Cam16 LA…” with peace of mind, I’ve created a new Pull-Request, without the latest commits in Dev. But perhaps (to be confirmed) this only concerns me…
https://github.com/Beep6581/RawTherapee/pull/7010
This PR uses the branch “lacam16n2”

Executable are in the same folder, and named : lacam16n2
https://github.com/Beep6581/RawTherapee/releases/tag/pre-dev-github-actions

Of course, you can test (Windows, Appimage) the builds for which I’ve found malfunctions, and check if it’s just me…Named : lacam16n

Thank you

Jacques

PD1 · March 25, 2024, 2:13pm

Here’s my attempt with the horse. While I worked with CAM16, in this case, I also had to work with the tone equaliser to get the balance I was looking for. The next one will follow.

Used RawTherapee_6861merge_5.10-462-gd563de36b_win64_release