@garagecoder, thank you. Please also keep the current “Tone enhance” filter, because of the big change.
After refresh, your new filter isn’t there yet. Although I am very curious, I will wait patiently for an G’MIC server update.
edit: It is updated, so now I can test.
Description under filter “proposed update to Tone Enhance”
Again, please keep also original filter, because that is already useful. Maybe other people want also keep the functionality of original filter, so please make this filter after testing available as a new filter. Or make original functionality available within the new filter. Thank you very much.
edit2: I am very happy with this filter. Because of available color spaces, you can now see the different effects (saturation, contrast, lightness etcetera) these color spaces have, with using this filter.
edit3: These filters are also very good dehaze filters. (play with cut and normalize)
edit4:
After some testing I can say, I realy like this filter, It is nice to be able to change the gamma. I have the feeling that there are less “gradation artefacts” now you can change the gamma instead of brightness. But I miss the opportunity to set the overall brightness, so I have few wishes : Please add sliders for contrast and brightness for final editing. If it is possible (and takes not to much time, it’s no big wish) also (a) slider(s) for saturation.
What I might do is create the detail map always from RGB (otherwise it possibly has to build from one channel so not as accurate) but all adjustment will still be in the selected space.
I’m reluctant to keep both filters when they’re near duplicates, in fact I’d say the new one can do all that the old could only better. But if you’re convinced they should both exist I’ll consider
That’s probably a good idea, I think the original has an “override” forcing it to the main branch > details - if you can remove that I’ll set it in my filter file in a couple hours instead. Then when ready I’ll change the new version to be in the main branch and move the old to testing.
Also, Andy, don’t be shy, and do not hesitate to move your useful filters in the main branch when you consider they are working as expected
Regularly, I have to check the Testing/ folder to decide which filter could be moved, and this gives me some more work. I trust you enough to let you decide which filter to move by yourself
then I can customize my filters. But to programm filters by myself, will be to complicated. I think it would take years to make something useful. So thank you all to make all these things possible within G’MIC (for GIMP).
@iarga, yes you can add some brightness or contrast sliders from other gmic filters to this nice tone enhancer v2, just have a look at the third article in that serie. It’s really easy to do.
@garagecoder: nice enhancement to an already nice filter, thanks!
I started making my own filters a few years ago and they were very simple at first, but after a while, they became much more complex. I think it is worth to give it a go, even if it is something simple.
@iarga Funnily enough I do have another test filter for brightness (based on gamma to avoid clipping) and saturation so might be able to merge in, provided the filter doesn’t become too “busy”.
@David_Tschumperle Yes indeed, I’ll probably move the new “Temperature balance” in while I’m at it.
Probably a few hours before I can work on it all though. Thanks everyone!
I tested your new “tone enhance” filter with very dark and backlight pictures. Your new filter is maybe more subtle, but it doesn’t have the strong effect your original filter has. If I light the shadows with the “old” filter, the effect is strong. In your new filter there is much less lighting of the shadows.
So please keep also the old filter, because the difference is great now. So then we can choose the filter for the effect we want.
I understand that for already decent taken pictures, your new “Tone enhance” filter is more suitable, but for almost “forensic” changing very bad, dark and difficult backlight pictures, the original filter is very useful too.
edit: I played with following pictures from the Gimp Chat forum:
With this kind of pictures the original filter can almost do a miracle. Yes maybe there is clipping and maybe there are more artefacts. But when working with layers, you can nevertheless use this.
For already good pictures, your new filter is much better.
Thanks for the testing, I’ll see if something can be done for these situations too since it’s related to the filter purpose. Be mindful if you add this to faves that it’s likely to get a few updates!
In the final release of G’MIC 1.7.6 the “Saturation eq” filter “behaves” differently, also after refresh. In the pre release of G’MIC 1.7.6 the filter seems OK (also after refresh):
Also there is a difference between 1.7.6 final and pre in the “Selective desaturation” filter. With filter in “reset mode” it looks exact the same as second image above.
Hello @iarga,
Thanks for reporting. I’ll check today and try to understand what happened.
I’ve done some recent changes/improvements in the color conversion routines, so that may be the cause of the difference.
@iarga, I think I’ve found a critical bug in thr RGB->HSL function used by the CImg Library to perform the color conversion. Looks like I will have to release it asap, with a new version 1.7.7 !
Thanks again !
Yes, Thank you. I saw the use of RGB>HSL in the code of those filters. I do study a little bit now.
Now I can change simple things, for example adding more color spaces to a filter.
But from now on, I will follow your tutorials on the G’MIC website to get some basic knowledge. It will take much time.
: Please add sliders for contrast and brightness for final editing. If it is possible (and takes not to much time, it’s no big wish) also (a) slider(s) for saturation.
. I will have a look into the tutorials made by 
