Replace skull icon in lighttable

Indeed easy enough to replace in the code.

But the aggressive and condescending tone of OP’s first message and of the Github issue from 2019 make me understand why the request was ignored. (And for many here, me included, English isn’t their first language.)

As for replacing the image by an external (user-changeable) SVG or PNG: perhaps not quite as simple as all that. For one thing, what do you do if the users misnamee the image, or provide an image of incorrect size? At best, it needs a lot more code than the current system (runtime error checking vs. compile time checking).

1 Like

I can’t see any point in making it customisable. And for those that must, the source code, as has been mentioned, is at their disposal.

I can see a point in updating it to something less tty-ish and more simple-line-graphic. I don’t mind what graphic, as long as it is understood.

2 Likes

image

I think that would be the best one to pick – it’s universally understood. The one I posted is not CC, but making one in Inkscape would be a 10 minute job at most I guess.

EDIT: You know what? I’m gonna make one :smiley:

2 Likes

Umm idk I made something… (in hindsight it was not a 10 minute job)

broken_image_icon.zip (1.5 KB)
Here’s the .svg if it’s going to be of any use :sweat_smile:

5 Likes

Comes across as an aggressive rebuttal to an accusation no one made.
This is an international community, and there are many non-native English speakers here. Everyone is welcome, regardless of their English-speaking level.
There are certainly cultural differences in language, and perhaps many English speakers are more sensitive to impoliteness than in your native language. But if you’re getting feedback from multiple people that your tone is rude, then “sorry, not sorry” isn’t going to help matters.

Nothing wrong with speaking your mind, even being blunt, as long as it’s not rude. If you want action, then you need to communicate in a way that makes people want to help you.

4 Likes

A new icon would have to be B/W only, and small (so it can be stored in place of the current icon), unless you also want to implement the code to load the external image.

(To be precise: the current icon for this is a 20×27 bit image, encoded as a linear array using only two pixel values (“__” and “XX”). If you want to change the image without changing the code handling it, you will have to respect that format).

I wonder whether something like that could be implemented? With some simplifications it seems doable.


Hmm would this work…?

Or maybe this

So much code is changed daily in darktable, it makes no sense to retain this old and honestly ridiculous limitation.

I assume ‘Confused John Travolta’ is off the cards?

6 Likes

Option no 2 would have my vote :+1: .

Though I agree, a proper solution with an vector image would be the better option.

1 Like

Only if animated and only on easter sunday.

2 Likes

Yeah, the 20×27 feels like a placeholder for a proper icon implementation.

I honestly don’t feel like converting it to text yet, unless people somehow agree that it’s staying in this implementation…

A further updated version to have a different alignment of the crossing line

To me this is a no go. It is hard to figure out what it is.

To me a simple X with a border around it would be the easiest.

1 Like

Wait, really? Surely it’s similar enough to the broken image icon that’s common to see, no?

Well, if that’s the case, I’d suggest to change the implementation to an actual high-res SVG icon, something like I made earlier

1 Like

How about a white question mark on a black background?

Thats actually already reserved for “unsupported image”

1 Like

Source

3 Likes

This is all simply crazy :slight_smile:

I personally dont give a shit about hat icon looks like, almost never see it anyway.

If i would - as you @johans3 do - i would try to get that “fixed”. Get a github account and open a PR. That’s the way it works. Just talking here is a waste of time, reading and commenting certainly takes more time. Plus - you would be part of the community, not a passive bystander.

You offer no way to get in/out in this graph and thus there is no chance to get it into dt :slight_smile:

1 Like