I use the simple tab when I am working through someone else’s development. It’s the only way to exactly match their curve.
1 Like
The advanced UI can’t be mouse-wheeled.
It just results in switching tabs.
Can sliders be turned 90° ccw?
So the slider from the simple and advanced tab match?
And have a histogram underlayed?
And a line overlayed?
The only thing an advanced simple tab would lose is the ability to drag-shape the curve, which is nice when using a graphics pen but since the rest of the ui is rather touch-unfriendly I never was able to work with the pen – although it is my preferred interface for graphics editing.
I don’t know how many people are using drag-shaping to adjust the points and how important that atypical UI mode is in the grand scheme of things. The other tools, that look alike, e.g. contrast equalizer do not have that mode and work differently altogether. I’d rather unify the behaviour of these tools instead of having specialized inconsistencies because of historical reasons.
I do that all the time. What OS?
Linux, the debian flavour.
And you can mouse-wheel the values with the cursor at that position? Nice.
I have to click-hold-drag to change them.
Have you changed mouse wheel behaviour in preferences? If you have, you probably need to hold down ctrl.
I don’t think I’ve ever been able to scroll to move the nodes in this view…
And haven’t changed any relevant setting AFAIK
Of course, I can scroll with the cursor over the image, which works very well, but it’s not what @grubernd was referring to, as I understood it.
As @123sg said …
No modifier (combo) allows me to mouse-wheel the “knobs” on the advanced panel directly.
And I am neither aware of any changes in the prefs nor could I see anything that would even hint at such a behaviour change.
Ok, but no. That just switches between scrolling either of the tools panel up-down or regular sliders left-right. It does nothing with the control-knobs inside the advanced panel. Are we sure we are talking about the same thing?
Yes, but now that I’ve had a chance to try it, I realise that I was imagining things when I thought the wheel worked for me in the advanced tab.
2 Likes
Like the general idea but I adjust curve smoothing fairly regularly I would not vote to hide that in the collapsible.
I tested a few iterations but finally settled in the simplest of the option of just coping the two slider into the advance tab like this:
I spent some time editing the masking tab, but in the end I think we should leave it as it is today. Why? Sometimes the histogram view did not seem to be easy enough to see the tail ends. and the current mask histogram / bar draw helps in seeing it. Since I think the bar draw should stay, then I think the sliders should stay there too.
No other changes and unless there is any strong opinion, I will push a RFC PR this weekend for 4.8
10 Likes
This is my feeling as well. I don’t often retweak the mask after I’ve set it once.
Thanks for your excellent work. I feel this is an ideal solution which allows current users to use the module how they are used to using it or now with the improved option of sliders under the histogram.
Yes, also in my own experience this could be the best option.
I use tone equaliser very intensively and have indeed only missed these two sliders in the advanced tab. They are essential for adjusting the mask quickly. Everything else is used much less frequently and if necessary you have the appropriate tab for it.
Thanks for your effort!
I just set up a pair of shortcuts so I can adjust them with the mouse wheel; but I also agree having them under the histogram is the best solution. Having the pickers there would be nice, too.
Something that does not cause problems in practice, but I have been wondering about anyway: why does clicking the pickers repeatedly often result in slightly different values? The pickers are supposed to work on the module’s unchanging input, right?
Do you in that case click on the exact same spot?
if you move even slightly, you’ll probably get a different pixel, and there’s always some noise or very fine detail.
And if you are zoomed out, you also have interpolation between pixels, which can lead to slight different values with very minute changes in sampling position.
It would be great if the pickers actually worked correctly so that histogram was central and spread to the max.
1 Like
I thought the clickers referred to the magic wands in the masking tab
1 Like
@Terry
You don’t always want it centered anyway.
I don’t remember anyone mentioning the shortcuts for changing exposure and contrast compensation: ctrl left and right and ctrl up and down. They work in the advanced tab.
1 Like