siril 1.1.0 (development): live stack question

Software Siril
5

That’s why I convert them to fit; but I’ll put the cr2 files outside the working directory so that the working directory only contains fit files at any given moment.

6

When not putting cr2 files in the siril working directory (as set in the gui), I get this in the log when starting livestack:

Reading FITS: file siril_master_dark.fit, 1 layer(s), 5496x3670 pixels
log: Reading FITS: file siril_master_flat.fit, 1 layer(s), 5496x3670 pixels
log: Normalisation value auto evaluated: 0.007
log: 80364 corrected pixels (0 + 80364)
log: Preprocessing is ready

But the livestack popup still reports it cannot open the fit files as they arrive in the working direcotry

7

that’s strange, maybe it’s broken indeed.

yes, if you build with autotools add --enable-debug, with meson I don’t remember… This will add debug messages to stdout, so you need to start siril from a console to see them.

8

meson _build -Db_sanitize=address -Dcriterion=true -Dlibconfig=true --buildtype debug

9

so it’s --buildtype debug I guess

10

Hello,

I executed:

meson _build -Db_sanitize=address -Dcriterion=true -Dlibconfig=true --buildtype debug

And I got an error for a dependency with criterion:

meson.build:348:2: ERROR: Dependency "criterion" not found, tried pkgconfig, framework and cmake

So I executed:

brew install criterion

Then executed again:

meson _build -Db_sanitize=address -Dcriterion=true -Dlibconfig=true --buildtype debug

This time it succeeded.
Then executed:

cd _build
ninja

And I got following error:

[250/278] Linking target src/tests/stacking_blocks_test
FAILED: src/tests/stacking_blocks_test 
...
ld: unknown option: --unresolved-symbols=ignore-all
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[255/278] Compiling C object src/tests/imoper_test.p/imoper_test.c.o
ninja: build stopped: subcommand failed.

AstroRookie

11

Hello,

I’ve rebuild without the -D options as follows (as previously it had worked without it):

meson _build --buildtype debug

I now get some more logging, but still no indication as for what reason it cannot open the files that arrive in the working directory, log extract:

OMP: Info #276: omp_set_nested routine deprecated, please use omp_set_max_active_levels instead.
OMP: Info #276: omp_get_nested routine deprecated, please use omp_get_max_active_levels instead.
scripts: Error opening directory “/Users/geert/.siril/scripts”: No such file or directory
log: Welcome to siril v1.1.0
log: Supported file types: BMP images, PIC images (IRIS), PGM and PPM binary images, RAW images, FITS-CFA images, Films, SER sequences, TIFF images
, JPG images, PNG images, HEIF images.
read 93 keys from key file
log: Setting CWD (Current Working Directory) to '/Volumes/Samsung_T5/astrophotography/test_eaa/siril_stack'
log: Parallel processing enabled: using 4 logical processors.
Successfully loaded '/usr/local/share/siril/siril.css'
Successfully loaded '/usr/local/share/siril/siril3.glade'
HD AutoStretch bitdepth: 20
Loading dark theme...
log: Searching scripts in: "/Users/geert/siril/scripts"...
log: Loading script: DSLR_make_bias
log: Loading script: DSLR_preprocessing
log: Loading script: DSLR_preprocessing_basic
log: Loading script: DSLR_preprocessing_Cosmetic
log: Loading script: DSLR_preprocessing_debayer_fit
log: Loading script: DSLR_Preprocessing_Drizzle
log: Loading script: DSLR_preprocessing_Drizzle_Cosmetic
log: Loading script: DSLR_preprocessing_fit
log: Loading script: DSLR_preprocessing_nina
log: Loading script: DSLR_Preprocessing_NoConvert_NoFlat
log: Loading script: DSLR_Preprocessing_NoDark
log: Loading script: DSLR_Preprocessing_NoFlat
log: Loading script: DSLR_Preprocessing_NoFlat_NoDark
log: Loading script: DSLR_Preprocessing_NoFlat_NoDark_NoBias
log: Loading script: live_stack
log: Searching scripts in: "/usr/local/share/siril/scripts"...
log: Loading script: Mono_Preprocessing
log: Loading script: OSC_Extract_Ha
log: Loading script: OSC_Extract_HaOIII
log: Loading script: OSC_Preprocessing
log: Loading script: OSC_Preprocessing_WithDrizzle
saving ini file /Users/geert/.config/siril/config.ini
log: Loading registration method: One Star Registration (deep-sky)
log: Loading registration method: Two or Three Stars Registration (deep-sky)
log: Loading registration method: Global Star Alignment (deep-sky)
log: Loading registration method: Two-Pass Global Star Alignment (deep-sky)
log: Loading registration method: Image Pattern Alignment (planetary - full disk)
log: Loading registration method: KOMBAT (planetary surfaces or full disk)
log: Loading registration method: Comet/Asteroid Registration
log: Loading registration method: Apply Existing Registration
saving ini file /Users/geert/.config/siril/config.ini
saving ini file /Users/geert/.config/siril/config.ini
log: Default FITS extension is set to .fit
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
found reference HDU 5496x3670x2 (-32)
found 1 images in the FITS sequence
setting run 0 to the processing thread
setting run 0 to the processing thread
found reference HDU 5496x3670x2 (-32)
found 1 images in the FITS sequence
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
found reference HDU 5496x3670x2 (-32)
found 1 images in the FITS sequence
setting run 0 to the processing thread
setting run 0 to the processing thread
found reference HDU 5496x3670x2 (-32)
found 1 images in the FITS sequence
setting run 0 to the processing thread
setting run 0 to the processing thread
found reference HDU 5496x3670x2 (-32)
found 1 images in the FITS sequence
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
setting run 0 to the processing thread
found reference HDU 5496x3670x2 (-32)
found 1 images in the FITS sequence
setting run 0 to the processing thread
setting run 0 to the processing thread
found reference HDU 5496x3670x2 (-32)
found 1 images in the FITS sequence
log: Reading FITS: file siril_master_dark.fit, 1 layer(s), 5496x3670 pixels
log: Reading FITS: file siril_master_flat.fit, 1 layer(s), 5496x3670 pixels
Guessed pattern: #2 (GBRG)
coeff1: 0.48504, coeff2: 0.68025
log: Normalisation value auto evaluated

Thanks for your support,

AstroRookie

12

yes you didn’t need the other options to meson. The log stops there? That’s strange…
I’ll try to test it soon.

13

Hello Vincent,

as you seemed surprised about this log, I did a new test 'from scratch":

  • start with an empty working directory
  • start siril gui
  • set calibration frames in pre-process tab
  • start livestack
  • move a file ll_00001.fit into the working directory
    Result:
  • log does not show any thing new
  • but in the console (which I didn’t see in my previous tests) the following was reported:
...
08:22:31: Default FITS extension is set to .fit
08:26:53: Setting CWD (Current Working Directory) to '/Volumes/Samsung_T5/astrophotography/test_eaa/siril_stack'
08:27:19: Reading FITS: file siril_master_dark.fit, 1 layer(s), 5496x3670 pixels
08:27:19: Reading FITS: file siril_master_flat.fit, 1 layer(s), 5496x3670 pixels
08:27:19: Normalisation value auto evaluated: 0.007
08:27:20: 80364 corrected pixels (0 + 80364)
08:27:20: Preprocessing is ready
08:28:09: File not supported for live stacking: ._ll_00001.fit  <---
08:30:23: Stopping live stacking engine...

I renamed the file ll_00001.fit to test_001.fit and re-executed the test, this time no “File not supported” in the console.

Fyi, the file can be opened via the gui without any problem, from the console:

08:55:10: Reading FITS: file test_001.fit, 3 layer(s), 5496x3670 pixels

AstroRookie

14

Hello,

I did an additional test using the gui console with the commands “start_ls -dark=… -flat=…” and then an additional “livestack filename” for every file added in the directory.
That works, but there are error messages in the preprocessing step

...
09:26:01: Reading FITS: file live_stack_00002.fit, 3 layer(s), 5496x3670 pixels
09:27:25: Running command: livestack
09:27:25: Command execution failed with error code: -667.
09:27:26: Reading FITS: file ll_00003.fit, 3 layer(s), 5496x3670 pixels
09:27:26: Images must have same dimensions. <---
09:27:26: preprocessing failed
09:27:26: calibration and demosaicing: 559.15 ms.
...

Kind regards,

AstroRookie

15

This is an error. If you use already demosaiced images you cannot preprocess them.

16

Hello lock042,
duly noted; I converted my raw files again without -debayer.

  • Test from gui livestack button: still failed with error message:
18:27:00: File not supported for live stacking: ._ll_00001.fit
  • Test from gui via console command now runs ok
    Thanks.
    AstroRookie
17

Maybe it doesn’t like this file naming scheme starting with a dot… I don’t know why it would fail with GUI and not with CLI.

18

Hello Vincent,
the file is called “ll_00001.fit”, it’s in the error message that it gives the file name starting with a dot.
I did do a ls -al to see if there actually was a ._ll_00001.fit file but there wasn’t.
I also tried with file names like test_0001.fit, but that did not change any thing.

Kind regards,

AstroRookie

19

@vinvin
Hello Vincent,
sorry for the late reaction, but for your information as I have been fiddling around with live stacking, while making a python script that monitors a directory I noticed that in OS X at some point a file name appears with a “._”(dot underscore) prepended.
Having googled around this seems to be “normal” on OS X (see this stackoverflow issue).
So I suspect the same thing is happening in siril livestacking.c
Kind regards,
astrorookie

20

maybe we just need to ignore hidden files in this process then

21

I’ve created an issue in our system to not forget this. I think it’s simple enough that we can do it for next big 1.2 release. Thank you

22

@vinvin

Hello Vincent,
I installed siril 1.1.0 from sources on a linux box.
I got the same behaviour as on my Mac.
I had a look into src/livestacking/livestacking.c and I think in function “file_changed”, the test has to be inverted:

if (!wait_for_file_to_be_written(filename)) {
					gchar *str = g_strdup_printf(_("Could not open file: %s"), filename);
					livestacking_display(str, TRUE);
					return;
				}

With this change livestacking is executed, before it issued the message “Could not open file: …” for each file that was added, and no stacking was done.

Kind regards,

astrorookie

23

Sorry for the delay, I am finally able to confirm the issue you were seeing, “Could not open file”, was there since August 23.
This was easy to fix but due to many changes in Siril’s core since the introduction of live stacking, live stacking is broken in at least another place.
I will try to fix it soon and improve the feature as much as I can in the coming weeks.

24

Live stacking is back in working condition, with a few new features: shift-only registration, displaying processing time, not starting directly on window open, allowing 16 bits processing (the default).