I still do. I’m a Serial guy, in a Serial world.
1 Like
but wait are we talking about the “tweak” tab or about the “pipeline config” tab? the latter i tend to agree it’s not really needed any more. there are one or two things in it that i’ll need to port away (temporarily disable button, go to node editor view, …?). also deleted code is good code…
if hardly anyone uses it anymore, i don’t see the need to keep it !
I have a question about nodes editor and the default pipeline defined in the default-darkroom.i-raw (or others). I try to modify the default pipeline to insert a mask and it works fine. The question is about the position of the different nodes in the windows of the nodes editor. Is there a file where are described the position of the different nodes for the default pipeline ?
Perhaps like the file generated for each picture in the repertory .config/vkdt/nodes ?
ex with th file 0944b2f5004a56.dat
i-raw:main:22.1549:410.6
denoise::139.775:413.6
hilite::247.395:416.6
demosaic::334.015:416.6
colour::863.355:432.6
filmcurv::1372.07:682.6
etc…
display:hist:1238.73:990.6
display:main:1778.31:858.327
display:dspy:1656.63:571.827
What is the precise meaning of these numbers ?
Thanks !
yes, you found the files. the hash refers to the .cfg it belongs to (i think it hashes the file name). each line contains an entry about one module:instance and stores two numbers (2d coordinate in editor space).
the initial layout of the nodes is silly and could be improved a lot with medium effort i think. it’s defined here: vkdt/render_nodes.cc at master · hanatos/vkdt · GitHub i.e. all go into the same line (y-coord) and are ordered from left to right as they come up in the list.
in general 2d layouts of graphs is quite a can of worms though, so the one-liner above seemed like an appropriate first trade off.
simply (optionally) adding a default node coordinate file along with the default graph configuration file as you are proposing sounds like a good solution to me.
I looked at the code which I can only read a little. I’m not a computer scientist at all but for C I had a little fun with arduino (for a specialist my code is really ugly). And obviously I don’t know the Imgui environment at all.
When increasing the number of nodes in the default-darkroom.i-xxx files, it would indeed be better to be able to initialize the precise position of the nodes. Otherwise it is necessary for each new retouched image to move each of the nodes.
It’s the same thing when we duplicate an image:
oh but why are these all in the same spot? usually they are stringed up in a line if you hadn’t opened the graph before.
…aaand it’s gone. everybody please complain if something went missing.
yer talkin about “duplicate graph connection functionality”… ??
Or the hotkey thing?
yes, duplicate graph connection. now darkroom mode is tweaking parameters and node editor is changing topology of the graph/linearised pipeline. i kinda like this separation of concerns. maybe some common/simple things could have shortcuts in darkroom mode (removing a module? quickly inserting one between two others? though in a graph that’s not always same easy/well defined with multiple inputs and outputs).
It happens when i duplicate a picture, when i reset history stack or when i do copy/paste the history stack. I don’t know why and it seems not to be systematic.
An example:
a picture :
and its node organisation:
I duplicate the picture:
an i open the node editor for the second picture:
i duplicate the second picture :
and i open the node editor for the third picture:
Thanks !
I try to do it you have said, but i don’t succeed. For me it seems that the default.i-raw.dat is never copied in the dat file of the picture (if i do it manually, it’s good). Some body other perhaps has succeed ?
not sure i parse your response here… but the default file is never copied into the existing position file of your graph. it will only be used in case there is no custom .dat file for your image. i suppose resetting the history could also delete the node positions (it does currently not).