applying a style via a shortcut loses the history on undo

Software darktable
1

Before I raise an issue on github can someone try and reproduce this issue please ?

I cannot see an obvious open issue related to this.

Background
I have 3 styles that apply a red, green or blue B&W filter via a new instance of the colour calibration module.

I’ve added shortcuts (shift R, G, B) so I can quickly cycle through the filters to see which is the best filter for that particular image.

If I apply a style via the shortcut then undo the change, it loses the entire history stack.

I’m unsure when I first noticed the issue as I’ve only been using these shortcuts for the last few weeks.

Latest master 3.7.0~git1668.33e0bc3087-1

[edit - Ubuntu 20.04]

Minimal steps to reproduce

  1. Open an unprocessed image.
  2. There are 11 items in the history stack - assuming scene referred and modern chromatic adaptation.
  3. Normally I would apply lens correction, adjust the exposure etc but I’ve left these out.
  4. Shift + B to apply the blue B&W filter [it doesn’t matter which shortcut you use].

History
image

  1. Use control + z to undo the last step reverts to 8 items in the history stack i.e. not the original 11 nor one step back.
    image

I would expect it to undo the last action.

Additional points
Using redo via control + y works as expected i.e. it gets me back to the point before the undo so 12 items in the history stack.

The issue isn’t related to one image as it occurs on a play raw file by someone else.

On resetting the history stack from within darkroom it reverts back to the original 11 items in the history stack.

If I manually apply the style via the quick access menu (lower left in darkroom) undo works as expected.

2

Hi @Phil_Smith,

I tried to verify using the very latest dt-git — but it seg faulted in an unexpected (!) way. I have just filed it on GitHub. Do not know if this has any relevance to your problem, though…

Have fun!
Claes in Lund, Sweden

3

Seems to be working fine…on windows…few day old build…

image

4

Thanks Todd, I’ve edited my post to add that I’m using Ubuntu.

5

Which version of the style are you applying? You can either append it to your history or start all the way over with the history stack.

6

I thought append or start over was only an option from the lighttable ?

I apply the style from the darkroom and it has to be append as the style only contains the colour calibration module and when I apply it all my previous history remain there. The issue is when I undo the change.

7

@Phil_Smith The seg fault I found is now fixed in present master
(darktable-git 94b4d88). Did it take care of your problem, too?

Have fun!
Claes in Lund, Sweden

8

I’ve updated to 3.7.0~git1681.cda5c957f0-1, which is the latest via OBS, and I still have the issue.

9

@Phil_Smith I may have misunderstood your steps — please clarify:
You wrote “applying a style”. Does this mean that you have saved your action as a dtstyle, i.e. one dtstyle per “filter” (which you invoke via a shortcut)?
Or are you talking about applying a preset (which you invoke via a shortcut)?

Re “latest” version – dt-git presently is at #1685.
Will change in about seven minutes time, I presume,
things are hectic now, being so close to The Day.

Have fun!
Claes in Lund, Sweden

10

Yes it’s a dtstyle and there is one dtstyle per filter.

I’ve attached the style for the blue filter.

B&W filter blue.dtstyle (572 Bytes)

I’ve updated to 3.7.0~git1691.3513008bfc-1 and I still have the issue.

11

Bingo! Thanks for sending the dtstyle — now I understand what you mean,
and yes, I can reproduce the peculiarity using the latest dt-git.

If you start darktable from the command line, you will see quite a few protests after having tried to undo a shortcut/dtstyle using ctrl-z.

Please report it on GitHub.

Have fun!
Claes in Lund, Sweden

1 Like
12

Thanks for confirming and especially the tip about running darktable via the command line.

Issue now raised : https://github.com/darktable-org/darktable/issues/10639

1 Like
13

Morning, @Phil_Smith,

Two small clues found :-),
see your entry at GitHub.

Have fun,
Claes in Lund, Sweden

1 Like