here is an example of the limit of the spot removal tool. all spots on the negative film (dust) can be removed if they are relatively small, but for example, that scratch on the film in the middle of the image is laborious to remove with the shape of the circle.
I can have a look once your spot removal branch will be merged.
However this is a clone brush tool, removing scratch might need another algorithm without source image requirement.
1 Like
@agriggio Since this thread is about feature request, and since ART has masks, this would be super cool 
! I think it’s doable if you have High Pass Filter and Sharpening algorithm. I tested the technic in Gimp, it blew me away how simple it was.
1 Like
Thinking of it, you might prefer “Cloning” tool’s name instead of “Spot removal”, if you want to prepare for an evolution of that tool in something more generic using the cloning algorithm.
Hello Hombre (long time! 
), rectangular, or circulair or elliptic… But using the brush mask tool (in combination with the area mask, or not) allows you to create any form, even free-forms, isn’t it?
I’ve started generalising it a bit, by adding a detail preservation slider. it’s stil quite primitive, but I hope to make it better eventually…
split-frequency skin retouching within ART would be insane!
Hello,
I would like to congratulate you for the work accomplished, I am a happy user, without your software I would not have switched to linux, that’s what I missed, more “photo” than rawtherappee, and I had never managed to get used to Darktable.
A little wish, my imac starting to get older, do you plan to take care of the processing using the GPU?
1 Like
I in no way wanted to suggest that ART is not a very capable program, it is! Very very much so.
Is that negative clarity on a skintone mask?
How did you do that?
local contrast, smoothing, and a couple of removed spots (for the latter, you need the spotremoval branch). Here’s the arp:
Mairi.ORF.arp (40.8 KB)
2 Likes
That’s not how I took it, no worries! 
I just wanted to point out what is possible with the tools that are already there, not to suggest that they are perfect (far from it), but to make sure that people are aware of them…
2 Likes
That’s what I do too
hi @lepolau,
and thanks for the feedback!
honestly, the last dedicated graphics card I had was a mobility radeon in 2001 I think
after that, only integrated cards. I have no experience with GPU programming, I’m afraid I can’t be of help.
note though that my home machine is a 2009 ThinkPad, and I find art still usable, especially if you export with the fast pipeline (which is what I always do)
Hello and thank you for your prompt response.
Yes I do quibble a little but I’m doing a lot of photos and videos at the moment with the confinement, and when I see the time savings in video processing I thought it could be interesting. My computer is from the end of 2013 so it’s still fine. Before rawtherapee then art, I used dxo photolab and the gain with gpu processing was not negligible but not essential, especially if it takes a lot of time for programming at the expense of more useful functions. Unfortunately I don’t have the knowledge to help you otherwise it would have been with joy. Thanks again.
fyi, darktable can take advantage of fast GPUs, you can consider that
FYI, it’s merged now
I have also ported the healing algorithm from GIMP, which is used for spots with “detail” set to 4. I’d appreciate some feedback!
3 Likes
Sounds very interesting! Gonna check soon.
Wow, I was not expecting a spot removal tool to appear within 10 days of it being raised as a discussion. Thanks so much and great work!
I’ve just had a little play with it and it seems to work great on small spots. I’ve not tried it on anything large like a scratch yet, but it is called “spot removal”, so maybe I shouldn’t push it too far 
Is it cloning or healing? It seems quite sensitive to differences in shade, so I’m assuming it’s cloning and you need to choose your source points well.
1 Like