Thanks for the improvements:
Checkboxes to turn local adjustments on and off
Can now place vignette filter where you want.
All the work is much appreciated.
https://keybase.pub/gaaned92/ART-W64NightlyBuilds/ART_master_0.3-75-ge93684c93_W64_generic_200104.7z uploaded
Thanks. I’ve just pushed some changes to the exiftool fallback mechanism. Can you try again and see whether it works? It seems to be fine here now.
Interesting, I’m thinking of metadata right now, for rawproc. Probably going to use exiv2, but ingesting an exiftool JSON string is also attractive. Curious, what foible of exiv2 is compelling you to use exiftool as a fallback?
exiv2 currently doesn’t support Canon CR3. So I’m using exiftool to parse CR3 files, export the metadata to xmp, and then import the xmp in Exiv2, so that I can use just the exiv2 API in the rest of the code.
0.3-79-g60f8b80d3
It doesn’t seem to completely work.
What I did ;
- verify in options that exiftool command =exiftool.exe
- verify that exiftool.exe is in the same dir as camconst.json
- set ART in verbose mode
When I open canon.CR3 in the editor:
Metadata for D:\PHOTOS\test2\CR3\canon.CR3 found in cache
Unable to load DCP profile ‘D:\PHOTOS\test2\CR3\canon.CR3’ !Metadata for D:\PHOTOS\test2\CR3\canon.CR3 found in cache
found matching profile ${U}\basic
Metadata for D:\PHOTOS\test2\CR3\canon.CR3 found in cache
Can’t load DCP profile ‘(cameraICC)’!
Canon EOS M50.badpixels not found
Preprocessing: 356252 usec
Demosaic Bayer image n.1 using method: rcdvng4
Demosaicing Bayer data: rcdvng4 - 918721 usec
Applying Highlight Recovery: Color propagation…
chmax[0] : 22200.851562 clmax[0] : 61259.199219 ratio[0] : 0.362408
chmax[1] : 28162.652344 clmax[1] : 45120.453125 ratio[1] : 0.624166
chmax[2] : 43224.304688 clmax[2] : 65535.000000 ratio[2] : 0.659561
correction factor[0] : 1.000000
correction factor[1] : 1.000000
correction factor[2] : 1.000000
Applying white balance, color correction & sRBG conversion…
options saved to C:\Users\Andre\AppData\Local\ART5-dev\options
saving dynamic profiles…
Saved 1 dynamic profile rules
Canon EOS M50.badpixels not found
Preprocessing: 330750 usec
Demosaic Bayer image n.1 using method: rcdvng4
Demosaicing Bayer data: rcdvng4 - 843821 usec
Applying Highlight Recovery: Color propagation…
chmax[0] : 22200.851562 clmax[0] : 61259.199219 ratio[0] : 0.362408
chmax[1] : 28162.652344 clmax[1] : 45120.453125 ratio[1] : 0.624166
chmax[2] : 43224.304688 clmax[2] : 65535.000000 ratio[2] : 0.659561
correction factor[0] : 1.000000
correction factor[1] : 1.000000
correction factor[2] : 1.000000
Applying white balance, color correction & sRBG conversion…
Canon EOS M50.badpixels not found
Preprocessing: 373829 usec
Demosaic Bayer image n.1 using method: rcdvng4
Demosaicing Bayer data: rcdvng4 - 866630 usec
Applying Highlight Recovery: Color propagation…
chmax[0] : 22200.851562 clmax[0] : 61259.199219 ratio[0] : 0.362408
chmax[1] : 28162.652344 clmax[1] : 45120.453125 ratio[1] : 0.624166
chmax[2] : 43224.304688 clmax[2] : 65535.000000 ratio[2] : 0.659561
correction factor[0] : 1.000000
correction factor[1] : 1.000000
correction factor[2] : 1.000000
Applying white balance, color correction & sRBG conversion…
Applying white balance, color correction & sRBG conversion…
ART knows it is a M50,but nothing appears in the info panel in editor and the meta tab is empty
how did you compile exiv2?
It is a mingw64 package
mingw-w64-x86_64-exiv2 0.27.2-2 [installé]
it’s strange that exiftool is not even tried apparently, at least judging from the log. I’ll take a closer look…
ART_master_1.0-RC1-1-gfea641592_W64_SSE4_200105.7z
uploaded at
https://keybase.pub/gaaned92/ART-W64NightlyBuilds/
I tried the installer and it is OK.
Did you succed to understand why exiftool is not called? I replaced exiftool by a programm that should open a window and nothing happens.
I think there’s something wrong with the version of exiv2 you are using. If you try my installer, everything works fine… (or at least it works here). It also works if I manually replace exiv2.dll in your version with the one I compiled myself. Though I have no idea why it doesn’t work :-/
Your libexiv2.dll is much larger than the one in MSYS2. Perhaps there are missing build options.
At least I have a hack to get it work.
When I have time I will build exiv2
Your lensfun database is not up to date. time stamp from my last update is 1577948414
thanks, I’ll try to update before the next RC
In the last few builds, I’m seeing hardly any difference between the two extremes (-100 to +100) of the Blacks slider in the Tone Equalizer tool. Is this as designed or a bug? I seem to remember there was much more latitude as there is with the other sliders.
iirc nothing has changed in recent builds. do you have an example raw for which you are seeing a different behaviour?
This is one shot of a series I’m making into a panorama. There seems to be very subtle changes when I move the Blacks slider. Maybe it’s just that there’s a narrow dynamic range, but I would have expected to see more by adjusting this slider.
IMG_8117.CR2 (25.4 MB)
Hi,
It’s more that there are no “blacks” in the picture (i.e. levels of lightness that fall in what ART calls “blacks”) – just look at the histogram. If you tweak the exposure compensation so that there is something in the blacks, the slider works as expected:
Ok thanks, so that was my suspicion. So if I wanted to extend the dynamic range and push the blacks and whites to just before they clip (before making further tonal adjustments), am I right in that only the Tone Curves tool would do this (short of using several tools)?
I’m not familiar with the Log Encoding tool, so maybe that does it?
Would it make sense to make the Dynamic Range Compression tool also work inversely to also extend the dynamic range?
Log encoding can definitely do that, but it operates towards the end of the pipeline. The tone curve can also do that, but that comes even later than log encoding. If you want to stretch the histogram early on, have a look at the color correction module:
1 Like
Thanks for that, I would never have thought of using that module in the Local Editing group, and tbh I don’t really know what Slope, Offset and Power mean.
So, is it fairly typical of imaging software to put those types of tonal adjustments (tone curve/log encoding) towards the end of the pipeline? I’m not sure how important it is for the resulting image, but It’s often one of first things I like to do when processing. To me, it’s all part of getting the correct exposure, before moving on to colour and details.
Does it matter if I use Tone Curve and Log Encoding early on? If I use them to set my black and white points and then use the Tone Equalizer module for tweaking, is this a valid workflow?