I just compiled ART (version 1.6.1-17-g42d20d70b). Now all my photos are magenta!
Hi,
what OS? which compiler? which compilation flags?
Thanks!
Version: 1.6.1-17-g42d20d70b
Branch: master
Commit: 42d20d70b
Commit date: 2020-12-04
Compiler: cc 9.3.0
Processor: x86_64
System: Linux
Bit depth: 64 bits
Gtkmm: V3.22.2
Lensfun: V0.3.2.0
Exiv2: V0.25
Build type: release
Build flags: -std=c++11 -march=native -Werror=unused-label -fno-math-errno -Wall -Wuninitialized -Wno-deprecated-declarations -Wno-unused-result -fopenmp -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize
Link flags: -march=native
OpenMP support: ON
MMAP support: OFF
Build OS: Linux
Build date: 2020-12-05T09:41:56Z
Thanks. I have no idea what is going on… can you try running git bisect and try to track down the commit that caused this?
ehm… maybe, if you can explain exactly how it works… usually, I compile ART with the script build-art, so I’m not an expert about compiling 
I’m not really the best person, as I don’t understand git myself – I try to avoid it as much as possible 
But here’s the first hit from searching for “git bisect tutorial”, hopefully it can help…
done.
1.6.1-13-gbc87e48a9 is the last working version
sysop@tc605:~/programs/code-art$ git bisect good 1.6
Bisecting: 15 revisions left to test after this (roughly 4 steps)
[a2cc73f5f4769ad9ad2daaea9b5adbe7b158ad9e] improved metadata extraction from ancient Kodak DCS4xx cameras
sysop@tc605:~/programs/code-art$ git bisect good 1.6.1
Bisecting: 8 revisions left to test after this (roughly 3 steps)
[d6fc003e994076b743d025a1ea3951fee4b60d46] denoise: remove dependence of quality on number of threads set in options
sysop@tc605:~/programs/code-art$ git bisect good 1.6.1-8-gd6fc003e9
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[1a4cdaffe72bbc8b02351198102728c54809f625] dcraw: added support for 16-bit compressed fuji files
sysop@tc605:~/programs/code-art$ git bisect good 1.6.1-12-g1a4cdaffe
Bisecting: 2 revisions left to test after this (roughly 1 step)
[c8df72cfd2b0c15fda1f5d5c3c5364161daff1bc] camconst: support for multiple image sizes in raw_crop and masked_areas
sysop@tc605:~/programs/code-art$ git bisect bad 1.6.1-14-gc8df72cfd
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[bc87e48a9ebcf29f82a3eeeb2d125ec13fa8509c] started adding support for Fujifilm GFX 100 pixel shift
sysop@tc605:~/programs/code-art$ git bisect good 1.6.1-13-gbc87e48a9
c8df72cfd2b0c15fda1f5d5c3c5364161daff1bc is the first bad commit
commit c8df72cfd2b0c15fda1f5d5c3c5364161daff1bc
Author: Alberto Griggio <agriggio@users.noreply.github.com>
Date: Thu Dec 3 08:58:24 2020 +0100
camconst: support for multiple image sizes in raw_crop and masked_areas
This is necessary to properly support extended-resolution pixel-shift, among
other things
rtengine/camconst.cc | 226 +++++++++++++++++++++++++++++++++++--------------
rtengine/camconst.h | 40 +++++----
rtengine/camconst.json | 17 ++++
rtengine/rawimage.cc | 26 ++++--
4 files changed, 215 insertions(+), 94 deletions(-)
can you also share one of your raw files? Thanks!
If it can help 1.6.1-17 ok on W10.
Thanks for the sample – I see it now. I’ll investigate
found it, should be fixed now. Thanks for the help!
2 Likes
Thanks Alberto!