@kofa is this the new branch to build from? GitHub - kofa73/darktable at agx
Holy shit @kofa
I know i am really late to the party (I just grabbed the appimage yesterday) and you are probably desensitized at this point, but this is impressive. Daunting, but impressive!
I was expecting something like sigmoid in terms of controls and (seemingly) functionality. I litterly said “wait…what?!” outloud without meaning to.
I look forward to playing with this, and seriously…kudos!
We almost have to call it kofagx, or something along those lines, for recognition of the attention and effort given.
… Maybe less pharmaceutical.
You could also build the PR from master…
Yes.
Hi @kofa, It’s been a while since we heard from you. How far are we in seeing AgX come into the nightly build in 5.3? - just curious
You can follow the current status of development here.
Yup, I saw that, but I was looking for an answer in English ![]()
Nobody can reliably say today whether and when this PR can be integrated into master. My recommendation would be: let @kofa concentrate on the implementation, not on declarations of how far the implementation has progressed.
I’ve opened the pull request, and received some basic, stylistic comments. I’ve addressed most of them.
Then, a new possibility to refactor / unify code was found (not directly related to agx: conversions between degrees and radians, which are done in many source files). I dealt with that this past weekend; as it affected lots of files, it’s handled as a separate PR (degrees <-> radians conversion clean-up by kofa73 · Pull Request #19077 · darktable-org/darktable · GitHub, but it’s nothing interesting, just replacing calculations like in_radians = degrees * pi / 180 and in_degrees = radians / pi * 180 with something less error prone and shorter, like in_radians = deg2rad(degrees) and in_degrees = rad2deg(radians)).
Once that 2nd PR is approved and merged, I’ll update the agx code to also use the unified conversion.
If / when further comments are received, I’ll address them.
I’ve only done some small clean-ups; I’ll create a new build refreshed from master soon, but right now one of those clean-ups is slightly misbehaving. ![]()
It’s summertime, and people are on vacation (I will also go soon). But don’t worry, it’s not forgotten.
Well deserved I would think. Enjoy your holiday, may the light be with you. ![]()
The window for merging stuff for 5.4 on master is not yet open. So don’t hold your breath yet !
This wait is gonna be worth it
Another absolute ‘bomb’ that has flown under the radar and hopefully is arriving on the same version as AgX is Capture Sharpening ported over from RT by @\hannoschwalm
Have you some link for that? I missed this development indeed.
Thanx for the link. This reads indeed verrrry nice. Seems like the next release could be a major one
.
All releases are major ones. A lot of time and effort goes into every release.
You are right. That’s why I donate a small amount of money on monthly base. It wasn’t my intent to insult anybody. I know that every developer is contributing it’s own valuable part to make darktable to what it is, one of my most beloved application.
Capture sharpness sounds promising. That and AgX should be a couple of nice improvements to DT.
there’s no donation option for darktable developer in place…