Build broken for xUbuntu 18.04 OBS third party master packages

Hello,

Since sometime ago I used to update Darktable from OBS packages. Today, I wanted to update from 2.7.0 to 3.0.0rc0 to see the new improvements.

Then I visited darktable.orgsnapshots from the master branch → ubuntu → Grab binary packages directly
and I saw that commit hash was different for xUbuntu 18.04.

This package is behind the rest of versions for 5 days.

Looking for some clues, I’ve found failed xUbuntu 18.04 builds in the build service. You can find here its log:

A partial of the log:

...
[  656s] lto1: internal compiler error: in dwarf2out_finish, at dwarf2out.c:29725
[  656s] Please submit a full bug report,
[  656s] with preprocessed source if appropriate.
[  656s] See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions.
[  656s] lto-wrapper: fatal error: /usr/bin/cc returned 1 exit status
[  656s] compilation terminated.
[  656s] /usr/bin/x86_64-linux-gnu-ld: error: lto-wrapper failed
[  656s] collect2: error: ld returned 1 exit status
[  656s] src/CMakeFiles/lib_darktable.dir/build.make:4354: recipe for target 'src/libdarktable.so' failed
[  656s] make[3]: *** [src/libdarktable.so] Error 1
[  656s] make[3]: Leaving directory '/usr/src/packages/BUILD/obj-x86_64-linux-gnu'
[  656s] CMakeFiles/Makefile2:1479: recipe for target 'src/CMakeFiles/lib_darktable.dir/all' failed
[  656s] make[2]: *** [src/CMakeFiles/lib_darktable.dir/all] Error 2
[  656s] Makefile:154: recipe for target 'all' failed
[  656s] make[1]: *** [all] Error 2
[  656s] dh_auto_build: cd obj-x86_64-linux-gnu && make -j8 -O returned exit code 2
[  656s] debian/rules:20: recipe for target 'build' failed
[  656s] make: *** [build] Error 25
[  656s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
[  656s] 
[  656s] lamb14 failed "build darktable.dsc" at Mon Nov 11 21:39:08 UTC 2019.
[  656s] 
[  656s] ### VM INTERACTION START ###
[  659s] [  640.933842] sysrq: SysRq : Power Off
[  659s] [  640.941560] reboot: Power down
[  659s] ### VM INTERACTION END ###
[  659s] 
[  659s] lamb14 failed "build darktable.dsc" at Mon Nov 11 21:39:12 UTC 2019.
[  659s] 

I don’t know who is in charge of these builds, it’s just to notify it.

Thanks,
Rafa

@darix is the maintainer. I’m sure he will fix it as soon as he is able.

1 Like

well I have 2 options now … turn off LTO on all deb based distros or remove 18.04 from the list … I rather lean towards option 2

fwiw: If an app is slow without LTO, it may be a bit faster with LTO, but nothing to write home about. I would turn off LTO…

Before to take any decision.

Do we have statistical data about the usage/downloads of this package?

For me it isn’t a problem to upgrade to 19.10, but for other users it could be a problem or maybe there are no almost others users :man_shrugging:t2:

BTW thanks @darix for the maintenance of the packages :blush:

we dont have download stats on download.opensuse.org

ok turned off LTO for deb based stuff.

Thank you!

As I couldn’t find my 2017(?) LTO benchmark, I added a BENCHFUN to ImageProcessor::normal_pipeline() in RT and took the median of batchprocessing the same Canon 6D CR2 11 times (current dev, default profile, Debian 10 AMD64 VM with 48 cores on idle host, GCC 8.3).

  • -DWITH_LTO=OFF: 3805ms
  • -DWITH_LTO=ON: 3694ms

So that’s a speedup of 1.03.

Best,
Flössie