compile under FC28 ?

Software PhotoFlow
1

Hi,

Trying to compile the stable branch under Fedora 28 and I’m getting the following. Otherwise I’ve installed the development library for gtkmm 3 and it forces me to use/install the 2.4 version.

Building PhotoFlow...
Install PhotoFlow to: /home/cedric/workspace/PhotoFlow/build/Release
Build type: Release
Use VIPS in 
PKG_CONFIG_PATH: 
LD_LIBRARY_PATH: 
-- The CXX compiler identification is GNU 8.1.1
-- The C compiler identification is GNU 8.1.1
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- INSTALL_PREFIX:         /home/cedric/workspace/PhotoFlow/build/Release
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.4.2") 
-- Checking for module 'pugixml'
--   Package 'pugixml', required by 'virtual:world', not found
-- Found Pugixml 1.90
-- Pugixml_INCLUDE_DIRS:         /usr/include
-- Pugixml_LIBRARIES:            /usr/lib64/libpugixml.so
-- Found EXPAT: /usr/lib64/libexpat.so  
-- EXPAT_INCLUDE_DIRS:         /usr/include
-- EXPAT_LIBRARIES:            /usr/lib64/libexpat.so
-- Looking for iconv_open
-- Looking for iconv_open - found
-- Performing Test ICONV_COMPILES
-- Performing Test ICONV_COMPILES - Success
-- Found ICONV: In glibc  
-- Performing Test ICONV_ACCEPTS_NONCONST_INPUT
-- Performing Test ICONV_ACCEPTS_NONCONST_INPUT - Success
-- Performing Test ICONV_ACCEPTS_CONST_INPUT
-- Performing Test ICONV_ACCEPTS_CONST_INPUT - Failed
-- ICONV_INCLUDE_DIRS:         
-- ICONV_LIBRARIES:            
-- Check for LCMS2 availability...
-- Checking for module 'lcms2'
--   Found lcms2, version 2.9
-- LCMS2_INCLUDE_DIRS:         
-- LCMS2_LIBRARIES:            lcms2
-- LCMS2_LIBRARY_DIRS:         
-- Found TIFF: /usr/lib64/libtiff.so (found version "4.0.9") 
-- TIFF_INCLUDE_DIRS:         /usr/include
-- TIFF_LIBRARIES:            /usr/lib64/libtiff.so
-- TIFF_LIBRARY_DIRS:         
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.11") 
-- Found PNG: /usr/lib64/libpng.so (found version "1.6.34") 
-- Found JPEG: /usr/lib64/libjpeg.so  
-- JPEG_INCLUDE_DIRS:         
-- JPEG_LIBRARIES:            /usr/lib64/libjpeg.so
-- JPEG_LIBRARY_DIRS:         
-- Checking for module 'fftw3'
--   Found fftw3, version 3.3.5
-- Checking for module 'libxml-2.0'
--   Found libxml-2.0, version 2.9.7
-- Checking for module 'libexif'
--   Found libexif, version 0.6.21
-- Checking for module 'exiv2>=0.26'
--   Found exiv2, version 0.26
-- EXIV2_FOUND:         1
-- Checking for module 'OpenEXR'
--   Found OpenEXR, version 2.2.0
-- Checking for module 'orc-0.4'
--   Found orc-0.4, version 0.4.28
-- Checking for module 'sigc++-2.0'
--   Found sigc++-2.0, version 2.10.0
-- Checking for module 'pixman-1'
--   Found pixman-1, version 0.34.0
-- Checking for module 'pango'
--   Found pango, version 1.42.1
-- Checking for module 'pangoft2'
--   Found pangoft2, version 1.42.1
-- Checking for module 'glib-2.0'
--   Found glib-2.0, version 2.56.1
-- Checking for module 'gmodule-2.0'
--   Found gmodule-2.0, version 2.56.1
-- Checking for module 'gthread-2.0'
--   Found gthread-2.0, version 2.56.1
-- Checking for module 'gobject-2.0'
--   Found gobject-2.0, version 2.56.1
-- Checking for module 'glibmm-2.4'
--   Found glibmm-2.4, version 2.56.0
-- GLIB_INCLUDE_DIRS:         /usr/include/glib-2.0/usr/lib64/glib-2.0/include
-- GLIB_LIBRARY_DIRS:         
-- Checking for module 'vips>=8.5.1'
--   Found vips, version 8.6.4
-- VIPS_INCLUDE_DIRS:         /usr/include/glib-2.0/usr/lib64/glib-2.0/include/usr/include/libgsf-1/usr/include/libxml2/usr/include/ImageMagick-6/usr/include/orc-0.4/usr/include/OpenEXR/usr/include/libdrm/usr/include/poppler/glib/usr/include/cairo/usr/include/pixman-1/usr/include/freetype2/usr/include/libpng16/usr/include/uuid/usr/include/poppler/usr/include/librsvg-2.0/usr/include/gdk-pixbuf-2.0/usr/include/openslide/usr/include/cfitsio/usr/include/pango-1.0/usr/include/fribidi/usr/include/harfbuzz
-- VIPS_LIBRARY_DIRS:         
-- Checking for module 'gtkmm-2.4'
--   Found gtkmm-2.4, version 2.24.5
-- GTKMM2_FOUND:         1
-- GTKMM3_FOUND:         
-- Found Gettext 
-- Found msgfmt to convert language file. Translation enabled
-- Msgfmt_FOUND:         1
-- Found OpenMP_C: -fopenmp (found version "4.5") 
-- Found OpenMP_CXX: -fopenmp (found version "4.5") 
-- Found OpenMP: TRUE (found version "4.5")  
CMake Warning (dev) in src/CMakeLists.txt:
  A logical block opening on the line

    /home/cedric/workspace/PhotoFlow/src/CMakeLists.txt:131 (if)

  closes on the line

    /home/cedric/workspace/PhotoFlow/src/CMakeLists.txt:134 (endif)

  with mis-matching arguments.
This warning is for project developers.  Use -Wno-dev to suppress it.

BEFORE add_subdirectory(external/rawspeed)
-- Checking for -mtune=generic support
-- Performing Test MTUNEGENERIC
-- Performing Test MTUNEGENERIC - Success
-- Checking for -mtune=generic support - works
-- Checking for -std=c++14 support
-- Performing Test COMPILER_SUPPORTS_CXX14
-- Performing Test COMPILER_SUPPORTS_CXX14 - Success
-- Checking for -std=c++14 support - works
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WALL
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WALL - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WEXTRA
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WEXTRA - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WCAST_QUAL
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WCAST_QUAL - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WEXTRA_SEMI
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WEXTRA_SEMI - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WFORMAT_2
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WFORMAT_2 - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WMISSING_PROTOTYPES
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WMISSING_PROTOTYPES - Failed
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WOLD_STYLE_CASTS
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WOLD_STYLE_CASTS - Failed
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WPOINTER_ARITH
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WPOINTER_ARITH - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WSTRICT_PROTOTYPES
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WSTRICT_PROTOTYPES - Failed
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WTRADITIONAL
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WTRADITIONAL - Failed
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WVLA
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WVLA - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WMISSING_FORMAT_ATTRIBUTE
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WMISSING_FORMAT_ATTRIBUTE - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WSUGGEST_ATTRIBUTE_FORMAT
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WSUGGEST_ATTRIBUTE_FORMAT - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WNO_UNUSED_PARAMETER
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WNO_UNUSED_PARAMETER - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WSTACK_USAGE_4096
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WSTACK_USAGE_4096 - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WFRAME_LARGER_THAN_4096
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WFRAME_LARGER_THAN_4096 - Success
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WLARGER_THAN_32768
-- Performing Test RAWSPEED_HAVE_CXX_FLAG_WLARGER_THAN_32768 - Success
-- Looking for PThreads
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE  
-- Looking for PThreads - found
-- Looking for OpenMP
-- Found OpenMP_C: -fopenmp (found version "4.5") 
-- Found OpenMP_CXX: -fopenmp (found version "4.5") 
-- Looking for OpenMP - found
-- Looking for pugixml
-- Looking for pugixml - found (system)
-- Looking for JPEG
-- Looking for JPEG - found
-- Looking for jpeg_mem_src
-- Looking for jpeg_mem_src - found
-- Looking for ZLIB
-- Looking for C++ include zlib.h
-- Looking for C++ include zlib.h - found
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of uLongf
-- Check size of uLongf - done
-- Looking for Z_OK
-- Looking for Z_OK - found
-- Checking prototype uncompress for HAVE_ZLIB_UNCOMPRESS_PROTOTYPE - True
-- Checking prototype zError for HAVE_ZLIB_ZERROR_PROTOTYPE - True
-- Looking for uncompress
-- Looking for uncompress - found
-- Looking for zError
-- Looking for zError - found
-- Looking for ZLIB - found (system)
-- Looking for malloc
-- Looking for malloc - found
-- Looking for free
-- Looking for free - found
-- Looking for posix_memalign
-- Looking for posix_memalign - found
-- Performing Test HAVE_CXX_THREAD_LOCAL
-- Performing Test HAVE_CXX_THREAD_LOCAL - Success
-- Looking for OpenMP
-- Looking for OpenMP - found
-- The following features have been enabled:

 * PThread-based library threading, used for parallelized image decoding
 * OpenMP-based utilites threading, used for parallelization of utilities only, NOT library!
 * XML reading, used for loading of data/cameras.xml
 * Lossy JPEG decoding, used for DNG Lossy JPEG compression decoding
 * ZLIB decoding, used for DNG Deflate compression decoding

-- The following OPTIONAL packages have been found:

 * EXPAT
 * Gettext
 * Msgfmt
 * OpenMP
   Used for parallelization of tools (NOT library!)
   Used for parallelization of tools (NOT library!)

-- The following RECOMMENDED packages have been found:

 * Threads, POSIX Threads
   Used for parallelization of the library itself

-- The following REQUIRED packages have been found:

 * Iconv
 * TIFF
 * PNG
 * Pugixml (required version >= 1.2), Light-weight, simple and fast XML parser, <http://pugixml.org/>
   Used for loading of data/cameras.xml
 * JPEG, free library for handling the JPEG image data format, implements a JPEG codec
   Used for decoding DNG Lossy JPEG compression
 * ZLIB, software library used for data compression
   Used for decoding DNG Deflate compression

AFTER add_subdirectory(external/rawspeed)
CMAKE_CURRENT_BINARY_DIR: /home/cedric/workspace/PhotoFlow/build/src
-- EXIV2_LIBRARIES: exiv2
-- Using bundled LensFun library
-- Looking for include file regex.h
-- Looking for include file regex.h - found
-- Looking for include file endian.h
-- Looking for include file endian.h - found
HAVE_REGEX_H: 1
-- CMAKE_MODULE_PATH:  /home/cedric/workspace/PhotoFlow/cmake/modules/ /home/cedric/workspace/PhotoFlow/src/external/lensfun/cmake/modules /home/cedric/workspace/PhotoFlow/cmake/modules
HAVE_REGEX_H: 1
-- -------------------------------------------------------------------------------------
-- Building Lensfun 0.3.2.0
-- -------------------------------------------------------------------------------------
-- Build as static library
-- Build type: RELEASE
-- Build doc: OFF
-- Build test suite: OFF
-- Build lenstool: OFF
-- Build with support for SSE: ON
-- Build with support for SSE2: ON
-- Install helper scripts: ON
-- 
Install prefix: /home/cedric/workspace/PhotoFlow/build/Release
-- 
Using: 
-- GLIB2 include dir: 
-- GLIB2 library: 
-- Configuring done
-- Generating done
-- Build files have been written to: /home/cedric/workspace/PhotoFlow/build
/usr/bin/cmake -H/home/cedric/workspace/PhotoFlow -B/home/cedric/workspace/PhotoFlow/build --check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start /home/cedric/workspace/PhotoFlow/build/CMakeFiles /home/cedric/workspace/PhotoFlow/build/CMakeFiles/progress.marks
make -f CMakeFiles/Makefile2 all
make[1]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
make -f po/CMakeFiles/locale_fr.dir/build.make po/CMakeFiles/locale_fr.dir/depend
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
cd /home/cedric/workspace/PhotoFlow/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/cedric/workspace/PhotoFlow /home/cedric/workspace/PhotoFlow/po /home/cedric/workspace/PhotoFlow/build /home/cedric/workspace/PhotoFlow/build/po /home/cedric/workspace/PhotoFlow/build/po/CMakeFiles/locale_fr.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
make -f po/CMakeFiles/locale_fr.dir/build.make po/CMakeFiles/locale_fr.dir/build
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
make[2]: Nothing to be done for 'po/CMakeFiles/locale_fr.dir/build'.
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
[  1%] Built target locale_fr
make -f po/CMakeFiles/locale_de.dir/build.make po/CMakeFiles/locale_de.dir/depend
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
cd /home/cedric/workspace/PhotoFlow/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/cedric/workspace/PhotoFlow /home/cedric/workspace/PhotoFlow/po /home/cedric/workspace/PhotoFlow/build /home/cedric/workspace/PhotoFlow/build/po /home/cedric/workspace/PhotoFlow/build/po/CMakeFiles/locale_de.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
make -f po/CMakeFiles/locale_de.dir/build.make po/CMakeFiles/locale_de.dir/build
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
make[2]: Nothing to be done for 'po/CMakeFiles/locale_de.dir/build'.
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
[  1%] Built target locale_de
make -f po/CMakeFiles/locale_pl.dir/build.make po/CMakeFiles/locale_pl.dir/depend
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
cd /home/cedric/workspace/PhotoFlow/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/cedric/workspace/PhotoFlow /home/cedric/workspace/PhotoFlow/po /home/cedric/workspace/PhotoFlow/build /home/cedric/workspace/PhotoFlow/build/po /home/cedric/workspace/PhotoFlow/build/po/CMakeFiles/locale_pl.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
make -f po/CMakeFiles/locale_pl.dir/build.make po/CMakeFiles/locale_pl.dir/build
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
make[2]: Nothing to be done for 'po/CMakeFiles/locale_pl.dir/build'.
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
[  1%] Built target locale_pl
make -f src/CMakeFiles/gmic_film_cluts_download.dir/build.make src/CMakeFiles/gmic_film_cluts_download.dir/depend
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
cd /home/cedric/workspace/PhotoFlow/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/cedric/workspace/PhotoFlow /home/cedric/workspace/PhotoFlow/src /home/cedric/workspace/PhotoFlow/build /home/cedric/workspace/PhotoFlow/build/src /home/cedric/workspace/PhotoFlow/build/src/CMakeFiles/gmic_film_cluts_download.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
make -f src/CMakeFiles/gmic_film_cluts_download.dir/build.make src/CMakeFiles/gmic_film_cluts_download.dir/build
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
make[2]: Nothing to be done for 'src/CMakeFiles/gmic_film_cluts_download.dir/build'.
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
[  1%] Built target gmic_film_cluts_download
make -f src/external/lensfun/libs/lensfun/CMakeFiles/lensfun.dir/build.make src/external/lensfun/libs/lensfun/CMakeFiles/lensfun.dir/depend
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
cd /home/cedric/workspace/PhotoFlow/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/cedric/workspace/PhotoFlow /home/cedric/workspace/PhotoFlow/src/external/lensfun/libs/lensfun /home/cedric/workspace/PhotoFlow/build /home/cedric/workspace/PhotoFlow/build/src/external/lensfun/libs/lensfun /home/cedric/workspace/PhotoFlow/build/src/external/lensfun/libs/lensfun/CMakeFiles/lensfun.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
make -f src/external/lensfun/libs/lensfun/CMakeFiles/lensfun.dir/build.make src/external/lensfun/libs/lensfun/CMakeFiles/lensfun.dir/build
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
make[2]: Nothing to be done for 'src/external/lensfun/libs/lensfun/CMakeFiles/lensfun.dir/build'.
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
[  5%] Built target lensfun
make -f src/external/rawspeed/src/CMakeFiles/rawspeed.dir/build.make src/external/rawspeed/src/CMakeFiles/rawspeed.dir/depend
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
cd /home/cedric/workspace/PhotoFlow/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/cedric/workspace/PhotoFlow /home/cedric/workspace/PhotoFlow/src/external/rawspeed/src /home/cedric/workspace/PhotoFlow/build /home/cedric/workspace/PhotoFlow/build/src/external/rawspeed/src /home/cedric/workspace/PhotoFlow/build/src/external/rawspeed/src/CMakeFiles/rawspeed.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
make -f src/external/rawspeed/src/CMakeFiles/rawspeed.dir/build.make src/external/rawspeed/src/CMakeFiles/rawspeed.dir/build
make[2]: Entering directory '/home/cedric/workspace/PhotoFlow/build'
[  6%] Building CXX object src/external/rawspeed/src/CMakeFiles/rawspeed.dir/librawspeed/common/RawImage.cpp.o
cd /home/cedric/workspace/PhotoFlow/build/src/external/rawspeed/src && /usr/bin/c++  -DNDEBUG -I/home/cedric/workspace/PhotoFlow/build/src/external/lensfun/include -I/home/cedric/workspace/PhotoFlow/build/src/external/lensfun/include/lensfun -I/usr/include/gtkmm-2.4 -I/usr/lib64/gtkmm-2.4/include -I/usr/include/atkmm-1.6 -I/usr/include/atk-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/glibmm-2.4 -I/usr/lib64/glibmm-2.4/include -I/usr/include/sigc++-2.0 -I/usr/lib64/sigc++-2.0/include -I/usr/include/giomm-2.4 -I/usr/lib64/giomm-2.4/include -I/usr/include/pangomm-1.4 -I/usr/lib64/pangomm-1.4/include -I/usr/include/cairomm-1.0 -I/usr/lib64/cairomm-1.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/uuid -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gdkmm-2.4 -I/usr/lib64/gdkmm-2.4/include -I/home/cedric/workspace/PhotoFlow/src/external -I/usr/include/OpenEXR -I/usr/include/libdrm -I/usr/include/libxml2 -I/usr/include/orc-0.4 -I/usr/include/libgsf-1 -I/usr/include/ImageMagick-6 -I/usr/include/poppler/glib -I/usr/include/poppler -I/usr/include/librsvg-2.0 -I/usr/include/openslide -I/usr/include/cfitsio -I/home/cedric/workspace/PhotoFlow/src -I/home/cedric/workspace/PhotoFlow/build/src/external/rawspeed/src -isystem /home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/external -I/home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed  -std=c++14 -Wall -Wextra -Wcast-qual -Wextra -Wextra-semi -Wformat=2 -Wpointer-arith -Wvla -Wmissing-format-attribute -Wsuggest-attribute=format -Wno-unused-parameter -Wstack-usage=4096 -Wframe-larger-than=4096 -Wlarger-than=32768    -O3 -ftree-vectorize -DNDEBUG  -std=gnu++11 -march=nocona -mno-sse3 -mtune=generic -Wno-error=narrowing -Dgmic_build -Dcimg_use_vt100 -Dgmic_is_parallel -Dcimg_use_fftw3 -Dcimg_use_tiff -Dcimg_use_zlib -Dcimg_display=0 -fno-ipa-sra -fpermissive -I/home/cedric/workspace/PhotoFlow/src/dt -DLIBRAW_NODLL -DINSTALL_PREFIX='"/home/cedric/workspace/PhotoFlow/build/Release"'  -DLOCALEDIR="/home/cedric/workspace/PhotoFlow/build/Release/share/locale" -DBUNDLED_LENSFUN=1 -DGTKMM_2 -DBUNDLED_LENSFUN_DB=1  -Wno-unused-parameter -Wno-deprecated-declarations -O3 -fPIC   -mtune=generic -g3 -ggdb3 -Werror -std=c++14 -o CMakeFiles/rawspeed.dir/librawspeed/common/RawImage.cpp.o -c /home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed/common/RawImage.cpp
/home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed/common/RawImage.cpp:138:57: error: ‘const’ attribute on function returning ‘void’ [-Werror=attributes]
 void __attribute__((const)) RawImageData::poisonPadding() {
                                                         ^
/home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed/common/RawImage.cpp:159:59: error: ‘const’ attribute on function returning ‘void’ [-Werror=attributes]
 void __attribute__((const)) RawImageData::unpoisonPadding() {
                                                           ^
/home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed/common/RawImage.cpp:177:72: error: ‘const’ attribute on function returning ‘void’ [-Werror=attributes]
 void __attribute__((const)) RawImageData::checkRowIsInitialized(int row) {
                                                                        ^
/home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed/common/RawImage.cpp:191:65: error: ‘const’ attribute on function returning ‘void’ [-Werror=attributes]
 void __attribute__((const)) RawImageData::checkMemIsInitialized() {
                                                                 ^
cc1plus: all warnings being treated as errors
make[2]: *** [src/external/rawspeed/src/CMakeFiles/rawspeed.dir/build.make:128: src/external/rawspeed/src/CMakeFiles/rawspeed.dir/librawspeed/common/RawImage.cpp.o] Error 1
make[2]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
make[1]: *** [CMakeFiles/Makefile2:622: src/external/rawspeed/src/CMakeFiles/rawspeed.dir/all] Error 2
make[1]: Leaving directory '/home/cedric/workspace/PhotoFlow/build'
make: *** [Makefile:152: all] Error 2
Building PhotoFlow finished with return code 2.

Cheers,
Ced.

2

Hi!

Thanks for reporting this problem. Tomorrow I will try to update the RawSpeed library, then we can see if the problem persists…

3

I’d suggest to simply build with warnings disabled.

4

In order to compile PhotoFlow against GTKMM3 you have to pass the following switch to the cmake command: -DUSE_GTKMM3=TRUE

However, for the moment I strongly discourage using the GTKMM3 version, because of UI problems as well as performance issues. My impression is the GTK3 has changed the way idle events are processed, making the program less responsive when using multi-threading.

I am considering moving the whole UI to Qt5, although this will take quite some time.

2 Likes
5

QT move would be great :+1:

6

Hi,

Did you have a chance to look at these errors?

error: ‘const’ attribute on function returning ‘void’ [-Werror=attributes]

Cheers,

7

I’ve updated the latest rawspeed source tree from your src/external folder and I’m getting now the following:

[ 38%] Building CXX object src/CMakeFiles/pfbase.dir/rt/rtengine/rawimagesource.cc.o
cd /home/cedric/workspace/PhotoFlow/build/src && /usr/bin/c++   -I/home/cedric/workspace/PhotoFlow/build/src/external/lensfun/include -I/home/cedric/workspace/PhotoFlow/build/src/external/lensfun/include/lensfun -I/usr/include/gtkmm-2.4 -I/usr/lib64/gtkmm-2.4/include -I/usr/include/atkmm-1.6 -I/usr/include/atk-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/glibmm-2.4 -I/usr/lib64/glibmm-2.4/include -I/usr/include/sigc++-2.0 -I/usr/lib64/sigc++-2.0/include -I/usr/include/giomm-2.4 -I/usr/lib64/giomm-2.4/include -I/usr/include/pangomm-1.4 -I/usr/lib64/pangomm-1.4/include -I/usr/include/cairomm-1.0 -I/usr/lib64/cairomm-1.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/uuid -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gdkmm-2.4 -I/usr/lib64/gdkmm-2.4/include -I/home/cedric/workspace/PhotoFlow/src/external -I/usr/include/OpenEXR -I/usr/include/libdrm -I/usr/include/libxml2 -I/usr/include/orc-0.4 -I/usr/include/libgsf-1 -I/usr/include/ImageMagick-6 -I/usr/include/poppler/glib -I/usr/include/poppler -I/usr/include/librsvg-2.0 -I/usr/include/openslide -I/usr/include/cfitsio -I/home/cedric/workspace/PhotoFlow/src -I/home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed -I/home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/external -I/home/cedric/workspace/PhotoFlow/build/src/external/rawspeed/src  -DPF_HAS_LENSFUN     -O3 -ftree-vectorize -DNDEBUG  -std=gnu++11 -march=nocona -mno-sse3 -mtune=generic -Wno-error=narrowing -Dgmic_build -Dcimg_use_vt100 -Dgmic_is_parallel -Dcimg_use_fftw3 -Dcimg_use_tiff -Dcimg_use_zlib -Dcimg_display=0 -fno-ipa-sra -fpermissive -I/home/cedric/workspace/PhotoFlow/src/dt -DLIBRAW_NODLL -DINSTALL_PREFIX='"/home/cedric/workspace/PhotoFlow/build/Release"'  -DLOCALEDIR="/home/cedric/workspace/PhotoFlow/build/Release/share/locale" -DBUNDLED_LENSFUN=1 -DGTKMM_2 -DBUNDLED_LENSFUN_DB=1  -Wno-unused-parameter -Wno-deprecated-declarations -fPIC   -o CMakeFiles/pfbase.dir/rt/rtengine/rawimagesource.cc.o -c /home/cedric/workspace/PhotoFlow/src/rt/rtengine/rawimagesource.cc
In file included from /home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed/RawSpeed-API.h:28,
                 from /home/cedric/workspace/PhotoFlow/src/rt/rtengine/../../operations/raw_image.hh:59,
                 from /home/cedric/workspace/PhotoFlow/src/rt/rtengine/rawimagesource.hh:39,
                 from /home/cedric/workspace/PhotoFlow/src/rt/rtengine/rawimagesource.cc:30:
/home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed/common/Common.h: In function ‘constexpr size_t rawspeed::roundToMultiple(size_t, size_t, bool)’:
/home/cedric/workspace/PhotoFlow/src/external/rawspeed/src/librawspeed/common/Common.h:87:1: error: body of ‘constexpr’ function ‘constexpr size_t rawspeed::roundToMultiple(size_t, size_t, bool)’ not a return-statement
 }
 ^
make[2]: *** [src/CMakeFiles/pfbase.dir/build.make:648: src/CMakeFiles/pfbase.dir/rt/rtengine/rawimagesource.cc.o] Error 1

Any reason that you are including a copy of the sources of various external libraries, instead of using the libraries directly ?

8

Yes, I want to be certain of the version being used, because then I’m sure I have tested it…

In order to update the RawSpeed code, I suggest you to use the update_darktable.sh script under the tools folder. Just go in the root of the PhotoFlow sources and type

./tools/update_darktable.sh

Have a look at the script first to make sure it does not do anything you don’t like…

I am doing the same from my side, and will push the result to the stable branch once it is tested.

9

If you pull the stable branch, it should compile fine now…

10

Yes works great!

…any tips how to use your DR compressor? Do I need to use a specific output settings/format from HDRMerge?

11

Nothing really special on the HDRMerge side, but I suggest to save in 32-bit floating point format.

The DR compressor can also be considered as a shadows/highlight adjustment tool. If you want a good starting point for playing with the sliders, I suggest you to take my edit of the maritime museum PlayRAW.