Would you please clarify. It seems to me that “local” is being used in two contexts. Is slider balance global<>local means balancing 1st slider “global contrast” with only 3rd slider of the local contrast pyramids or all of the pyramids sliders? If it means all pyramids, then maybe should be changed to “balance global<>pyramids”?
2 Likes
See dt_ioppr_get_rgb_matrix_luminance in iop_profile.h.
You can get the profile using dt_ioppr_get_pipe_work_profile_info(piece->pipe) (also in iop_profile.h).
1 Like
Thank you very much, it works perfectly. I don’t see any difference, and it’s a great safeguard in case the user switches profiles.
Have a nice day,
Christian
1 Like
Thank you very much for your suggestion. Personally, I prefer to keep “local” rather than “global,” but this is specified in the tooltips.
Greetings from the Luberon,
Christian
From “Section 2, Local contrast pyramids”:
Is this correct? I have a feeling you mean contrast equalizer, since the tone eq doesn’t operate on frequencies.
I notice there’s some redundancy in the labels. Would it make sense to call the main labels “global” and “local”? Because right now it seems like the labels explain that global contrast is a type of global contrast.
And for the slider called “local contrast”, do you say “local” because it’s larger than fine and smaller than broad? “Medium” would be more descriptive (though still not perfect). Because they’re all local contrasts, not just that slider.
1 Like
Agreed.
Either
“contrast pyramid” (not plural) + “local contrast”; or,
“local contrast pyramid” + “medium/median contrast”
would be best to avoid redundancy.
1 Like
To be clear balance slider is between global and all the 5 sliders of pyramids?
Hello Christian! This makes a big difference, thank you. I always struggled to manage contrasts with my high resolution sensor using the existing modules, that don’t take the sensor resolution into account.
1 Like
Hello,
@siamak, @Soupy, @finestructure, @kofa
Thank you very much for all your comments. I have taken them into account and updated the terminology accordingly to avoid any confusion. I have also replaced the word “pyramid” with ‘spatial’ to avoid any confusion with the “Laplacian pyramid.”
Have a nice day,
Christian
5 Likes
Yes, exactly, now “global versus spatial”.
1 Like
Hello,
The connection is in how each scale is built, both modules use a guided filter (EIGF) to separate the image into layers while respecting edges. This is what prevents halos when you push the sliders hard. The tone equalizer uses it to isolate luminosity bands, this module uses it to isolate detail sizes. Same tool, different purpose.
Greetings from the Luberon,
Christian
1 Like
I see now, thanks for the explanation.
1 Like
With the suggested module name currently being “contrast & texture” it may be a little confusing to have the two main headings “contrast” and “spatial contrast” …
Hi @Christian-B , I notice you have closed the PR. Are you planning to reopen it sometime? I think, It is a great module and should not be cast aside.
Are you planning to release new build reflecting these changes or will be release with master later on?
Oooops PR has gone …
I hope your project will be further developed and will not end up in the bin !!!
I would love to have it in DT … whatever it is called !!!
For me it is about the practical options … rather than a " perfect name "
I keep fingers crossed for you and all users who look forward to it
Andreas
1 Like
Hello,
Yes, I have closed my two open PRs, one for this module and one for the hybrid version of the basecurve module.
I’m very results-oriented, that’s my top priority, and successfully completing a PR requires a level of administrative rigor that I don’t have.
So, to save everyone unnecessary work, I decided to close my PRs and clean up my GitHub to keep things tidy.
Yesterday, I rebased the BC_CM branch, and both modules are now fully integrated and available to the community and developers if any of them find them interesting and decide to create a PR.
Have a nice day,
Christian
No good news …
That’s a real shame. I have kept both modules and as I don’t revisit RAWS I will continue to use them.
Thank you for your efforts.