Well a GitHub “issue” on how to proceed with merging a module. First communication then work!
8 Likes
Hello,
A .zip file is available on GitHub
Greetings from the Luberon 
Christian
1 Like
Developing two unrelated changes at the same time is an advanced use case. It’s understandable that you had trouble. When I do this, I like to use multiple worktrees, but if both branches include overlapping changes, it’s impossible to totally avoid conflicts.
2 Likes
Thank you for these two modules.
I am testing on my negative films.
Slowly getting to hang of it and results are good.
I would like to make a request from you or anyone else who done it.
Do you have any set of preset willing to share? It will be very useful for lazy person like me to have them or be the baseline to create my own.
1 Like
Well done. I look forward to its inclusion in the master branch.
2 Likes
me too, this is awesome work. Some of my photo’s just got that extra with this module. (especially B/W work). I’d wish my programming skills were better.
1 Like
Hi Christian … are you still working on the contrast module ?
From my POV the module is working well … I do use it on every image to a degree .
Weather it is for contrast ( positive or negative ) or texture .
Never use it globally … every time in conjunction with masks .
So I hope it will be accepted by the community
Andreas
2 Likes
Why do you always use masks?
And discussion has moved to GitHub for now, where people are coming up with a plan for how to test, review, and merge this.
For the simple reason that I use local contrast … locally , as the name suggest . Treating subject , foreground and / or background with different levels and scales of contrast . And I do not want any potential haloing occurring … albeit this module does not produce many , if any at all .
BTW … where on GitHub is the discussion going on ? And why moved to GitHub ?
2 Likes
GitHub is a software development platform. Discourse doesn’t have the features that are necessary to discuss software development, let alone actually do it. GitHub helps maintainers manage how changes are accepted into programs.
Plus, all the dt developers are there. Not all the dt developers are here.
1 Like
THX for your reply … much appreciated .
By knowing what GitHub is … just wanted to know where this module is being discussed ? As you said … discussion has moved , but where on GitHub .
Could you be so kind and give me a link to that discussion ?
The link was posted by mino above: Contrast Management RGB : A new scene-referred approach (POC) - #301 by mino
The developers know people like the module, so it doesn’t need more cheerleading. The questions are things like how to enable high quality testing (whether it needs to be split into parts), how the module will be supported going forward, etc. The main concern is that after it’s released, we can’t make a change that affects the results.
2 Likes
OK thanks for the info …