The enhanced functionality of the styles module in lighttable is greatly appreciated. In playing with it I have found a usability problem (for this particular user) : I selected an image, then selected and applied a style (specifically Fuji XTrans III - Velvia), having read the tool-tip for the ‘apply’ option: “apply the selected styles in the list above to selected images”. The result was not to my liking so I clicked on the ‘remove’ option, assuming that its tool-tip would be consistent and say something like “remove the selected styles in the list above from selected images” and this would describe its action. Wrong.
Fortunately I have all these Fuji XTrans III styles backed-up elsewhere, so recovered the Fuji XTrans III - Velvia style by using the ‘import’ button. But that still leaves me with the question of how do I un-apply a style, other than going into the darkroom and selecting a suitable reset point in the history stack (which presupposes that I know what additions to the stack were made by the application of the style)?
Is the (possibly dangerous) inconsistency in the tool-tip wording worth noting on Github ?
You assume two things here: a text for the tooltip, and the action button performed…
That you assume that a button does do something without checking is NOT an inconsistency in the program…The more so when the action that button does perform is as described in said tooltip, and consistent with the placement of said button…
If I understand you question correctly you would go into the history stack and discard the history to remove the applied style from the image. As for the wording of the tooltip in my view the current wording is appropriate as the button will remove the style from the list.
I tend to disagree with both of the above posts: I think there is an inconsistency here:
The two ‘buttons’ (perhaps not the correct term) in the styles module are close together with no obvious (to me) different features which would suggest they represent distinctly different operations: ‘apply’ applies a set of editing steps to an image, lead one to expect that ‘remove’ would remove those editing steps, rather than removing that style entirely from dt, such that it cannot be used on other images going forward. The actions are of entirely different ‘types’ - especially given that one has to do something quite different, in a different panel, in order to undo the apply step. In many of the other processing modules the undo takes place right where you are and is, ergonomically, the logical inverse of what you just did. The ‘reset’ button on each of the processing modules is a case in point.
I remain surprised, with a feeling of having been ‘burned’ (but nothing serious) by the action of ‘remove’ being not at all the opposite of ‘apply’. Now, having got slightly blackened fingers, I won’t do it again and consider the matter closed.
you can’t unapply a style the same way you apply a style.
There are two ways to apply styles - overwrite or append. In append mode you can undo it manually in darkroom by stepping back in the history stack; in overwrite mode that way isn’t usable
Applying a style can be undone using Ctrl+Z, but only if you do it immediately after applying the style.
Otherwise, the remove button’s behaviour is:
consistent with the remove button of the images utility module;
when it appears next to create and edit (and not next to apply), the context is quite clear, I think. Maybe the tooltip could be reworded: removes the selected styles in the list above → removes the styles selected in the list above (but I’m not native speaker).
If a miracle happened such that I found myself in your position, I would probably sigh too; it has been my experience from a previous-2 life that users can be really …ing annoying; I probably am a representative sample of the class.
