Filmulator Quarantine Dev Log

Software Filmulator
,
67

I’ve implemented vignetting correction, woo!

Next is distortion and CA correction.

4 Likes
68

CA correction is now functional.

However, on the images that I’ve tried, Auto CA correct seems to perform strictly better.

I’ve set the two to be mutually exclusive, but I might also make the Lensfun CA correction hide itself completely whenever auto CA correction is available.

1 Like
69

Distortion correction is now functional as well.

Now I need to make it automatically crop a corrected pincushion-distorted image.

1 Like
70

Aaaaand with the help of an autoscale method in Lensfun, that’s done too.

Woo!

2 Likes
71

A few more notes:

  1. I added a check so that monochrome cameras never have either form of CA correction available.
  2. I found at least one lens (Panasonic 14/2.4) that gets better results from Lensfun’s CA than from Auto CA Correct, so I’m leaving both options open if available. Still mutually exclusive, though.

Now to figure out how to build lensfun from source in msys2. It’s been holding up the Windows builds ever since I discovered that 3.95 isn’t new enough.

72

In MSYS2, I’ve only had success with static builds of lensfun. With dynamic build, missing support libraries; I handled two, then gave up…

73

At the moment, I’m not even getting cmake to run, when I’m doing the same things as in my Linux builds.

74

Here’s my cmake command for git-cloned lensfun 0.3.2:

$ cmake -G "MSYS Makefiles" -DCMAKE_INSTALL_PREFIX="$MSYSTEM_PREFIX" -DBUILD_STATIC=ON ..
75

I discovered that it was restricting too strongly to lenses for the camera mount, meaning you couldn’t correct for adapted lenses, so I tweaked the search routines so that if you put a backslash ("\") as the first character in the search box, it stops taking into account the camera model.

1 Like
76

Since I’m done adding features for now, I think tomorrow I’ll work on updating the documentation to account for all the new features.

And then back to work on Monday.

77

Dynamic build of lensfun seems straightforward. my lasts build is lensfun_master_v0.3.95-517-g609148cc.

mkdir build
cd build
cmake -G “MSYS Makefiles” -DBUILD_TESTS=OFF -DCMAKE_INSTALL_PREFIX=<LensfunInstallDir> -DCMAKE_INSTALL_DATAROOTDIR=<LensfunInstallDir>/share
<PathToRepository>
-DCMAKE_BUILD_TYPE=Release
make
make install

be aware that the DB in your local repo seems not up to date. I use @ggbutcher SW to update it.

To use the library in your app build script
before cmake:

LENSFUN=<LensfunInstallDir>
PKG_CONFIG_PATH=“$LENSFUN”“/lib/pkgconfig:”$PKG_CONFIG_PATH

Copy the dll and the DB located in

$LENSFUN/share/lensfun/version_2

78

I see that I was using -G "Unix Makefiles" instead of MSYS Makefiles, but changing that alone didn’t help.

Next I’m going to try omitting the .., since @gaaned92’s seems to leave that off…

79

The … is how cmake finds the CMakeLists.txt file, in the parent directory, after you mkdir and cd into build from the top lensfun directory.

80

I understand that, and I had that before, but it wasn’t working so I had to try it. Unfortunately, Azure Pipelines doesn’t show any of the cmake output, so I have no idea what’s going wrong.

edit: it now does say that it can’t find a CMakeLists.txt file, so clearly it was running before… just it’s impossible to debug.

edit 2: seems like the reason it’s not showing any output is because it’s running inside of msys bash. Now I’m trying running cmake in whatever shell that azure gives us.

81

Oh.

A starting assumption for shell syntax would be PowerShell… ?

82

The syntax doesn’t really matter, it’s just running cmake.

It would be nice to understand what I’m working with, though, haha

83

Now it’s complaining about not being able to find the glib2 dependency, which I do have installed…

Maybe I need to manually find the glib2 library directory and tell cmake to look there.

84

I ran into that, IIRC I had to install, like, a version 2.0 of the glib library as what MSYS2 provides by default isn’t that.

WRT cmake, I think most of the parameters should be Powershell-safe, but in general you need to consider such parameter-by-parameter…

85

The tool I used most to work through the MSYS2 dependency issues was pacman -Ss <searchstring>, which brought up a list of available packages that match the string, and marked the ones that were already installed. And, there were a lot of missing things…

86

I’ve been finding the packages by simply googling "msys2 " but even when installing those packages, cmake doesn’t seem to find them.