However, on the images that I’ve tried, Auto CA correct seems to perform strictly better.
I’ve set the two to be mutually exclusive, but I might also make the Lensfun CA correction hide itself completely whenever auto CA correction is available.
I added a check so that monochrome cameras never have either form of CA correction available.
I found at least one lens (Panasonic 14/2.4) that gets better results from Lensfun’s CA than from Auto CA Correct, so I’m leaving both options open if available. Still mutually exclusive, though.
Now to figure out how to build lensfun from source in msys2. It’s been holding up the Windows builds ever since I discovered that 3.95 isn’t new enough.
I discovered that it was restricting too strongly to lenses for the camera mount, meaning you couldn’t correct for adapted lenses, so I tweaked the search routines so that if you put a backslash ("\") as the first character in the search box, it stops taking into account the camera model.
I understand that, and I had that before, but it wasn’t working so I had to try it. Unfortunately, Azure Pipelines doesn’t show any of the cmake output, so I have no idea what’s going wrong.
edit: it now does say that it can’t find a CMakeLists.txt file, so clearly it was running before… just it’s impossible to debug.
edit 2: seems like the reason it’s not showing any output is because it’s running inside of msys bash. Now I’m trying running cmake in whatever shell that azure gives us.
The tool I used most to work through the MSYS2 dependency issues was pacman -Ss <searchstring>, which brought up a list of available packages that match the string, and marked the ones that were already installed. And, there were a lot of missing things…
@CarVac
Do you use MSYS2? In that vase you have to use the mingw64 shell to get a result as it brings all the needed environment variable.
And yes, you have to load the dependency packages of lensfun with pacman.
$ pacman -Ss glib2
mingw32/mingw-w64-i686-glib2 2.64.2-1
Common C routines used by GTK+ 2.4 and other libs (mingw-w64)
mingw64/mingw-w64-x86_64-glib2 2.64.2-1 [installé]
Common C routines used by GTK+ 2.4 and other libs (mingw-w64)
msys/glib2 2.54.3-3 [installé]
Common C routines used by GTK+ and other libs
msys/glib2-devel 2.54.3-3 (development)
glib2 headers and libraries
msys/glib2-docs 2.54.3-3
Documentation for glib2
then
$ pacman -S mingw-w64-x86_64-glib2
avertissement : mingw-w64-x86_64-glib2-2.64.2-1 est à jour – réinstallation
résolution des dépendances…
recherche des conflits entre paquets…
Paquets (1) mingw-w64-x86_64-glib2-2.64.2-1
Taille totale installée : 21,95 MiB
Taille de mise à jour nette : 0,00 MiB
:: Procéder à l’installation ? [O/n]
n
and the same for all needed packages. And you surely need mingw-w64-x86_64 packages.