GTK3 warnings when building from source

plaven · June 10, 2018, 10:43am

Hi to the Devs,

I’ve moved to Manjaro from Ubuntu and have been seeing the following when building RT from source:

[ 98%] Building CXX object rtgui/CMakeFiles/rth.dir/fattaltonemap.cc.o
In file included from /usr/include/gtk-3.0/gtk/gtk.h:100,
                 from /usr/include/gtkmm-3.0/gtkmm/enums.h:28,
                 from /usr/include/gtkmm-3.0/gtkmm/widget.h:47,
                 from /usr/include/gtkmm-3.0/gtkmm/action.h:31,
                 from /usr/include/gtkmm-3.0/gtkmm/toggleaction.h:29,
                 from /usr/include/gtkmm-3.0/gtkmm.h:95,
                 from /home/pete/repo-rt/rtgui/xtransprocess.h:22,
                 from /home/pete/repo-rt/rtgui/xtransprocess.cc:20:
/usr/include/gtk-3.0/gtk/gtkfilechooserbutton.h:66:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved1’ [-Wparentheses]
   void (*__gtk_reserved1);
        ^
/usr/include/gtk-3.0/gtk/gtkfilechooserbutton.h:67:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved2’ [-Wparentheses]
   void (*__gtk_reserved2);
        ^
/usr/include/gtk-3.0/gtk/gtkfilechooserbutton.h:68:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved3’ [-Wparentheses]
   void (*__gtk_reserved3);
        ^
/usr/include/gtk-3.0/gtk/gtkfilechooserbutton.h:69:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved4’ [-Wparentheses]
   void (*__gtk_reserved4);
        ^
In file included from /usr/include/gtk-3.0/gtk/gtk.h:271,
                 from /usr/include/gtkmm-3.0/gtkmm/enums.h:28,
                 from /usr/include/gtkmm-3.0/gtkmm/widget.h:47,
                 from /usr/include/gtkmm-3.0/gtkmm/action.h:31,
                 from /usr/include/gtkmm-3.0/gtkmm/toggleaction.h:29,
                 from /usr/include/gtkmm-3.0/gtkmm.h:95,
                 from /home/pete/repo-rt/rtgui/xtransprocess.h:22,
                 from /home/pete/repo-rt/rtgui/xtransprocess.cc:20:
/usr/include/gtk-3.0/gtk/deprecated/gtkstatusicon.h:74:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved1’ [-Wparentheses]
   void (*__gtk_reserved1);
        ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstatusicon.h:75:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved2’ [-Wparentheses]
   void (*__gtk_reserved2);
        ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstatusicon.h:76:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved3’ [-Wparentheses]
   void (*__gtk_reserved3);
        ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstatusicon.h:77:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved4’ [-Wparentheses]
   void (*__gtk_reserved4);
        ^
In file included from /usr/include/gtk-3.0/gtk/gtk.h:100,
                 from /usr/include/gtkmm-3.0/gtkmm/enums.h:28,
                 from /usr/include/gtkmm-3.0/gtkmm/widget.h:47,
                 from /usr/include/gtkmm-3.0/gtkmm/action.h:31,
                 from /usr/include/gtkmm-3.0/gtkmm/toggleaction.h:29,
                 from /usr/include/gtkmm-3.0/gtkmm.h:95,
                 from /home/pete/repo-rt/rtgui/xtransrawexposure.h:22,
                 from /home/pete/repo-rt/rtgui/xtransrawexposure.cc:19:
/usr/include/gtk-3.0/gtk/gtkfilechooserbutton.h:66:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved1’ [-Wparentheses]
   void (*__gtk_reserved1);
        ^
/usr/include/gtk-3.0/gtk/gtkfilechooserbutton.h:67:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved2’ [-Wparentheses]
   void (*__gtk_reserved2);
        ^
/usr/include/gtk-3.0/gtk/gtkfilechooserbutton.h:68:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved3’ [-Wparentheses]
   void (*__gtk_reserved3);
        ^
/usr/include/gtk-3.0/gtk/gtkfilechooserbutton.h:69:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved4’ [-Wparentheses]
   void (*__gtk_reserved4);
        ^
In file included from /usr/include/gtk-3.0/gtk/gtk.h:271,
                 from /usr/include/gtkmm-3.0/gtkmm/enums.h:28,
                 from /usr/include/gtkmm-3.0/gtkmm/widget.h:47,
                 from /usr/include/gtkmm-3.0/gtkmm/action.h:31,
                 from /usr/include/gtkmm-3.0/gtkmm/toggleaction.h:29,
                 from /usr/include/gtkmm-3.0/gtkmm.h:95,
                 from /home/pete/repo-rt/rtgui/xtransrawexposure.h:22,
                 from /home/pete/repo-rt/rtgui/xtransrawexposure.cc:19:
/usr/include/gtk-3.0/gtk/deprecated/gtkstatusicon.h:74:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved1’ [-Wparentheses]
   void (*__gtk_reserved1);
        ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstatusicon.h:75:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved2’ [-Wparentheses]
   void (*__gtk_reserved2);
        ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstatusicon.h:76:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved3’ [-Wparentheses]
   void (*__gtk_reserved3);
        ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstatusicon.h:77:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved4’ [-Wparentheses]
   void (*__gtk_reserved4);


The build script I use:

pete@kanga~ $ cat bin/build-rawtherapee.sh 
#!/bin/sh

cd /home/pete/repo-rt
rm -rf build
mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE="release" \
      -DPROC_TARGET_NUMBER="2" \
      -DBUILD_BUNDLE="ON" \
      -DCACHE_NAME_SUFFIX="5-dev" \
      -DWITH_LTO="OFF" \
      ..

# make doesn't work from the build dir
make -j8 install
rm -rf /home/pete/rt
mv release /home/pete/rt

Thought it worth mentioning.

Peter.

Claes · June 10, 2018, 11:30am

Post removed since I completely misunderstood the question :-(((.
Sorry about that!

Claes in Lund, Sweden

heckflosse · June 10, 2018, 11:31am

@Claes

He is on Manjaro

Claes · June 10, 2018, 11:33am

Sch**sse!!!
Thank you.
I read his opening sentence backwards :-(((

MfG
Claes in Lund, Schweden

Morgan_Hardwood · June 10, 2018, 11:52am

@plaven

Format your post for readability: http://commonmark.org/help/
The warnings are from GTK+ not from RT.
Always provide relevant version numbers when reporting issues. What version of GTK+ are you using?
“make doesn’t work” is not actionable information.
Use the official build script: Linux - RawPedia

Morgan_Hardwood · June 10, 2018, 2:53pm

I downloaded the last Manjaro, installed it, updated it, followed the simple instructions in RawPedia, and RawTherapee compiled and ran successfully.

floessie · June 10, 2018, 6:13pm

Hi Peter,

FWIW, I got the same warnings under Debian Testing. Just edit /usr/include/gtk-3.0/gtk/gtkfilechooserbutton.h and wait for a fix from your distribution.

HTH,
Flössie

plaven · June 10, 2018, 11:31pm

Hi Morgan,

Point taken on the formatting. I was rushed, and just quickly put it up to raise the question. I’ll take my time next time.

RT is running fine. The warnings are showing up when compiling.

I’ve downloaded the script from the site as per the page, and while it’s a very thorough script to completely automate the whole pipeline, I much prefer, and in many ways enjoy, opening the terminal, changing to the repo directory and doing a git pull and looking at the updates. I also read through the git log to what’s changed, and every now and then do git log -p to see where the code has changed.

I’ve updated my cmake options to align with the cmake options in your script.

I still see the warnings for now, but as mentioned this is a GTK issue not RT. I can, of course now, see that better.

Thanks for your time.

Peter.

plaven · June 10, 2018, 11:53pm

Thanks Flossie, I’ll leave it for now. There’s another warning for a deprecated header file as well.

I’ll google around and see if I can’t find the right place to raise it further.

Claes · June 11, 2018, 8:05am

Morning,

A swift thought: you did install the dependencies (as per http://rawpedia.rawtherapee.com/Linux#Arch.2FManjaro)?

sudo pacman -S --needed cmake exiv2 expat fftw glib2 glibmm gtk3 gtkmm3 lcms2 lensfun libcanberra libiptcdata libjpeg-turbo libpng libsigc++ libtiff zlib

Have fun!
Claes in Lund, Sweden

plaven · June 11, 2018, 9:48am

Hi Claes,

Sure did!

First thing I did when I changed distros is go to that page to find all the dependencies

Peter

sguyader · June 11, 2018, 11:23am

I also see these warnings on my laptop, running Manjaro, but I didn’t mention it here as I saw it is GTK-related, and these are just warnings, not errors. I think it comes form a recent GTK update in Manjaro.

plaven · June 11, 2018, 11:26am

Hi Sebastien,

I should have really taken a closer look at the warnings.

I’ve raised an issue on the Gnome issue tracker:

Peter.

floessie · June 11, 2018, 11:28am

I’d rather think it comes from a GCC update…

Best,
Flössie

Morgan_Hardwood · June 11, 2018, 11:41am

@plaven could you include this in your GTK+ bug report?
The simplest way to reproduce the problem, taken from here:

echo '#include <gtk/gtk.h>' | gcc -Wall $(pkg-config --cflags gtk+-3.0) -c -x c++ -

sguyader · June 11, 2018, 12:24pm

I guess you’re right, GCC has been updated recently too.

ggbutcher · June 11, 2018, 2:03pm

It would appear the condition was added to the long-standing -Wparentheses switch around gcc 8.0. This was added to the documentation around that time:

“For C++ this also warns for some cases of unnecessary parentheses in declarations, which can indicate an attempt at a function call instead of a declaration”

You may not see this switch in the compile commands; it is one of the gaggle enabled by -Wall

plaven · June 12, 2018, 8:57am

Hi Morgan,

Done as suggested.

Peter.

plaven · June 12, 2018, 12:38pm

Turns out it’s already reported and fixed for 3.22.