This can be any email, but SHOULD be valid. Even though I primarily use a gmail address for most purposes nowadays, I still always use my old Cornell address for git commits to public opensource projects for a variety of reasons. (For internal commits at work, it’s my work email, which helps it get associated with our Bitbucket account automatically.)
This is only used when you commit code, whether or not it gets PRed or merged or anything.
It’s used to show authorship of any changes that are made. If you never plan on pushing changes to a public repository you can basically put anything here.
If you are pushing things on github, ideally that email address is associated with your github account in some way - otherwise github may fail to associate the commit with your github account.
I would not advise using @pixls.us since I am fairly certain that for most users (not mods/admins), username@pixls.us is not a valid email. Even if it is, it’s not most people’s primary email. Of course, again, it just doesn’t matter if you never push commits to a public repo.
Great post - as I am not a developer I have often struggled with the ins and outs of git commands, but your explanations have been extremely useful!
One question regarding filmic 6 - how can you tell if this is activated? I assume the new code just replaces the existing filmic 5 and is invoked when you click on the filmic rgb tab. However, I cant see any different options onthe filmic tab on my system.
The main difference in what you will see in the UI is shown here…the math is done differently wrt saturation…as you will see no more curve for it and midtone saturation is now replaced with a slider to tweak extreme luma saturation…
Options…where you change the norms…and it you have never used those well you are in for a surprise…changing them changes the whole output…added as an edit in my first reply
Keeping in mind Kofa’s comments about the normal process of setting up a build and updating it using git pull…you might want to consider removing this paragraph. I think it could be confusing esp to new users, an audience that your post would be targeting… Just a thought…
Are these steps safe to follow without uninstalling current dt master (from opensuse repository)? Ie. keeping current install as is?
Do the steps to build sigmoid work for current master from opensuse (therefore can skip steps 1.1>1.13)? And if so, can similar steps be worked for new filmic v6?
@Soupy , I know nothing about opensuse I’m afraid, someone else will have to answer.
Re. your second point, current master includes filmic V6, if that helps.
Not sure. I gave it half an hour. Cloning into the submodules before it only took a few minutes max, so I assumed something was up. No idea what the suppression command is. Is the test data essential or can I carry on without it?
tim@timmint:~/darktable/build$ cmake -DCMAKE_INSTALL_PREFIX=/opt/DT/
CMake Warning:
No source or binary directory provided. Both will be assumed to be the
same as the current working directory, but note that this warning will
become a fatal error in future CMake releases.
CMake Error: The source directory “/home/tim/darktable/build” does not appear to contain CMakeLists.txt.
…Checking my folders, I notice CMakeLists.txt has been created in /home/tim/darktable. I have no idea why it is there instead of in /home/tim/darktable/build… Indeed the /build folder is empty. I simply followed @phweyland instructions exactly, only adding in git config submodule.src/tests/integration.update none (which worked) as discussed above.
