Importing Shift+Number shortcuts disables unmodified Number shortcuts (Ratings)

Qor · December 23, 2025, 9:50pm

Hi everyone,

I am noticing a strange behavior when importing shortcuts via the settings dialog.

I tried to map the mask creation tools to Shift + 1-6. I imported the following block:

1;shift=iop/masks/shapes/add circle
2;shift=iop/masks/shapes/add ellipse
3;shift=iop/masks/shapes/add path
4;shift=iop/masks/shapes/add brush
5;shift=iop/masks/shapes/add gradient
6;shift=iop/blend/tools/show and edit mask elements

However, after the import, I noticed that the standard star rating shortcuts (unmodified keys 1-5) were automatically disabled in my shortcutsrc:

1=disabled;views/thumbtable/rating;one
2=disabled;views/thumbtable/rating;two
3=disabled;views/thumbtable/rating;three
4=disabled;views/thumbtable/rating;four
5=disabled;views/thumbtable/rating;five

Since Shift+1 and 1 are distinct key combinations, I would not expect a conflict here. Is there a specific reason why the import logic disables the unmodified keys in this scenario, or is this a bug?

I am on Arch Linux using the latest Darktable version.

Thanks,
Chris

wpferguson · December 24, 2025, 6:19pm

What happens if you reassign the ratings keys?

How did you import them?

Qor · December 25, 2025, 10:27am

That’s no problem.

Settings → Shortcuts → Import

I also tried with and without “loading default shortcuts”, or using Alt instead of Shift.

I looked in the manual, but couldn’t find anything about the “logic” behind importing. Should existing shortcuts also be overwritten during import, or are they “protected”? This does not relate to the problem described above.

Thx.

wpferguson · December 25, 2025, 11:37pm

I would say look through the pull requests for shortcuts. I know there were some merged, but I don’t remember the details

Qor · December 26, 2025, 1:01am

I searched through all of that but couldn’t find anything.

github.com/darktable-org/darktable

Importing Shift+Number shortcuts disables unmodified Number shortcuts (Ratings)

offen 01:00AM - 26 Dec 25 UTC

QorStorm

### Is there an existing issue for this? - [x] I checked and did not find my is…sue in the already reported ones ### Describe the bug Hi everyone, I am noticing a strange behavior when importing shortcuts via the settings dialog. I tried to map the mask creation tools to Shift + 1-6. I imported the following block: 1;shift=iop/masks/shapes/add circle 2;shift=iop/masks/shapes/add ellipse 3;shift=iop/masks/shapes/add path 4;shift=iop/masks/shapes/add brush 5;shift=iop/masks/shapes/add gradient 6;shift=iop/blend/tools/show and edit mask elements However, after the import, I noticed that the standard star rating shortcuts (unmodified keys 1-5) were automatically disabled in my shortcutsrc: 1=disabled;views/thumbtable/rating;one 2=disabled;views/thumbtable/rating;two 3=disabled;views/thumbtable/rating;three 4=disabled;views/thumbtable/rating;four 5=disabled;views/thumbtable/rating;five Since Shift+1 and 1 are distinct key combinations, I would not expect a conflict here. Is there a specific reason why the import logic disables the unmodified keys in this scenario, or is this a bug? I am on Arch Linux using the latest Darktable version. Thanks, Chris ### Steps to reproduce Settings → Shortcuts → Import I also tried with and without “loading default shortcuts”, or using Alt instead of Shift. ### Expected behavior Keep 1-5 for rating. Import the new Shortcuts ### Logfile | Screenshot | Screencast _No response_ ### Commit _No response_ ### Where did you obtain darktable from? darktable.org / GitHub release ### darktable version 5.4.0 ### What OS are you using? Linux ### What is the version of your OS? CachyOS - KDE ### Describe your system Wayland Processor AMD Ryzen™ AI MAX+ 395 Processor 3.0GHz (80MB Cache, up to 5.1GHz, 16 cores, 32 Threads); AMD XDNA™ NPU up to 50TOPS Graphics AMD Radeon™ 8060S Graphics 32GB LPDDR5X 8000 ### Are you using OpenCL GPU in darktable? Yes ### If yes, what is the GPU card and driver? AMD Radeon™ 8060S Graphics ### Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip _No response_

wpferguson · December 26, 2025, 2:51am

Hmmm…

github.com/darktable-org/darktable

add system shortcuts file

master ← ralfbrown:shortcuts_load

opened 03:24AM - 27 Sep 25 UTC

ralfbrown

+176 -4

I decided to take another look at adding a file with shortcuts that can't be reg…istered from code (e.g. because they use both keys and mouse), and found that it was actually pretty simple. So here's a dozen lines of code to load share/darktable/shortcutsrc between the in-code shortcut registration and loading the user shortcuts file from the config directory. Thus any pre-existing user shortcuts will override the default shortcuts in the new file. I've put together a pretty comprehensive set of shortcuts to drive most of the commonly-used sliders in various modules. One commit per module to ease cherry-picking, if desired. The shortcuts also include a few that demonstrate capabilities of the shortcuts system which I don't think any default shortcuts use yet, such as diagonal mouse moves and double/triple keypresses. I will put together a PR for the documentation with whatever shortcuts get accepted and merged.

github.com/darktable-org/darktable

add some more default shortcuts

master ← dterrahe:more_shortcuts

opened 11:05AM - 23 Sep 25 UTC

dterrahe

+65 -80

And, more importantly maybe, rejigged some of the ways shortcuts and actions are… set up internally to make this process less error prone. Based on discussion on #19407 EDIT: added back the optimisation to not fill comboboxes with their individual items when we are just temporarily initialising iops in order to harvest their actions available to shortcuts. Also factored out some curve interpolation method combos, so they now have introspection in shortcuts (you can directly trigger a specific item). Changing to non-draft to get some more feedback on the included default shortcuts

Qor · December 26, 2025, 10:44am

Thanks for pointing that out. I saw and looked at those posts, but couldn’t find any connection to the import problem. Maybe I overlooked it?
Best regards, Chris

Qor · December 26, 2025, 11:23am

Problem solved.

5;shift=iop/masks/shapes/add gradient <- incorrect

6;shift=iop/blend/tools/show and edit mask elements <- correct

Apologies for the inconvenience and thank you for your assistance.

Kind regards, Chris