Local Adjustements 2

On that image and that mask, are you applying any value of something? (Luminance, contrast, chrominance …?) If not, you will not see the changes and intensity to be applied on that mask.
(add)
In the previous example that I have given you, I had changed the value of the ‘Color correction grid’ grid and then I can see the scope of the mask and the intensity.

I understand your example, but in the previous version, the “preview selection deltaE” was showing exactly the affected area by the spot, which is very convenient to adjust the scope parameter:
Ex, version 5.7-1416 (scope at 40 in color and light section ON, no other modification)
image
While it is not the case in the current version 5.7-1765 (scope at 40 in color and light section ON, no other modification):
image

@cabernet_olivier

I improve “Preview Selection deltaE”

Now, you can choose in “settings” the hue (between blue and green) and the intensity of the Color for preview

By default it’s blue at -5

Jacques

Thank you for this modification Jacques!
olivier

@cabernet_olivier

You can now download the version 5.7-1778-gaeafd4426 that solve your problem.

Regards.

1 Like

Hi,
In the masks the way to display “Show modifications whithout mask” should be changed, as it does not show the modifications without a mask but with a mask just like “Show modifications whith mask”.

I think that “Show modifications whithout mask” should be just as it was before changing “Preview selection AE” in version 1765, which looked at the modifications that were made.

Hello Arturo

First, thank you for participating in the improvement :slight_smile:

In fact, it is more complex, menu choices are necessarily limited. What do we fit into what ?

First of all I want to remind that at the origin of “Locallab” (4 years ago) there were no masks.
I was inspired by the interface imagined in 2006 by Nik Software, “U point” (“You point” and you have the result), with no mask (at the end Nik Software add mask, but there were hidden…)

A) original algorithm
So if we go back to the origin of my design, no masks.
I search several month and years and I found an algorithm - without masks, because the masks are not at all intuitive (at least for me) - to solve the problem of detecting shapes, in order to avoid 2 things:

  1. no clipping use (lasso, …)
  2. no layers, no blending, no mask

The algorithm uses several things to meet the goal (I simplifie):

  1. the notions of reference - hue, chroma, luma where is the spot - must take into account the size of the reference
  2. the deltaE notion : deviation between the reference and the “color” of any pixel in the image
  3. the transition notion : the idea of introducing a degression starting from a certain threshold
  4. the structure notion : as in some cases deltaE is not discriminating enough, I introduce the “structure” notion, difference between solids and structure.

In all these cases, the shape of the RT-spot is of little importance (rectangle, elipse, or others)

Resumed of action whithout mask, for me in 90% cases

  • selected a Rt-spot big enough to cover the area to change and it doesn’t matter that it goes beyond
  • selected (or let by default 60%) the transition value (TR) : up to TR% - geographically - of the Rt-spot area, deltaE wil be apply at 100%, after (TR% - 100%) there will be a regression to get to zero
  • selected a “Scope” value : range of deltaE. At 100% no effect for deltaE, all colors are concerned, values by default about 20, must satisfied a majority of cases

Selected the action you want, lightness, chroma, contrast, graduated, local contrast, retinex, etc.
And, it is finished.

But, because the is a but, I had to improve the algorithm

  1. in some cases “Structure” (“Color and Light”, “Exposure”) improve the result
  2. allows RT-spot different from “circle” (rectangle, elipse) in some cases
  3. allows “Excluding spot”, to undo certain actions
  4. 4 sliders (in Expert mode) allows to modified “DeltaE rules” : normal Rules deltaE (dC = dL = dH and linear weakening) - see documentation
  5. 2 sliders (in Expert mode) allows to modified “Transition rules” - normal transition rules - linear weakening XY - see documentation (especially to touch up small defects, red eyes, etc.)
  6. and of course you can open multiple "Rt spot"

B) Masks
Two years ago, I was asked to add masks, inspired by what Alberto had done for “Color toning”
The first question for what to do ? certainly it is a request, probably partly because people have not completely understood the algorithm
But, it’s a request and in some cases original algorithm fails (as Nik software!),so I looked for how and why

I will resume more than one years of changes and improvment

  1. 2 usages for masks : a) improve selection deltaE , b) special effects
  2. generally in “normal” mode you have 3 curves L, C, H, a slider “blend”, a smoother, a chroma slider, a contrast curve
  3. for the 3 curves, you see (thanks to @Pandagrapher ) the 3 references (hue, chroma, luma)
    If blend is at zero, you only improve deltaE ( a) above)
    if blend > 0 or < 0, ( b above) you add or substract the mask of the original image (before threatment) - for Retinex or Tone-mapping you can choose after or before

But, when you get into the logic of masks, you have to go further. So, depending on the case and mode (expert or normal), I added other type of mask - creation of mask - others than the 3 curves LCH : Structure mask and Blur mask (in addition to LCH)
And also work on mask - Structure mask, gamma mask, slope mask, level contrast mask, Laplacian mask, shadows mask, Highlight mask, hue curve mask, dynamic range compression mask
And of course you can uses more than one mask, and more than one spot.
Of course you can see the work on the mask.

C) what to show
We realize that if we had to offer the possibility of showing all the possible choices the selection menu would be very important.
So, I limited the possibilities which at the start were :

  • none - normal display
  • show modifications whithout mask (we can change but for which label ?)
  • show modifications with mask (we can change but for which label ?)
  • show mask
  • structure

About one year ago, one ask me to add “Preview selection deltaE” (someting as in Darktable)

Of course we can change the labels, but it will be difficult, not impossible to change the contents

  • show modification whithout mask : use for the essantial deltaE algorithm, stucture, and transition
    The grey aspects will change when you change curve, sliders, methods,…that acts on luminance, chrominance, hue, and when you change scope, transition and sliders (in settings) that acts on deltaE or transition
    Mask have no action

  • show modification whith mask : same as above, but take into account mask whether the slider blend is zero or not

  • show mask : show the work on the current mask (you cannot show 2 masks in the same screen), blend is not active, transition is not active, deltaE has quasi no effect, deltaE mask have an effect if you uses tools mask (contrast curve, chroma, etc.)

  • show structure : (when possible) - shows in grey the area concerned by structure (Sobel canny algorithm) - structure is “added” to deltaE

  • preview selection deltaE : shows areas concerned by deltaE algorithm, whatever the settings on luminance, chrominance, hue. Tansition is not active, all sliders settings deltaE are actives and of course Scope
    If you change sometings that acts on luminance you will see the result (side effect)
    if you enable mask with (or whitout) blend you will see the changes.

I hope to have been clear

jacques

2 Likes

I understand the delta E selection and masks but I find combining them confusing. I would only want to use a mask if delta E didn’t achieve the result I wanted. Sorry if I have missed this but Is it possible to turn off delta E selection and just use the mask? Ie have everything within the large circle selected at first then use LCH curves to make the selection? Thanks

@spidermonkey

If you want to turned off deltaE selection, just set “Scope” to 100, and (??) transition to 100

jacques

Makes sense, thanks

@jdc

The content should not be a problem because in “show modification whithout mask” the code you had before in “preview selection deltaE” must be before changing it to Olivier.

Current “show modification whithout mask” (bad):

It must be: (old content of “preview selection deltaE”):

  • Without changes:

  • With changes:

I think it should be like that.

@arturoisilvia

Hello Arturo

I have to admit that I don’t understand what you want :slight_smile:

Is it a language problem, a code problem, a semantic problem ? When reading your post, it seems to be semantic…the problem seem to me in the use of the term “mask”. Do you use really a mask ? that is to say enabled 1 or 2 or 3 of the 3 curves LCH in “mask and modifications”?
But perhaps there is a bug somewhere or something else, I don’t understand :slight_smile:

It is not a criticism, but an observation. Is it due to the language, my english is bad, very bad
On another thread, I said in french : “ah si tout le monde parlait français !”

So that we talk about the same thing, on the example that you give, can you provide the raw (or JPG / TIF) and the pp3

The change, I made following the (justified) request to @cabernet_olivier, does not affect the end result. The only change I made, is to adjust the sensitivity of the reaction - in the last version, the response was too weak depending on input (not good). Now the response is quasi independent of the input (except side efftect)

With regard to the 2 headings (and of course the code) : “Show modfications with mask”, or “show modifications whithout mask” no changes for some time, date on which I revised the code to remove redundancies and bugs (about 3 or 4 mount ago or more…)

Perhaps you want that I adjust the sensitivity response, in a way that makes it more visible (the same way I changed for "preview selection deltae) ?

Best regards, and again thank you for trying, testing

jacques

@arturoisilvia

In doubt, I made a small modification for “Show modifications with or whitout mask”
Commit 05d9362

Now, you can set the intensity of the changes. it is different from “Preview selection deltaE”
Here it is important that there is a concordance between the desired modifications (L, C, H) and their overview (it’s not the case for Preview selection dE)

I change the label in settings

Old : Color preview selection dE
New : Color preview selection dE - Intensity Show modifications

with setting at 1, same result as before, at 5 or -5 important increasing and for 15…

jacques

I also feel bad about English …

In other words, the idea I wanted is to recover the operation (or performance or code) that was in “Preview selection AE” of 1765-ga4ef7e8b6 and put it in “Show modifications whithout mask”.

Well, I’ll try Commit 05d9362 to see how it goes …

Well, I’ve already tried it. It’s OK now.
Only it remains to shorten the name of the label a bit:
instead of “Color preview selection dE - Intensity Show modifications”
put “Color preview selection dE and Intensity” or similar.

Thanks, I will continue testing.

1 Like

@arturoisilvia

Ok I am happy now, We have found together what was the problem…

It’s not code - or at least not code to process - but only a multiplier to best see the differences .

I will change soon the label

Thank you :slight_smile:
An good testing :sweat_smile:
jacques

Label change commit 54e298e

I tested the Win 32-bit versions from:

https://keybase.pub/gaaned92/RTW32NightlyBuilds/

RawTherapee_newlocallab_5.6-904-g77befeff6_WinVista_32_190609.zip

RawTherapee_newlocallab_5.6-1142-g9939b833a_W32_generic_190808.zip

And they both crash when RT starts.

Clipboard01

@dngimage
I don’t know for your links, but now I think builds are here

Others new
I added a new tool to “wavelet pyramid”
it is a tool that exists in the main version but that I carried locally…much work

This tool is “Edge sharpness
Certainly the appearance is deceptive and looks complex, the algorithm is complex…But the result is (for me) very good.

In summary you can use local contrast only on the edges.

And to better see the effects of each setting, better than a long speech, activate “show modifications whithout mask” (whith or whithout coloration)

Then try, the default settings should often be fine, just activate with “strength”, “wavelet levels” and “scope” (as others tools in Local adjustements"

jacques

1 Like

@jdc

The only link I have to RTW32NightlyBuilds is this one:

https://keybase.pub/gaaned92/

RawTherapee_newlocallab_5.6-904-g77befeff6_WinVista_32_190609.zip

and

RawTherapee_newlocallab_5.6-1142-g9939b833a_W32_generic_190808.zip

are there but they both crash when RT starts.

Is there a link to get the new one?

@dngimage

I don’t know perhaps @gaaned92 can update ?

jacques