I hope it fixed the crash in all cases (I limit the value of “lumaref”)
I improved “local denoise” with
a) add DCT (Discrete Cosinus Transform = Fast Fourier Transform) to improve Luma denoise
b) improve slightly algo, more progressive
I just push a change “db03c16”
I deeply retouched the local module denoise
Discrete Cosinus Transformed, added to Luminance and Chrominance : 2 sliders “details”
Of course in addition to wavelets, which work for both Luma and Chroma with 4 sliders (fine and coarse for luma and fine and coarse for chroma).
In addition I reviewed the progressivity and the nature of “denoise wavelet”
One remark, the shape detection is rough, I have not implanted the adhoc module with the color detection, because the noise will penalize the algorithm, but it is possible to do (??)
Contrary to what I said so far, I added a simplified “scope” function for “local denoise”.
This function will make it possible to increase the differentiation within the selected zone, for example by treating only the skin.
By default I set “scope” to 30. If you select scope> 90, all colors are treated identically.
But, sorry, in my “optimization”, I have forgoten to take into account the slider “Chroma detail (DCT)” (it was good in previous version not optimized)
@jdc Jacques, there’s a possible bug in the latest build (just compiled from commit 2c5e992…). When I set several RTspots, the on/off state of the modules is not reset when switching between spots.
For example, if I turn “Color and light” on for RTspot #1, when I create a new RTspot #2 it shows “Color and light” already “on”. Of course the sliders are at their default values, but it’s confusing when you have several spots with different modules activated.
Cela a toujours été comme cela (du moins depuis que j’ai installé cette option) : l’activation “on / off” de chaque module “color and light”, “retinex”, “denoise”, etc. est globale pour tous les RT-spots…et j’ai du l’écrire quelque part
Bien sûr il est possible de changer cela, mais cela va complexifier le système
Jacques
Je viens de trouver où c’est écrit ==> dans Rawpedia
"J’ai ajouté, pour faciliter l’utilisation et éviter les menus trop longs en mode écran, une interface GUI similaire à celle de Wavelet, avec des “expanders”. Vous avez ainsi la possibilité pour chaque famille d’action (color and light, Blur, Retinex, etc.):
_faire apparaître ou non le détail des commandes : curseurs, méthodes, courbes,.._
_ activer ou non l’ensemble des fonctions de la famille d’action._
Attention, le choix - 2 - active ou annule l’ensemble des RT-spot ( spot de contrôle); il est théoriquement possible d’associer cette possibilité à chaque RT-spot, mais quel intérêt ? "
I didn’t realize that.
Anyways, I was using the Local Lab on very big files (stitched panorama in 16-bit TIFF, 22131x3611 pixels!) and I had to use RTspots one by one, saving the result at each step, because it needed too much memory and crashed too often (particularly in “Denoise”). So I did get confused as I never had too many RTspots at the same time.
I will look tomorrow, I think it will be possible to enabled/disabled each “part” for each Rt-spot, but I think we will loose the posoobilities of expanders “memory open or close - expand or not, etc” that are stored in “option” and then not updatable in real time.
Rq : now the system works very bad (expanders) and I don’t know why (this as not due to locallab, it is a general problem with expanders).
It will probably be the last of 2017 …
I will be away from my home from Saturday 23 December until 3 January 2018. Meanwhile Internet connections will be problematic
This update is important because it significantly improves the shape detection algorithm by reducing artifacts - often due to the presence of a little chrominance noise that is often almost invisible
By default, “quality method” is set to “enhanced” instead of “enhanced + chroma denoise”. This without quality reduction will reduce processing times (except for Denoise).
In difficult cases you can choose “enhance + chroma denoise”, or activate the noise reduction in “denoise” (chroma)
I recommend cleaning the cache (pp3 and mip), to have an update of the default settings.