Local Lab build


(Sebastien Guyader) #1

Hi,

Jacque Desmis @jdc was kind enough and spent a lot of time to update his “Local Branch” and merge Master into it. I made a Windows 64 bits (Gtk2) binary: http://filebin.net/plpf68xmj7

Feel free to test, and use in your photography :slight_smile:

-Sébastien


Where is Local Lab please?
is there a tool in rawtherapee that changes particular part of the image?
Hi. A couple questions/suggestions, but first,Therapee is AWESOME!!
PIXLS.US Blog - Giving Thanks
(Johannes Leitner) #2

Hi,

thank you both - and the other developers. This looks great
Is there a possibility to use one tool ie local lab, gradient) more than once?

Johannes


#3

Thanks! I was missing a more stable version of it :slight_smile:


(dngimage) #4

Sébastien and Jacque,
Thanks for the new Local Lab build.
Very nice! :slight_smile:

I like the independent (mouse) shape method.

It would be nice to have a way to draw the shape with the mouse with a selection-lasso tool. That way you can select the area with more precision.

Keep up the great work.


(Ingo Weyrich) #5

I’m currently working on speedups for Local Lab build to make it more responsive especially when adjusting the local lab area in gui. Current version is a bit sluggish…
Status of my work is, that adjustments to local lab area are now in 30 ms range on my machine (has been about >300 ms before).
When this work is completed we should think about how to implement more than one local area and how to reflect this in RT gui. Currently I’ve no Idea how to do that. For this reason I would appreciate suggestions from Local Lab users.

Ingo


(Sebastien Guyader) #6

Ingo, I think most users of Local Lab would love 2 features:

  • Possibility to define 2 or more areas
  • Possibility to draw the area (have more, arbitrarily positioned control points

#7

Fully functional Local editing is like the only one important feature
for me which is missing in RT, so imagine my smile right now. I won’t
(unfortunately) help you with coding, but here is an idea borrowed from NIK to implement more controls points.I know it’s a bit diffrent idea, but what i like about that is the clarity of it and possibility to turn on/off preview masks. As far as i know mask drawing feature is difficult to implement (?)…so what about control points?


(dngimage) #8

And here is, what it would look like
if there was a way to draw the selection shape
with the mouse using a lasso or a polygon mouse selection tool.


(Cyril LAPORTE) #9

Hi,
Thanks for carry on with this !
Not sure it will help, but I really found that this tool is magical ! Adapting somthing from that would be perfect !
http://gimpchat.com/viewtopic.php?f=28&t=11081

“Background points are set with the right mouse button (or pressing key ‘B’), while foreground points are set with the left mouse button (or key ‘F’).
You can also convert a foreground point to a background point at any time.”


(Ingo Weyrich) #10

I just pushed a lot of changes to locallab branch. Still only one region, but some bugs are fixed, it’s a lot faster now, ‘add noise’ is improved, it allows more accurate positioning of affected region (last version had a granularity of 1/200 of image dimensions, this one has 1/2000) and the size of the center circle corresponds much better to the region the averages are picked from. The change from 1/200 to 1/2000 breaks compatibility to old locallab pp3 files, which means you have to define the regions again.
you can follow the work here


(Desmis) #11

Ingo thank you for all the improvements.

Here are several issues to deal or not.

  1. The first is almost resolved, it is to stabilize and accelerate the process that I developed there are now 2 years.
  2. The second is to improve the current operation to approach the old U-points CNX2. The current operation is approaching, but there are still issues to be resolved.
    It must be possible to make more efficient existing algorithm, but also can be (to be developed) using algorithms as Retinex and Wavelet.

Then and this is where I think we will have difficulties:
3) we will be able to set up layers (or something equivalent) to easily manage more than one point …or work around the problem by inserting more control points, for example in the RGB process, or wavelet, or elsewhere
This will not be easy to due to the construction of the pipeline RT
4) develop another GUI to replace the sliders, via an interface linked to the mouse
:slight_smile:


(Morgan Hardwood) #12

An idea of how multiple tool instances for multiple local adjustment points could work:

Every tool gets a new “instance” combobox at the top of the tool frame/vbox. Instance 0 is always the global effect the tool has, as every tool in RT currently works. But you could add a new instance of a tool which could be used by the Local Adjustment tool to adjust a small area, or it could be also global, working as a layer.
For example you set exposure compensation to +1EV globally, instance 0.

When you add a new adjustment point you select the tool you want it to use, e.g. Exposure to brighten up the left eye in a portrait, and place the local adjustment point on the preview. A new instance, 1, is automatically added to the Exposure tool’s instance combobox. The Exposure tool’s sliders are reset for instance 1. You set exposure compensation to 0.5EV for instance 1.

You can add a second local adjustment point also for the Exposure tool, so it gets a new instance, 2, for the right eye. +0.7EV.

You can select any instance from the combobox at any moment - this sets the sliders of that tool to show the settings which that instance uses. If you select instance 0 then the Exposure Compensation slider moves to the +1EV position, if you select instance 1 it moves to +0.5EV, if you select instance 2 it moves to +0.7EV.

The main preview shows a dot with a number, this number corresponds to the instance, so you can see “Aha, the left eye uses the exposure local adjustment instance 1”

PP3 handling: each tool section gets an instance index, so [Exposure] changes to [Exposure#0], [Exposure#1], [Exposure#2], etc. If an instance of e.g. Exposure is used locally, then the Local Adjustment tool gets a [Local Adjustment#1] section.

The local adjustment tool would not re-implement each supported tool as it does now. Instead, the tools would be made to handle multiple instances. Perhaps the output of instance 0 would go into the input of instance 1, if it exists, or into the input of the next tool’s instance 0 if the current tool does not have multiple instances. So the pipeline would still be fixed but allow multiple instances of a single tool.


(Andrew) #13

I’m interested to know, from you guys at the centre of RT, what the “mission statement” is! Is it to build the best raw processor there is, with the proviso you take the output to Gimp, say, if you subsequently need layers? Or is the aim to make RT the full app with raw conversion, layers and maybe other stuff? (I haven’t had chance to try Local Lab yet, and have never used Gimp so far)


(Morgan Hardwood) #14

https://github.com/Beep6581/RawTherapee/blob/master/README.md


(Sebastien Guyader) #15

A new Windows 64-bit build of the “Local Lab” branch can be downloaded here.
Enjoy!


New Windows builds
Where is Local Lab please?
(Andrew) #16

Many thanks Sebastien, and to those who developed it. I just used it to make the fruit in the shade a bit punchier. Before-


With Local Lab -

This will be a useful tool and avoid me going into another app to do the local adjustment (which will involve a chunk of learning curve). A few comments though… It would be nice to be able to rotate the area like Graduated Filter. Also, with Local Lab switched on, I loaded the .pp3 profile for an old version of this photo, i.e. made with a previous version of RT. RT left the Local Lab on. I suppose ideally RT should detect that the pp3 pre-dates the new tool, and therefore ensure it is off? But thanks again for this nice new tool.


(dngimage) #17

Thanks for the new RT Local Lab version!
Running RawTherapee_WinVista_64_Local_Lab_Release_4.2.912 here.

Love the lightness, blur effect and the new widget shape.
Local Lab is my fav RT version.

Did a quick test on one.
From far away this morning:


#18

For 32 bits users, you can find in my RT drive
Locallab branch 4.2.950 (release)


(Andrew) #19

hi, I was using LocalLab on this photo:-


I wanted to liven up the strip between the railings, the buildings etc, and so I wanted it to act all the way across, at least all the way on the left side. Unless I missed something, I could only drag the marker to the boundary of the photo, and then with the “feathering” / gradient at the edge, it left a good chunk unaffected by the local lab settings. It would be nice if local lab could go right to the edge. One possible way to do this would be to add a function which allowed a strip of image to be added to one or more sides, after de-mosaicing. Then the markers (or selection tools, whatever) could go beyond the edge of the photo, and all the tools would hopefully work fine, being none the wiser. Andrew.


#20

Looks awesome!

Is it likely to find it’s way to Linux and osx editions as well? Or have I completely missed something and it’s already there?