I just added xtrans 2-pass (combination of xtrans 1-pass and xtrans fast)
Since there is the contrast threshold adjuster for sharpening, I use much more aggressive settings
But the threshold only works by masking away things that are soft. What if one could also mask away things that already are sharp enough? Would that be possible? Does it even make sense to do so?
Great idea about the x-trans 2-pass. The other day I was thinking that with this new compound demosaicing method, 3-pass sharpening for x-trans could be less useful (or at least, less often needed).
That would also be possible. Whether it makes sense, I don’t know atm…
Sébastien, currently the xtrans method names showed in gui are:
"4-pass", "3-pass (best)", "2-pass", "1-pass (medium)", "fast", "mono", "none"
which is not correct anymore as 3-pass is not the best imho. Can you, being an xtrans user, suggest better method names?
Info, maybe the 1-pass and 3-pass choices can be renamed to something like “1-pass (Markesteijn)” and “3-pass (Markesteijn)”. And 2-pass could be renamed “fast + 1-pass”, and 4-pass “fast + 3-pass”.
Sébastien, to keep things consistent with bayer demosaicers (where the flat demosaic algorithm is the second in the name), would you also agree with
1-pass + fast 3-pass + fast
How about family pass or season pass?
Joking aside, for consistency, maybe:
If you like add (combo), (hybrid), (dual), or whatever next to it.
I just opened a bug for you : https://github.com/Beep6581/RawTherapee/issues/4639
I get sometimes artifacts while playing with the contrast slider.
It could make sense if you are trying to even out the sharpness across the entire image. Usually the corners and edges are less sharp than the center. And most lenses are not radially symmetrical in sharpness either.
The other case for protecting edges that are already very sharp is to avoid the development of sharpening halos and/or clipping of the pixels along the edge.
I don’t have any Amazing and so on mode on Demosaicing tab:
O! I find that this mode is for Canon/Nikon, but I’m working with Fuji.
Yes, I select 3-pass + fast.