[New module] [Merged] Color harmonizer

[europlatus]

@Soupy

Saturation is usually a parameter that can be increased or decreased on a scale of -100 to 100% with mid point at 0, yet in the above screen shot you appear to have something like 0 to 200%, suggesting it can only be increased not decreased. Is this purposeful?

The sliders actually start at 100%, and saturation can be decreased to 0 or increased to 200%.

I think it would probably make sense to copy Color Balance RGB here and make the sliders -100%, 0%, +100%

[europlatus]

@Masterpiga

What about “low saturation protection”?

That sounds a bit obscure to me. How about just “Neutral color protection”?
The manual mentions “neutral color” quite a bit, and I like the word “neutral” in there because I think it’s immediately obvious what we’re referring to.

[Soupy (Tim)]

I’m not the biggest fan of putting the saturation controls in drop down, I think they could be quite useful, and avoid the need to open the color equalizer.

What about this for a mock-up:

EDIT: of course if saturation is included it is now just one more slider, “brightness”, away from the color equaliser.

[Masterpiga (Daniele Pighin)]

Thank you all for your feedback!

Current UI looks like this:

@Soupy

I’m not the biggest fan of putting the saturation controls in drop down

I really want to keep the UI as simple as possible for the simple cases.

I had explored the double sliders per swatch concept, but I find it more cumbersome, and I like that the current UI provides some process guidance, i.e., first find a harmony that makes sense for your image, and then play with the saturation to fine tune the effect.

@Soupy

of course if saturation is included it is now just one more slider, “brightness”, away from the color equaliser.

This should not become a duplicate of ColorEq, otherwise there is no point

This module is not meant to be used in isolation. I think it’s perfect to be used as a foundation for more fine tuning in ColorEq or CbRgb.

Actually, this is kind of the whole point that I was trying to make when I wrote On module proliferation. Those modules provide a horizontal foundation of controls that “free” other modules from having to encode that level of fine-grained controls. In my view of a perfect ecosystem, they would be the glue that you use between more specialized, result-oriented modules to achieve the desired aesthetics with as little fiddling as possible.

@europlatus

That sounds a bit obscure to me. How about just “Neutral color protection”?

Done.

@Soupy

Around the other way, “sync vectorscope” would be better.

Renamed to “vectorscope two-way sync”, to make it clear that the synchronization happens both ways.

@europlatus

I think it would probably make sense to copy Color Balance RGB here and make the sliders -100%, 0%, +100%

I would find that confusing, unless I rename the section “saturation boost”, but then a “negative boost” is also kind of counter intuitive. It could be named “saturation multiplier” and range between [0, 2], but that is also less intuitive and it’s too mathematical. I find that “Saturation” in [0%, 200%] with a default of 100% is very clear and self explanatory.

I am currently focusing on adding some optimizations to make processing faster and smoother.

[Soupy (Tim)]

@Masterpiga

Renamed to “vectorscope two-way sync”, to make it clear that the synchronization happens both ways.

By definition:

“Sync” (short for synchronization) means to align, match, or harmonize two or more things to act at the same time, speed, or rate.

Therefore, calling it “two-way” is redundant. Saying the same thing twice.

@Masterpiga

I would find that confusing, unless I rename the section “saturation boost”, but then a “negative boost” is also kind of counter intuitive. It could be named “saturation multiplier” and range between [0, 2], but that is also less intuitive and it’s too mathematical. I find that “Saturation” in [0%, 200%] with a default of 100% is very clear and self explanatory.

Why would you rename it “boost” if the changed slider ranges [-100, 100] made it more clear you can both “reduce” and boost"? -100, 100 is far less confusing to communicate you can both increase and decrease saturation, than 0, 200. Not only that, but it is standard in other modules. See color balance rgb as a prime example.

[Masterpiga (Daniele Pighin)]

@Soupy

“Sync” (short for synchronization) means to align, match, or harmonize two or more things to act at the same time, speed, or rate.

Sync can be used for many things. “pushing” and “pulling” are two kinds of unidirectional sync. “The lights are in sync with the music” is intended to mean that the lights change based on the music, not the other way around. I think that “two-way” is a useful clarification that makes it more evident that you can also control the module with the vectorscope (which you wouldn’t think of trying otherwise).

@Soupy

Why would you rename it “boost” if the changed slider ranges [-100, 100] made it more clear you can both “reduce” and boost"? -100, 100 is far less confusing to communicate you can both increase and decrease saturation, than 0, 200

Because if the label says Saturation and the value of the slider is 0, to me that mans “No saturation”, which is not what it is doing. Anyways, it’s a detail that can be discussed at review time.

[Soupy (Tim)]

@Masterpiga

Because if the label says Saturation and the value of the slider is 0, to me that mans “No saturation”, which is not what it is doing.

By default it should be neither increasing nor decreasing, which is exactly what 0 represents.

Above you said:

@Masterpiga

I find that “Saturation” in [0%, 200%] with a default of 100% is very clear and self explanatory.

To me, if something is at 100% it would be having a strong effect, which is not desirable by default.

If 100% here means “no effect” then 0% is the best representation of that. Again, it’s how every other module works.

[Masterpiga (Daniele Pighin)]

@Soupy

By default it should be neither increasing nor decreasing, which is exactly what 0 represents.

Agreed, but then I think that “saturation” itself is not a sufficient label. It should read “saturation correction”, “adjustment”, or something along those lines.

[Soupy (Tim)]

Then you’d have to change it also in color balance rgb, color equaliser, etc… but it is a perfectly fine label in those modules, and will be in yours too

That the slider exists to make a correction or adjustment is self evident. It doesn’t need to be stated.

[Cranky (Granky)]

@Soupy

To me, if something is at 100% it would be having a strong effect, which is not desirable by default.

If 100% here means “no effect” then 0% is the best representation of that. Again, it’s how every other module works.

AgX uses 100% saturation as the default.

[Soupy (Tim)]

True. I never noticed that since it is hidden in the “look” selection which I keep collapsed.

I suppose 0, 200 is saying 0% has no saturation, while 200% has double. Whereas -100, 100 is saying you can increase or decrease the saturation by this amount.

I still think the logic of this module is more similar to that of color balance rgb and color equalizer than agx, but I’ve said enough, so I’ll check out now.

[Masterpiga (Daniele Pighin)]

Claude and I did some efficiency improvements. I wanted to share this video because I think that it’s quite funny, with all the sliders running around when I scroll on the vectorscope

[Masterpiga (Daniele Pighin)]

Aaaaaaand, it’s a PR

Initial implementation of Color Harmonizer module.

Let’s see how it goes

Anybody who is curious about the technicalities can whet their appetite here:

dev-doc/iop/colorharmonizer/business_logic.md

@Pascal_Obry FYI

[Christian-B]

Hello,
Congratulations! I’ll have to take some time to try it out

[hatsnp (Nuno Paulino)]

Your PR says: JzAzBz color space. Wasn’t it changed to use dt UCS?

[Masterpiga (Daniele Pighin)]

Good catch. Stale notes. Updated, thanks!

[Masterpiga (Daniele Pighin)]

The link in the OP points to fresh packages.

Extensive community testing would be greatly appreciated

[thumper]

@Masterpiga

Current UI looks like this:

Beautiful!

[thumper]

@Masterpiga

Claude and I did some efficiency improvements. I wanted to share this video because I think that it’s quite funny, with all the sliders running around when I scroll on the vectorscope

That is actually very impressive.

[gwbarn]

I seem to be stuck on Vectorscope mode with no buttons to change it, even when I’m in Darkroom on an image without the module enabled or focussed. Using the AppImage build from a few minutes ago.