Thanks, builds ok
There were some attempts to provide a correction to the winsock2 issue in exiv2, but I cannot compile the last version. So I wrote a bug report.
Thanks, builds ok
There were some attempts to provide a correction to the winsock2 issue in exiv2, but I cannot compile the last version. So I wrote a bug report.
You’re right. Next time, I’ll do this. I have it all the time so it won’t be difficult to have a new example.
I compiled version 1.5.4 stable and my user commands are not active in the context menu. However, I copied the folder correctly. Where do we put the usercommands folder in the stable version?
@agriggio
for the development version I put them there
my two versions art (master dev) and ARTstable (release) were compiled from the same / programs folder
There should be no difference, user commands go in $HOME/.config/ART/usercommands
strange…
Are you sure you didn’t specify some non-default option to cmake?
its good! I just realized that there were several ART files in .config it’s solved … Thank you for your patience
@agriggio
@Carmelo_DrRaw has problems building with the automatic CI build as he is no longer able to find the old version of libjpegturbo permitting to compile jdatsrc.cc
see Nightly Development Builds for Windows Users - #4 by Thanatomanic
@heckflosse is going to commit a patch to get around the issue see MSYS2: last version of libjpeg-turbo triggers a link error · Issue #4713 · Beep6581/RawTherapee · GitHub
Could you have a look at that as the problem is the same with ART
Thanks
Sure,thanks for the heads up!
in the meantime, I’ve just pushed a change to clean up the jpeg handling code. Can someone with libjpegturbo 2.x test and see if it works? Thanks!
If you followed the instructions from here: Windows - RawPedia , all you have to do is to remove
IgnorePkg = mingw-w64-x86_64-libjpeg-turbo
from \etc\pacman.conf. After this, when you update msys libjpeg-turbo will get updated.
I just tried it now with an up to date msys2 and libjpeg-turbo 2.0.5-1 and all is fine. It compiles and seems to work just fine.
confirmed.
I renamed raw files with the jpg suffix. ART ignores them it seems without message even under debug.
I cannot believe you can make such amount of corrections in a so small time.
Regarding exiv2: I hope the issue is corrected.
So here is the example :
So where is the problem ?
The workaround :
So, in conclusion on my side, most of the time the problem occurs when the 2 lines around the starting point are curves. But, I had times with 2 or more curves for one shape. Next time I have this, I send to you.
I hope that I was clear enough.
Example.7z (4.2 KB)
Thanks, now I can reproduce. Turns out this is likely to be an exiv2 bug, which I’ve just reported:
https://github.com/Exiv2/exiv2/issues/1358
However, I’ve implemented a workaround that should solve this hopefully.
Thanks. ^^
Edit : OK, I understood, you transform coordinates and stuff in base 64.
By the way, @agriggio and @gaaned92 I’ve noticed that with the last commit some more libraries are now added to the dependencies list (at least on Windows):
At least on my computer, ART did not wanted to start without all of the above.
I suspect these come from exiv2. Can you trying building the library yourself and see if you can n turn off “stuff related to http”?
Here nothing changed, and I don’t remember shipping those libs in the installer
I have the feeling that I added thoses dependencies for some time.
After testing with last vesion of exiv2 0.27-maintenance
branch, I find that they are no longer used.
to build exiv2
cmake -G “MSYS Makefiles” -DEXIV2_ENABLE_WIN_UNICODE=On -DCMAKE_CXX_STANDARD=11 -DCMAKE_CXX_FLAGS=-Wno-deprecated -DCMAKE_INSTALL_PREFIX=<installdir> -DCMAKE_INSTALL_DATAROOTDIR=<installdir>/share …/exiv2 -DCMAKE_BUILD_TYPE=Release
to link with it
PKG_CONFIG_PATH=<installdir>"/lib/pkgconfig:"$PKG_CONFIG_PATH
Please confirm