packager feedback for 1.4.0~beta4

Software Siril
1
  • when building with intree yyjson your build system installs the .a file without need.
  • gcc 7 seems no longer enough:
[   23s] In file included from ../src/filters/deconvolution/estimate_kernel.hpp:28:0,
[   23s]                  from ../src/filters/deconvolution/estimate_kernel.cpp:27:
[   23s] ../src/filters/deconvolution/fft.hpp: In instantiation of ‘plan_t<T>* make_plan(dim_t, int) [with T = float]’:
[   23s] ../src/filters/deconvolution/fft.hpp:120:39:   required from ‘auto fft::c2c(const E&, bool) [with E = img_t<std::complex<float> >]’
[   23s] ../src/filters/deconvolution/fft.hpp:133:19:   required from ‘auto fft::r2c(const E&, bool) [with E = img_t<float>]’
[   23s] ../src/filters/deconvolution/estimate_kernel.hpp:94:54:   required from ‘L0ImagePredictor<T>::L0ImagePredictor(const img_t<T2>&) [with T = float]’
[   23s] ../src/filters/deconvolution/estimate_kernel.hpp:466:23:   required from ‘void l0_kernel_estimation(img_t<T2>&, img_t<T2>&, const img_t<T2>&, const img_t<T2>&, estimate_kernel_options&) [with T = float]’
[   23s] ../src/filters/deconvolution/estimate_kernel.cpp:65:50:   required from here
[   23s] ../src/filters/deconvolution/fft.hpp:110:23: warning: unused variable ‘inserted’ [-Wunused-variable]
[   23s]      auto [it, inserted] = cache.emplace(dim, plan_t<T>(dim, flags));
[   23s]

forcing the compiler to 14 fixes the issue.

test package is here

if you want to work on gcc 7 compat, comment out line 32.

2

Thx for the feedback. I will what I can do.

3

TBH not all needs to be changed but maybe just documented :slight_smile:

oh btw: if you see things we can improve on the package or additional things that might be worth shipping, let us know.

1 Like