Phase one P65+ in darktable

darktable

#1

Support for the Phase one P65+ exist in rawtherapee. Is it possible to have it in darktable?


(Ingo Weyrich) #2

ping @LebedevRI

I can try to help with this one as I optimized (multithreaded) Phase one decoding in RawTherapee. So I know a bit at least…


(Roman Lebedev) #3

Best to use an actual issue tracker - https://redmine.darktable.org/issues/11097

if you have that camera, can you check how many raw modes does it have total?
I suspect we have two incomplete sets. It would be great to get one full set

Just checked on P65 samples from RPU.
All samples other that IIQ S seem to work.

That is trivial in this case.
That code was prepared for parallelization / cleaned up a while ago, it just needs a tiny ping.

Will finish up and push tomorrow.


(Ingo Weyrich) #4

True, but did I write that it’s not trivial?


(Roman Lebedev) #5

:slight_smile:


#6

I have uploaded a complete set, L & S for the full resolution & for sensor+.


(Roman Lebedev) #7

RawSpeed commit[s], darktable commit[s].

Anyone just loves looking at benchmarks? (from the RawSpeed merge commit message)

raw.pixls.us/IIQ/Phase One/P65$ ~/src/googlebenchmark/tools/compare.py benchmarks ~/rawspeed/build-Clang-Release/src/utilities/rsbench/rsbench{-git-develop,} CF027310.IIQ --benchmark_repetitions=100
RUNNING: /home/lebedevri/rawspeed/build-Clang-Release/src/utilities/rsbench/rsbench-git-develop CF027310.IIQ --benchmark_repetitions=100 --benchmark_out=/tmp/tmpTLT_R3
2018-09-23 10:49:17
Running /home/lebedevri/rawspeed/build-Clang-Release/src/utilities/rsbench/rsbench-git-develop
Run on (8 X 4000 MHz CPU s)
CPU Caches:
  L1 Data 16K (x8)
  L1 Instruction 64K (x4)
  L2 Unified 2048K (x4)
  L3 Unified 8192K (x1)
-----------------------------------------------------------------------------------------------
Benchmark                                        Time           CPU Iterations UserCounters...
-----------------------------------------------------------------------------------------------
<the actual repetition measurements omitted>
CF027310.IIQ/threads:8/real_time_mean          534 ms        534 ms          1 CPUTime,s=0.534244 CPUTime/WallTime=0.999999 Pixels=61.3002M Pixels/CPUTime=114.745M Pixels/WallTime=114.744M Raws/CPUTime=1.87185 Raws/WallTime=1.87184 WallTime,s=0.534244
CF027310.IIQ/threads:8/real_time_median        535 ms        535 ms          1 CPUTime,s=0.53477 CPUTime/WallTime=0.999997 Pixels=61.3002M Pixels/CPUTime=114.629M Pixels/WallTime=114.628M Raws/CPUTime=1.86996 Raws/WallTime=1.86995 WallTime,s=0.534773
CF027310.IIQ/threads:8/real_time_stddev          2 ms          2 ms          1 CPUTime,s=2.48947m CPUTime/WallTime=10.235u Pixels=0 Pixels/CPUTime=536.619k Pixels/WallTime=536.655k Raws/CPUTime=8.75394m Raws/WallTime=8.75454m WallTime,s=2.48962m
RUNNING: /home/lebedevri/rawspeed/build-Clang-Release/src/utilities/rsbench/rsbench CF027310.IIQ --benchmark_repetitions=100 --benchmark_out=/tmp/tmpw41jv0
2018-09-23 10:50:14
Running /home/lebedevri/rawspeed/build-Clang-Release/src/utilities/rsbench/rsbench
Run on (8 X 4000 MHz CPU s)
CPU Caches:
  L1 Data 16K (x8)
  L1 Instruction 64K (x4)
  L2 Unified 2048K (x4)
  L3 Unified 8192K (x1)
-----------------------------------------------------------------------------------------------
Benchmark                                        Time           CPU Iterations UserCounters...
-----------------------------------------------------------------------------------------------
<the actual repetition measurements omitted>
CF027310.IIQ/threads:8/real_time_mean          113 ms         28 ms          6 CPUTime,s=0.693269 CPUTime/WallTime=6.16091 Pixels=61.3002M Pixels/CPUTime=88.4222M Pixels/WallTime=544.759M Raws/CPUTime=1.44244 Raws/WallTime=8.88674 WallTime,s=0.112534
CF027310.IIQ/threads:8/real_time_median        112 ms         28 ms          6 CPUTime,s=0.69326 CPUTime/WallTime=6.15746 Pixels=61.3002M Pixels/CPUTime=88.4231M Pixels/WallTime=544.972M Raws/CPUTime=1.44246 Raws/WallTime=8.89021 WallTime,s=0.112483
CF027310.IIQ/threads:8/real_time_stddev          1 ms          0 ms          6 CPUTime,s=811.783u CPUTime/WallTime=0.0477898 Pixels=0 Pixels/CPUTime=103.539k Pixels/WallTime=4.06117M Raws/CPUTime=1.68905m Raws/WallTime=0.0662505 WallTime,s=859.558u
Comparing /home/lebedevri/rawspeed/build-Clang-Release/src/utilities/rsbench/rsbench-git-develop to /home/lebedevri/rawspeed/build-Clang-Release/src/utilities/rsbench/rsbench
Benchmark                                                 Time             CPU      Time Old      Time New       CPU Old       CPU New
--------------------------------------------------------------------------------------------------------------------------------------
<the actual repetition measurements omitted>
CF027310.IIQ/threads:8/real_time_pvalue                 0.0000          0.0000      U Test, Repetitions: 100 vs 100
CF027310.IIQ/threads:8/real_time_mean                  -0.7894         -0.9476           534           113           534            28
CF027310.IIQ/threads:8/real_time_median                -0.7897         -0.9478           535           112           535            28
CF027310.IIQ/threads:8/real_time_stddev                -0.6547         -0.9238             2             1             2             0