Phase One Quadrant Correction Continuation #207... & then?

dim · March 25, 2020, 5:29pm

Since mid-november, i reported a problem with Phase One’s IQII raws. It was confirmed, it’s a bug. I’m not capable to code, but i can understand the amount of work & competence needed & hidden behind the sliders. I gave what i’m capable to do to help: free images, some tests & observations, noise profile, built-in icc, home-made sensor’s icc. When it’s in my competences, i try to help peoples who struggle with DT’s stuffs. Since then there is no bug’s correction, nothing. I tasted (since darktable 0.6, already 10 years!) the capabilities of the 3.1.0 version, so i’m frustrated to use software i don’t like to work with. May i still hope?!

heckflosse · March 25, 2020, 5:47pm

As you wrote RawTherapee handles those files correctly, maybe rawspeed can borrow some code from here…

github.com

Beep6581/RawTherapee/blob/dev/rtengine/dcraw.cc#L1652

    
      
          #endif
                      for (int row=0; row < raw_height; row++) {
                          for (int col = (tag & 1)*ph1.split_col; col < raw_width; col++) {
                              RAW(row,col) = curve[RAW(row,col)];
                          }
                      }
                  } else if (tag == 0x400) {			/* Sensor defects */
                      while ((len -= 8) >= 0) {
          	            col  = get2();
          	            row  = get2();
          	            type = get2();
          	            get2();
          	            if (col >= raw_width) continue;
          	            if (type == 131 || type == 137) {		/* Bad column */
                              for (row=0; row < raw_height; row++) {
                                  if (FC(row-top_margin,col-left_margin) == 1) {
                                      for (sum=i=0; i < 4; i++)
                                          sum += val[i] = raw (row+dir[i][0], col+dir[i][1]);
                                      for (max=i=0; i < 4; i++) {
                                          dev[i] = abs((val[i] << 2) - sum);
                                          if (dev[max] < dev[i]) max = i;

dim · March 25, 2020, 6:04pm

Thank you!

paperdigits · March 25, 2020, 6:12pm

Your last post on the bug report was six weeks ago, why not post there again?

Also note that rawspeed is more or less a one man operation, made by @LebedevRI for free, in his free time. Maybe he’s been busy, or not well, or just not in the mood.

Writing to say your impatient that someone isn’t working for free is problematic, to say the least.

dim · March 25, 2020, 6:31pm

Impatient is a big word! I know people work for free & in free time… Your judgement is harsh! My post i think is respectfull. I didn’t know it’s the work of one man @LebedevRI… And why i post it here, it’s a way to find help from others & maybe it works. Ps: Last post is 29/01. je vous présente mes excuses!

paperdigits · March 25, 2020, 6:41pm

Impatient was your choice of words in the bug report. I don’t make judgments, I’m just telling you how it works in hopes you can understand why your request has not been filled.

dim · March 25, 2020, 7:07pm

I understand. So I apologize to @LebedevRI. In my defense, the meaning of the word “impatient” in French is less derogatory. My bad!

LebedevRI · March 25, 2020, 7:15pm

It’s not really a fair characterization i’d say.
For sure i did not write all that code,
i only been maintaining it for some last few years.

paperdigits · March 25, 2020, 7:41pm

I don’t think you need to apologize, I just want you to have a clear understand of the way things work Nor do you need any defense. We’re all trying to improve things as we can!

paperdigits · March 25, 2020, 7:41pm

This is what I meant, sorry for not being clearer.